From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0043.outbound.protection.outlook.com [104.47.38.43]) by dpdk.org (Postfix) with ESMTP id 42C2C28F3 for ; Mon, 15 Jan 2018 15:32:36 +0100 (CET) Received: from BN6PR03CA0074.namprd03.prod.outlook.com (10.164.122.140) by BN6PR03MB2689.namprd03.prod.outlook.com (10.173.144.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Mon, 15 Jan 2018 14:32:35 +0000 Received: from BN1AFFO11FD043.protection.gbl (2a01:111:f400:7c10::155) by BN6PR03CA0074.outlook.office365.com (2603:10b6:405:6f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Mon, 15 Jan 2018 14:32:35 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; caviumnetworks.com; dkim=none (message not signed) header.d=none; caviumnetworks.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD043.mail.protection.outlook.com (10.58.52.190) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Mon, 15 Jan 2018 14:32:34 +0000 Received: from [10.214.249.235] ([10.214.249.235]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0FEWVod016247; Mon, 15 Jan 2018 07:32:32 -0700 To: Jerin Jacob References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-5-git-send-email-hemant.agrawal@nxp.com> <20180115123132.GB833@jerin> CC: , , From: Hemant Agrawal Message-ID: Date: Mon, 15 Jan 2018 20:02:30 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20180115123132.GB833@jerin> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131605003547327379; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(39860400002)(39380400002)(396003)(346002)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(24454002)(50466002)(76176011)(104016004)(53546011)(23746002)(305945005)(105606002)(230700001)(106466001)(356003)(97736004)(65956001)(65806001)(47776003)(64126003)(36756003)(67846002)(31686004)(498600001)(65826007)(81166006)(4326008)(8936002)(53936002)(77096006)(83506002)(54906003)(85426001)(229853002)(2906002)(8676002)(31696002)(6246003)(5660300001)(58126008)(86362001)(81156014)(6916009)(68736007)(93886005)(316002)(2950100002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2689; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD043; 1:sfhh7bEmwydkLbSrmdt+eFEXGFLxeIRVEM94H0F1UJBF4ZbUf7Q8pU1FUsFTQcMjlUQC9Hz1R1AMKUdxyjlhDsa3OqEcHbApOzmEIEGIBm6lLVjz0QFipukeaDWV2psb X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f21b979-a30b-43bc-3b93-08d55c24d191 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:BN6PR03MB2689; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2689; 3:HbLsjXJ0ZyQ7DNgStjj1d7YF7Da1HqQvB/V2JA555zG7S+M2TRg6s7lFM2PRPKBV16nKu6I4J0af2NYwNxI55vmuLZVBWM2Pgk25LjZww+ky+ZbgaO7XTKiBxnuFwnAuQMlIkfcbB5l9BG9B0NVIHPA86JIOpWu2LmR1Wq7xX5k6PX3zpAXDjgQVuQEjOC4kAzAQ6YM9Y/thwgespQsN9D0o6ok3hcQkjliNpYPVsucWjj9DvFbSs8R4MQicUGI5RH3q4+aHojsN079S2uE4qvJ0ngfYj1pB/twooGp9tP1dEmc9FY1A4i2Sd2xv+WLh7IYo8JoeUHfIs482BGaF7UEfKpEQDF9YglMWDDblFNg=; 25:Ybb+VD9cXv0FA79yqGp1y8qK8SprDTBzNXZ+T1RFjUKiPuw5LNwRBwNHl/9ops7eYs5HiSOluHpjIFc8uEKpFKhj/RF4Wzt24+wzL3D1sSsaOiNfXlwkK0mruyEiJd3fwsCxdRub/XDGzL5TPE0hELP6C9TyVC2m9rS54+3gJn9SXRmWgW9JtqUJuKNi817OMwcjlHeG8u4d8v48h62VO8YWxQhc/Yx3fP/+/Zf5QCdaApmld/eO3tT+20JY1CGf6NfpNaTeoLtsUwhatuYvhsfCx6I48rmP5Lyl6rN09SONuh7XWtmtgaDXamwaAMxM3sRjmHMgakwIVOitPXxp/g== X-MS-TrafficTypeDiagnostic: BN6PR03MB2689: X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2689; 31:Ky9EX2bRIsJ0qCJwxyuU4oOep2WQGCBLn11hSPfjEoJhyCg+SltXv4Ju0q5dDQ1zzey3jdT8Ppy2Qz8ByLkFgQrjpX73h/gQ8XYQo1iCgexzr7NW8UbPz+kZmyVKX9bsmOYMdE5/No1MME+dBPO2PcC7LryyvfzrBHgF8GNANsUOhUR+v/OFnV72pgOCnFIaA67t9bdFl3Sbq1meSnGaXnhP20As4hpDGzVfTadM+W8=; 4:TMqSFTHhL/P1elG7gCkLKcjlrCMLyqnaCOVkLEkVpqXzjWpHo/Qi/HKD3eCqSGxZ6epkJlG13HAufmcZGlTGToF84zvVewVN04IdNHw6lrwsJxQu+La9WKDUv8GZd7JQ2HIxaN/uaLmJ1UJROc/twEiFW61FXZUHFM3AZiiFG09YmCv3Lkwn7yCN+j+sDZW2plqEijFMecEzZ3dS+iGTizo+s4UAREJIBQQjILhhiwFhdpEOkYICC7hW5NV1yVirIfGv1gxy1TH9zRAsR41ljt2P9+bQiPxNSHJS+ecQdpyTJnSdSUPdDdrovKEDjnAn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(10201501046)(3231023)(944501161)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123561025)(201703131430075)(201703131448075)(201703131433075)(201703151042153)(20161123559100)(20161123563025)(20161123556025)(20161123565025)(201708071742011); SRVR:BN6PR03MB2689; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:BN6PR03MB2689; X-Forefront-PRVS: 0553CBB77A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR03MB2689; 23:rRSXC8Mx89RPoEnncMMwqM0eg46Rth5935Wya?= =?Windows-1252?Q?1Ub1JT59FhRdF3HsbXxMoo6BiXjxPzmt9QO0dSbzG3ax2mPeqIFwmJtV?= =?Windows-1252?Q?8skTkGNCRQh4ztfWcNYXN5mbSr8hkYyfK7WBytWxyw/vZ4punGe42s0P?= =?Windows-1252?Q?HskVU1+f5yvAiJucEKykU7mxzYP96uYKVv3z6EupM2x1coNh+iHIUE07?= =?Windows-1252?Q?q4DFmMZfqmfGQPRRpdDXvzvO7zJtxiTN8n/NsctFuVx/CVB6UQODJ94T?= =?Windows-1252?Q?SI8bAy0dZ6IiZefMTfvEJHNhd3BWSiVjc3NQTDCBPRh6tJcTh0My9pmt?= =?Windows-1252?Q?onHU2axH6U5UdgDpXNtHqWN6URBUXtZD5/ppDdLNRqe62QaZ6ljzgnsX?= =?Windows-1252?Q?4VxjsihDttGaGAU1ch0f1Bv8I7MbhfCioZU9Cx7upCPkVZUKewridyQt?= =?Windows-1252?Q?TZjPtswcCuZst8oklTkEGIcH1zICD8jlnglfSVh97RtggQytEwCxEac5?= =?Windows-1252?Q?g5RAEYzf+lIXa7RV3p0qtXHeYoVjz6wuvvAzj6s0IM0UlfFMKccbpLEF?= =?Windows-1252?Q?OOYxleTMo3j9x9yEpONUWUFgT+4kBQ18wnO1M5Y+fdlJLdt3dBEEHXbT?= =?Windows-1252?Q?4pH/GJs1hS1RDjKfiv9N+ZyKkvbm42XWy7wwzUKBKhZfM1of7OgqjVGn?= =?Windows-1252?Q?m1nzol0UC6KSN9bXdwP5ZZDaSVK+3koHrJ8ynqOfuqYfPk3kcy4AUV9b?= =?Windows-1252?Q?YMdFxHO161U6ZaKgBtwi2FfzY+5tIEEhWijaV3xCKMfQ1iY96SCTSkcj?= =?Windows-1252?Q?rLfBkWzytuIScdtABERY4HpF4WbSxnnm4zaFi3p1JlbyvrKOIXncEcJN?= =?Windows-1252?Q?Gbk3TQoaDSBMZzNJOqFa6syR+aCqJxvorN6d6xWaVuhAx5/d8kkN4gS/?= =?Windows-1252?Q?VSBCFAypdSY3OoVRKs9Y75d3WZcLSc6qCEJMYgDjZ+j2oN0hsvOIXD+K?= =?Windows-1252?Q?H+XI8iuTdDBGqWNRUolc4kjj+5RB+GDSSuRQy3NAhqc/wDOtiqyeOBKy?= =?Windows-1252?Q?bO5uoHPTQM2YRwQi4wbJfAbheipdlynCPsHkjduuO68kbsjM9el3Lb0b?= =?Windows-1252?Q?/sVyjJ3m6kKpoKzbrHfZBfXFralgs26NqmcHhxpNkCEcfHFYmwlYCUo7?= =?Windows-1252?Q?lTfLIGjSrPycTTgWlP+0BdNhRVPx1OXjCHTHKwIc4qBmPuzqAwEmJpNj?= =?Windows-1252?Q?bJTgWwHYoAoqdOBF3EIs/Mhca1FegDW3MDYo9WmAK+x9QLOxTveIoAsY?= =?Windows-1252?Q?wYaz+boA1X373LKlsZv6Ky8WDUwATAeb83VyCVx6GNgJw2uc0LnIO7Vh?= =?Windows-1252?Q?q3g1v5vkOhi?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2689; 6:J+RLjAHTwtxRbczmM0Ggu5pfI4P7hOe8IzvCQH0JzC7cemSjNxNm8trTSYODJnlpmuIF76Q48TzYBlKM2WuVYRwyjpbGZJzA2taCayQ7iVpNJJE2ziZarkX1e3JVY3Icak6/6Ez7X/orVVp1PrAxgg0O3OJiEI6fLFqZ1PWTzX68+aoX2bvtUY0QOtFPtCncYQC1i2+adoG0IzA34xdjuq3qnnWjAuv8qe25cTer3yhVylAgbNsLCcwT86reOk69pGqoKR0NlAiNTnv/+5QnruVuA6WhROMqrWKKQ5xisJtQsnE4IwhIr3DTBrFTgIAo4Lyphi/Q8y8fEaXLjq+UTtIz7eleO0KmoWSmrjUj2A4=; 5:pWES/XB/QK+xqWWwmkv3yw/4fbnfwdtEk63SRkxAHjp9p+Xob0ymW3c0xrsF7nCflbnP/mIERNP7uALtGUE0ANxgJz2Vd8qeA7DFzYTxzBfV2cVv8XhYQhoEtqlmywSGN+3JfZYgKXpy/DH+cZk0WwTlvZiv0Y6qqH9nkl+FDI4=; 24:I/ak2sOZjGwCTMfQsMhfLMqZfj962lKrRfP9k8B1VIEiqokbhJItg27q+BUpa/zzf+U8FIElMM82mv1AjaApNmcrsQPWNQ3RT1H4ZUSPQcw=; 7:bd7KbbDhf4Di9QZ2//WsX11RdH4VWeReMuVg1+ncOxePhmrvKarXvemHCLMZ0pCOlb57y13yoHGEnNL1DdUSICOiqMqTI49BZqidKCExO0S97ETzi+xNQLiyHAbLA57Cq/3tB3RBpqpgvtxbXUT1W2TInQmsv1moLyQsuFfVSbgc803obdlPCLqR8x8TW8N07O2dFykc45aO2ITM5iJ1Pway+k6WcnaVWeAi6yNt/xj+Ok+oMRb5XeBVocF+h4ZI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 14:32:34.3583 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f21b979-a30b-43bc-3b93-08d55c24d191 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2689 Subject: Re: [dpdk-dev] [PATCH v2 4/5] mbuf: pktmbuf pool create helper for specific mempool ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 14:32:36 -0000 On 1/15/2018 6:01 PM, Jerin Jacob wrote: >> Introduce a new helper for pktmbuf pool, which will allow >> the application to optionally specify the mempool ops name >> as well. >> >> Signed-off-by: Hemant Agrawal >> --- >> lib/librte_mbuf/rte_mbuf.c | 23 ++++++++++++++------ >> lib/librte_mbuf/rte_mbuf.h | 42 ++++++++++++++++++++++++++++++++++++ >> lib/librte_mbuf/rte_mbuf_version.map | 1 + >> 3 files changed, 60 insertions(+), 6 deletions(-) >> ... >> +rte_pktmbuf_pool_create_specific(const char *name, unsigned int n, > > No strong opinion on name. I think, rte_pktmbuf_pool_create_by_op() may be > a better name than rte_pktmbuf_pool_create_specific() yes. looks better. I will change it in next rev.