From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id ADF17235 for ; Mon, 26 Jun 2017 11:15:02 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2017 02:15:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,395,1493708400"; d="scan'208";a="985229575" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.32]) ([10.237.221.32]) by orsmga003.jf.intel.com with ESMTP; 26 Jun 2017 02:14:59 -0700 To: Thomas Monjalon , Tonghao Zhang References: <1494467793-19887-1-git-send-email-nic@opencloud.tech> <8278174.tmcXUfVEQA@xps> Cc: dev@dpdk.org From: Sergio Gonzalez Monroy Message-ID: Date: Mon, 26 Jun 2017 10:14:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <8278174.tmcXUfVEQA@xps> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 09:15:03 -0000 On 23/06/2017 14:02, Thomas Monjalon wrote: > 22/06/2017 17:15, Sergio Gonzalez Monroy: >> Just fyi, the summary line should be lowercase apart from acronyms (DPDK >> guidelines). >> >> On 11/05/2017 02:56, Tonghao Zhang wrote: >>> The NUMA node information for PCI devices provided through >>> sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx >>> on Red Hat Enterprise Linux 6, and VMs on some hypervisors. >>> It is good to see more checking for valid values. >>> >>> Signed-off-by: Tonghao Zhang >>> --- >> IMHO the message could be slightly improved by adding some of the >> replies that you made to your v3. >> ie. Typical wrong numa node in VMs >> >> $ cat /sys/devices/pci0000:00/0000:00:18.6/numa_node >> -1 > [...] >> The code changes look fine, so I leave it to Thomas regarding the commit >> message :) >> >> Acked-by: Sergio Gonzalez Monroy > Applied, thanks It looks like some systems have quite a few devices that report -1 as numa_node value causing lots of warning messages being printed. Quick fixes that come to mind would be: 1) Change log level to DEBUG 2) Add static var to only print the message once. I also think that the message itself should show at least the BDF to at least know which devices are reporting bad numa_node values. Thoughts? Sergio