From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BA55B457A0;
	Mon, 12 Aug 2024 13:19:19 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A1FAB402C3;
	Mon, 12 Aug 2024 13:19:19 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id E210E4029C
 for <dev@dpdk.org>; Mon, 12 Aug 2024 13:19:17 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E28EFEC;
 Mon, 12 Aug 2024 04:19:43 -0700 (PDT)
Received: from [10.1.38.158] (e132843.arm.com [10.1.38.158])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 754993F6A8;
 Mon, 12 Aug 2024 04:19:15 -0700 (PDT)
Message-ID: <d0f1d134-3a41-4797-a871-b640a0abe6b3@foss.arm.com>
Date: Mon, 12 Aug 2024 12:19:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/5] eal: add atomic bit operations
To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,
 dev@dpdk.org
Cc: hofors@lysator.liu.se, Heng Wang <heng.wang@ericsson.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Joyce Kong <joyce.kong@arm.com>,
 Tyler Retzlaff <roretzla@linux.microsoft.com>,
 =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>
References: <20240809090439.589295-2-mattias.ronnblom@ericsson.com>
 <20240809095829.589396-1-mattias.ronnblom@ericsson.com>
 <20240809095829.589396-4-mattias.ronnblom@ericsson.com>
Content-Language: en-GB
From: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
In-Reply-To: <20240809095829.589396-4-mattias.ronnblom@ericsson.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 09/08/2024 10:58, Mattias Rönnblom wrote:
> <snip>
> +
> +#define __RTE_GEN_BIT_ATOMIC_OPS(size)			\
> +	__RTE_GEN_BIT_ATOMIC_TEST(size)			\
> +	__RTE_GEN_BIT_ATOMIC_SET(size)			\
> +	__RTE_GEN_BIT_ATOMIC_CLEAR(size)		\
> +	__RTE_GEN_BIT_ATOMIC_ASSIGN(size)		\
> +	__RTE_GEN_BIT_ATOMIC_TEST_AND_SET(size)		\
> +	__RTE_GEN_BIT_ATOMIC_TEST_AND_CLEAR(size)	\
> +	__RTE_GEN_BIT_ATOMIC_TEST_AND_ASSIGN(size)	\
> +	__RTE_GEN_BIT_ATOMIC_FLIP(size)
> +
> +__RTE_GEN_BIT_ATOMIC_OPS(32)
> +__RTE_GEN_BIT_ATOMIC_OPS(64)

For the non-atomic operations, the arguments family and qualifier were 
added in the initial commit, and unused until the 
volatile-support-adding commit. Perhaps the atomic equivalents should be 
the same? (ie. add the family and qualifier arguments in this patch and 
don't use them until patch 5/5.

> +
>   /*------------------------ 32-bit relaxed operations ------------------------*/
>   
>   /**
> <snip>