From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BDA0A0C43; Mon, 18 Oct 2021 17:55:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5435040142; Mon, 18 Oct 2021 17:55:42 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 72A4A40141 for ; Mon, 18 Oct 2021 17:55:40 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="228549890" X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="228549890" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 08:55:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="717671197" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 18 Oct 2021 08:55:27 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 18 Oct 2021 08:55:27 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 18 Oct 2021 08:55:27 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 18 Oct 2021 08:55:27 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 18 Oct 2021 08:55:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Av98BNTAysT912ujrez2kanOmy+v0l+UJgenp8lzQ89Zyo4cecQnDUN6WFslAqoEBbCiUEWk+/vTLPzAK2mLu3icCyZlFgglJjl7thRxpkhmP3irKsfQhmIhdOBwvaKVYyAwyGycCAcgV++SJLX9TDHMov3YaHNheqKDDxr5wf9aDh4Gl9aY4EL/q/tHyp4s9mFCE/6JfTw99fyO30GkRpobjlkRKiCvdP22JpF+rJwy7nE9yHSX550cbpXmAnaRKiSMbu6RqdBJdZSuACQWNMnAv+MR5Nv5BVlTFWNz2ay724rKWez825zaOafE0DS+WQeUwqJrS3PbMZqI0O3v1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0az/xYEFGI+ucHT0liX1uueaPH7XYE2EFx0DjCbBhMM=; b=lfuOq7N986AHQWQaKhKyTuke1duoFeSxNrBtG9MS0bPoB/x5ZK2XZNQMHVCgdaVa++XKTsJyts8oEWKW7ZJVuT9wHzLA8QMf3QKIKB0CNlmTuHWXrYu0hbgY2eirqgk1jXOZmQlUerGtrMVsw6lg+4OlM8A6TcgcXd+8LfTAI3YQbeXYTJIiFn4DXvdnxSwqCwT/LWEg/s3+6LJk+FEAS4FjvCMNLfxKqJHz9Nt+lmh9wLUMdqzg05s5JgMf/lh/yHyiBMvEMHyTqTLfipk5eSqwFKqt9puaA4oMhk2FtM2SxA39gS3ha+CmK74pX9LEmSZs9mUj0Qo4aet/n4MItg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0az/xYEFGI+ucHT0liX1uueaPH7XYE2EFx0DjCbBhMM=; b=pCFNiAGRYOvQiVtymKSsc+uKpF6ceOd5U/ZJaxE8Rh2gspTtwFd+8hFNYZYTJ7E02N1d8IPlQuTTaP1RIMrAK1DvmOz+f0JieFbboujRTdl9nNu6JdxIAqQ1hU4EEeKiOxPgfmDeqGybnxmHYGfV3ydCE51ClJhDNK03REU5UEo= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4839.namprd11.prod.outlook.com (2603:10b6:510:42::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct 2021 15:55:21 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 15:55:21 +0000 Message-ID: Date: Mon, 18 Oct 2021 16:55:15 +0100 Content-Language: en-US From: Ferruh Yigit To: David Marchand CC: John Daley , Hyong Youb Kim , Andrew Rybchenko , dev References: <20211015102819.4101559-1-ferruh.yigit@intel.com> <5f0c9b9e-6c15-eaaa-b015-1a88286c17fc@intel.com> X-User: ferruhy In-Reply-To: <5f0c9b9e-6c15-eaaa-b015-1a88286c17fc@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR07CA0200.eurprd07.prod.outlook.com (2603:10a6:6:42::30) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0200.eurprd07.prod.outlook.com (2603:10a6:6:42::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.9 via Frontend Transport; Mon, 18 Oct 2021 15:55:19 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14308d9d-8461-4711-a3eb-08d9924fb047 X-MS-TrafficTypeDiagnostic: PH0PR11MB4839: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mUpeEgexNz3ZFD4Mn3wUPRUc+kSQiRvi9DILBzP0EjOBRXX52E629f+8OXabgFFUOCuwv/XPzQnrKn9Xi/y9iGdy1hfMHI2IJaA3jjxgCPbper+ix0kaOeRpLBPKOGuOtJ6ikEN8yCmg2sEp2/o8NrJ01IBCg6ihzteK2oyHouYdpuHtYRCMbZeTS985lWSpbGVBv0ojjJT+SrQN0L7kjWFisUNeeE5Z7S7RYGWBUlqWg6ex3GlSuDsd1Mhva+KzInif43BOeNYHeSKmentjEq6uzU8xxfv1SEr5UrI+DVkGIcEm2LPR/CiDYId/nC0IKeVA8mb08Q8jcnpIhxd0r4Hq5oLelhwnECv6N9em15AAYmxlpnQUUG/73ToaasybkcnQ3oTp53CYx3W0ooIn4QTQTaRGRLObezChv43KdR7dGLBYMol/jaHAqZ+rQxQX+aGwb1qYNCnpD6uq3R8Yz8/l0ikncHWWDL8xCN5oTbGmSgD8qFyRvjnfWuFNm1xGw23Fkljg01PMMeyEY6YGGLIrGYb+C3VVv411yxw9L5rVBDgB4NQvpL9DO4cRaLFS19gPFBRX5SvV3ilrpAxNw2ZnYowpxPdLklrIciYqSP5IBIRYGVpTqlp5V2kj2LNQlszILsDqw1xEFLme2D5NJJb0faDfKPa83qa5oT3QI8u2HcpMGPwK6Z+crCGiuL7ImA49dCNqAxeTf69gRJDvPg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31696002)(956004)(8936002)(2906002)(26005)(6916009)(8676002)(2616005)(16576012)(508600001)(66946007)(316002)(38100700002)(83380400001)(86362001)(82960400001)(54906003)(53546011)(5660300002)(6666004)(186003)(36756003)(4326008)(44832011)(31686004)(6486002)(66556008)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zjlva0NmNWUxUWRiU0c2ZHRrQmdCRzNTQ2ZKVGg3MGc0TzVUQ1VRMEN3cEtF?= =?utf-8?B?STR4MDdSQXh6aGZQdUZCMEtvazB5VDFtNDdFdEJ2L3ZDM2ttRUdSZ251Unh6?= =?utf-8?B?QmFGM2cvKyswajM5eHFmNDRpNm1mSVEra0l4bkhDcnBMV0xkb2hxRDdXeVJK?= =?utf-8?B?N2hzbWRSVkVoQmRkekc2N3lJbUdvVFRrTlR6VVJCQkJ6bk8za29VNFlNUXJN?= =?utf-8?B?clRkellwcnFwREgycGthSmU3N2VyZjJoTGh4Mk90bWVjeldmaEpYVGRFNEhX?= =?utf-8?B?aFdsd2pKSGxKWWRlc2lPSkdzbzVZdGJFTFRuNUd0WlhIVWJhWU14MmVVSm40?= =?utf-8?B?TmF2L2RRbkJlVVZPVFhVd3FpV3JoYVdFbWh0ay9uRm1UazRISThmaVh2Y1BO?= =?utf-8?B?MUFieXNHdDNlU1pWT2pIeDFaOVcxR1laekc3ZEhzU09xZWY5THRBWFMxZ0Q5?= =?utf-8?B?MXV0NzY4bUhFd3VzS2VFYkR1dmlybkxLYVIzeUVSQWRVd1RaSFhQcm5WNENq?= =?utf-8?B?VmFMR1Q2WnVoSnE4dzlLTk9IQ1g4NFJwdGk3bGQ4TFFleGNiZkpBN2tNRWxF?= =?utf-8?B?aTZ6ZTBWUUZQTFVhclk3ei9iS2ZVc0JQdWdGMHFBYkxtc1Zjakt1QkRjaEoy?= =?utf-8?B?UloxdkkrSHA5UkFlRGk3VFp6MS9mV0V1ODNVSkhoQ0IybmdZRjhlWVoyUFl0?= =?utf-8?B?ZXFMVFlvWDVWbkhEN3l2NzlLQ1NsZHF1aDZrelVkOFZuaE1VYktUa29Gekw5?= =?utf-8?B?eldLRzdEM09QZmJuc2I4UGRVeTlMczN2SW5WanlnOUc5aFJEWmNsUkk4U3lh?= =?utf-8?B?UmsydEw3ckZydUgwb1YvWmd0RjlIU2h2R2ptRXNrN0FISEg1REw5T0RUVUdy?= =?utf-8?B?SEJXcC9peWpJZlBXeWl0SFV4WlRweXhBaXZOTkM0WHRJVVV5ejVOVkEwcWp1?= =?utf-8?B?dEIwaEhkTEYrYXRWaFFldmdOVWdocHh0VFJqY2ZRRVg1RE5ES3dEbWo0ejJy?= =?utf-8?B?RzE0K2tXdXRKN25GV09XQzJ4WmRncWZyWmtlSm1lWkhvVEZrWVFXNFVtb3lv?= =?utf-8?B?V01ZL201K3hHaitveDB6ZnVEQlBwNUgxcng2dTV2b2hKUGlNTElVUVZOOWVU?= =?utf-8?B?UkR4VldJUW5PdzVmUFJzeGNJczlDWEVORWRYdDFBU1cyVmNlVHVIa3c2ZVFW?= =?utf-8?B?OGlDb3ViU2hRMUxReTFJTFNvMTRBampRUnZQKzZHNnpvWGtGV2ZhT1I0WjFO?= =?utf-8?B?WUhmUkY3MzduRnNpdTlNcDBUVTgwVHY4aWNGQWdJMkhMZGVUcDgrOHlsenVl?= =?utf-8?B?d1Y2U3ErL1RUV2g0Q211aXpNYk1OazV2b0pOSzZGVUR5WTlyalhwclZMbkp0?= =?utf-8?B?b2lyTWtROUs5U2J4T1d1SHZJcnZuOFRFcWF1a3RDYVVWdys3YTQ1ZEVYaUVj?= =?utf-8?B?N2k1VW1vUk1lTlJvb1lkWlR4ZnBSOStnVk9Vc3hSVVVJbENJVkV5aGRyM2NE?= =?utf-8?B?YzcxcjkvUkZsNUtUeEgzWmE3STZDendsQTBnR3M3a1ZBWkRKSlM2cVY5czZi?= =?utf-8?B?TTRYdldIOVBZUmxCMzVneTV0M3dPMTFsWXdLaUorclRoSWRENFFsNVUreWUw?= =?utf-8?B?UE54amhoRmEwZUthcFVyOGRDTTNGRFVYMktwNHlzejJJN1M1Z0hPRFBNVVdI?= =?utf-8?B?SEFWLzUwa1BuRUNMelNrMGN2K0RkdmZwZ25yVHJWNkFENlhZSHZYWnk1TktO?= =?utf-8?Q?2YcQ5Gd3DnAUzAvjY99xJdIUKhK4GBxBJjJOVrp?= X-MS-Exchange-Transport-Forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 14308d9d-8461-4711-a3eb-08d9924fb047 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 15:55:21.0050 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j6BTfRrr5o3ERxqDvUBEjL9orev2uxrCF0NRm5vr1CcVMuGHiNt5QnZJSh3FFQLq+WvJ7dQWKzxFDGeiVfk70w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4839 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/enic: fix build with GCC 7.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/18/2021 12:16 PM, Ferruh Yigit wrote: > On 10/15/2021 12:16 PM, David Marchand wrote: >> On Fri, Oct 15, 2021 at 12:28 PM Ferruh Yigit wrote: >>> >>> Build error: >>> ../drivers/net/enic/enic_fm_flow.c: In function 'enic_fm_flow_parse': >>> ../drivers/net/enic/enic_fm_flow.c:1467:24: >>>          error: 'dev' may be used uninitialized in this function >>>          [-Werror=maybe-uninitialized] >>>      struct rte_eth_dev *dev; >>>                          ^~~ >>> ../drivers/net/enic/enic_fm_flow.c:1580:24: >>>          error: 'dev' may be used uninitialized in this function >>>          [-Werror=maybe-uninitialized] >>>      struct rte_eth_dev *dev; >>>                          ^~~ >>> ../drivers/net/enic/enic_fm_flow.c:1599:24: >>>          error: 'dev' may be used uninitialized in this function >>>          [-Werror=maybe-uninitialized] >>>      struct rte_eth_dev *dev; >>>                          ^~~ >>> >>> Build error looks like false positive, but to silence the compiler >>> initializing the pointer with NULL. >> >> enic_fm_check_transfer_dst() contains branches where dev is not set >> and those branches return rte_flow_error_set return value. >> dev is dereferenced later based on this return value == 0. >> >> So the compiler probably thinks that rte_flow_error_set may return 0. >> rte_flow_error_set is outside of compiler "view" at the moment it >> compiles enic_fm_flow.c, so the compiler making the assumption this >> function can return 0 is being prudent from my pov. >> >> >>> >>> Fixes: 7968917ccf64 ("net/enic: support meta flow actions to overrule destinations") >>> >>> Reported-by: David Marchand >>> Signed-off-by: Ferruh Yigit >> >> Your fix looks good in any case. >> >> Reviewed-by: David Marchand >> > > Applied to dpdk-next-net/main, thanks. > Bugzilla ID: 812 Updated in next-net.