From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BCC342C3E; Tue, 6 Jun 2023 11:43:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0828D40A84; Tue, 6 Jun 2023 11:43:24 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2042.outbound.protection.outlook.com [40.107.93.42]) by mails.dpdk.org (Postfix) with ESMTP id 6BC5040697 for ; Tue, 6 Jun 2023 11:43:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NTJE8fKj8n3Cd1zjYGxmgPmrb31nedU9RaWbAQcHnxwMbBmniw4jJj8Q22/NyJUjN2EyoaThaGtahdE1VZsKjOVuTq8XOxE3mbWaj6OZplbuW8AwBvdJ+dfkkIeJyM33L5oYShYxuysXwFasI/BEPDnf8BD+MXugZdBYsyU6xv553TGmCb0j9090/OmkkYQOuhl8RMCADgOMZbbNsgt1fjTXCSlm39TOtIhG6P+D3rcF+qllAc66RgK4dwN5yo9tSkIN/loqDAR2CedxNct/zx7OVDfAK+HZFZCpMKdkev9Ce9kaIwoPE5/J6yzg+YB5UmxE8Kdh7L8PQ/mBj6rOLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eeYrPHtxBLOk97GlafxNieABxK/8eOi1oaY+PUQUOn4=; b=bjGPFzkiCNQQPBlb6pYXnk2Hq0cjtTtnercjqzIP3uvVmcylJEM4twqWV2XY2l+BjavQUprOtecevWM+KBkP3HwUrRtMTmqwGocr2wdS3+yzOgTL4Re/bhuopceCejwBwjVIcTzi8GiaYapvxZfmr/bHROp9iNYgjruqcSjfiSOnfEnDHblGjQfFrX6MLtqa9Y7PQzsdQLQGhFaNqGVWtrx1/E0ntk+YrnaTr15QRI3FjVTa8p37nSQDw7WMtqDStzWTBsLrWTuqtfbenMHIMhPZ1bZYC1GBZZUhIN9KJbFp85LXm4FS8A8G2pqwyzunOWHJHE+oUP6hHgcjLIfMvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eeYrPHtxBLOk97GlafxNieABxK/8eOi1oaY+PUQUOn4=; b=IWF5ydT1jpGvzF+VITKMvTi+im1OmmsJjOyiqhgASuktHWlb1BEcdLKmhXgGAloYcPCCwUYEbCgYmh4sNE4hpAQa1huFXuPFrOesxd5WLtwMu23Q10RQSZk7nB7Dx6F58rqvUDKpu6hYuA3G2zulhHcdBBkxkvtuNn4b0wsrGRo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB8308.namprd12.prod.outlook.com (2603:10b6:610:131::8) by IA1PR12MB6260.namprd12.prod.outlook.com (2603:10b6:208:3e4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.23; Tue, 6 Jun 2023 09:43:20 +0000 Received: from CH3PR12MB8308.namprd12.prod.outlook.com ([fe80::e452:1914:1054:de79]) by CH3PR12MB8308.namprd12.prod.outlook.com ([fe80::e452:1914:1054:de79%7]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 09:43:20 +0000 Message-ID: Date: Tue, 6 Jun 2023 15:12:36 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v6 3/4] bus/cdx: add support for MSI Content-Language: en-US To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, hkalra@marvell.com, anatoly.burakov@intel.com, stephen@networkplumber.org, ferruh.yigit@amd.com, harpreet.anand@amd.com, nikhil.agarwal@amd.com References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230605132624.8626-1-nipun.gupta@amd.com> <20230605132624.8626-4-nipun.gupta@amd.com> From: Nipun Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PN3PR01CA0133.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:bf::15) To CH3PR12MB8308.namprd12.prod.outlook.com (2603:10b6:610:131::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB8308:EE_|IA1PR12MB6260:EE_ X-MS-Office365-Filtering-Correlation-Id: fec18c49-dca5-4dea-b80b-08db6672760d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xx/TlqWhIKEgVu6V0UCTCLfEDc0OA6XFwBFVYv8KuDjrIYB0JwreIGGYFR4oRt6nxY9RS+QoNZvs1wecYDz5IpzcoGHfSPn4xz4v5QCIoKrlAeMV4OOCKqVHVy29aBrZR5IYl5n4xv9/5pnzigHlxRVhSdVtjK3B6VnIR+zVmgCL4ijYiVXeDW1zLVwMitoEeQE3jGermpWNOxR6n1r5EVgrhOEUFn4Gq2MZlE5lhFrrDJLrLyutXcoxjeUbDQsVar53cSopzorTjRhKskaYW7CyF9MYxkVBxQM16HnHPAypqRhaj/gSxIgBqKrLCVym1Vmxl7G3f/OP1hktXTHo8Wgkp45iXIDc/EoxDsWdOzLoLnJCT88vUactqcZSpvm/M3Z8N47+6xRzCcvuyYaHkwnLQMaoUUruzopwVZQ3/XfgccBdwWRJCg8qvrhlHyoR9wCSUU1CvtczI3gnLZIsSB1knXWfqOMVEam+9toWI5rl34pw5/AuujGxLWiHCXVHNA2IQz74fkZqu4zxeAyslEAAApIVv/VeIJwB46T3vG3GFpVeRDbbAK8e5s3jlEihx9+TkAxEAJgNpy/ONhC+NEqwbs83Wcqqd1Wh78P5i9aYt0pQCzMp9QwWnwKML72pae4afi4rfzGzz+RVERqrXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8308.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(39860400002)(366004)(451199021)(2616005)(6486002)(478600001)(6666004)(36756003)(6512007)(186003)(53546011)(83380400001)(6506007)(26005)(31696002)(38100700002)(86362001)(4326008)(8676002)(41300700001)(316002)(66946007)(6916009)(66476007)(66556008)(44832011)(4744005)(31686004)(2906002)(8936002)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3g1YkYzekp4MzJoTWNoNGhZN2ZKY05wTXhITFJJVEZQU2ExQWI1NUNZUjkw?= =?utf-8?B?bEhFdGZmdDVnaUhtUXRtUEY4TWtqMzNpNUZWRnJyS0w5N1VHVzR0Nnh0TS8z?= =?utf-8?B?VDNxT3JnNmxzTWdmbllsM2RMOHowYTB1T1JkOXNoaUs0WEptd2JNODIvTkNv?= =?utf-8?B?aTQrRy9yN1c1bGlIcHhMNGZyMFBWQ0U4Z3Z2QVFibEFkSlZLU202emRuUnRO?= =?utf-8?B?V0Y3VkpnOVFUNDNTQXRqc1dFc3hkamVtd05YQkdmYlNmUGF3dVRTTFM1d3RY?= =?utf-8?B?Z2Y0b0haenZTWWgvVEc4R0JrVjJYY1kvbThRbTFuc1hDb01rcHBXQjRhZGZi?= =?utf-8?B?eVBoWGVuTjNOSW9BMVR3Qzh3dDlicmsvWHlNSDJRdm9OVmpOOGdSdXBPVlRD?= =?utf-8?B?NHFhazhSY1F6RXpFemt0LzQrK3Q1alJlTHVuQk0rWHRRaFNqR2NkQ0pDeXJH?= =?utf-8?B?SThsVjlJSmozNm9COTVEenJITGR4YjFreUkySG1sOWRBbEFjUG1FRGJXZVdj?= =?utf-8?B?cjhtcUNjTVdUc21NcC9YYWpYNnRrVUw5dmRObGlkRi9uQlJmUFBFNWhLcUgr?= =?utf-8?B?T3o1ZUZqMzdNUWVYVnYyNFNYUGtuRkU2eDlVMTAxRXpVMWQ5YUY3RnkzQWFw?= =?utf-8?B?b09oeDA5dmN3WTI4YmdyL1RPbyt6M1lqaTRsN3JkZjlsQU43MDh1UVFWVGhH?= =?utf-8?B?VlAySDZpZXZML2drZXdLMmE3bzU0QitJWUxjcEM5WEo5UGQ3QjF1V3o2bm9B?= =?utf-8?B?MWVBWHcrRlhsaXRDcXM1TTJIY21mdFdwaGpFQWpSWXJxdkp1dk9sL2g1S2Nv?= =?utf-8?B?bVpINTJVSUc2bHcvMW1MSEFWOUJ2UmNKdUMrNGk5eERaVE44UmJhaUVuSS9n?= =?utf-8?B?N1hCY0Q1T1h1bXdta1hYeU9CcHVsaWlUclBrRnNKNGF0cHpDT0s0aHlaOGxK?= =?utf-8?B?NkJHaXExZzk2K0tXWW9ra2tKZ3VqS2RsaFg2MmV4WFVpcjJiUVJ4Ny9xZ2Zr?= =?utf-8?B?VFhYVS9UMUc3WkhaNGtOT25BUWFud3V6LzVFTjFHOXBqOTZYNHlzcFdJc1N1?= =?utf-8?B?V1gzYXQzN1ExL2U3RGhDSnZpYlZ3dEhjSXZBMU1HSDhsZVhzaEVuOVlVL1Nv?= =?utf-8?B?UnpZK01pZ3dGdXJiOGtReWsrL20wa1NYS09Rc2VnWGF3bUxFcFhHcktLZEFQ?= =?utf-8?B?UEhLYk1oNWxWd2s5WU8vVTBzL3U5Vll5R0dlYUNaVmoyaEYraER2dnlMSlRV?= =?utf-8?B?WHVHamZwSGlNeFBqWEJvNkh3TmZ5K3ArdkpRTG1DRVJtQ2Z6YUtxcTlPZGFJ?= =?utf-8?B?RFdkNEh3eUdHZDZUTmdTbDlmWmxTbzIxOE9zbUkrYUtKZGcyUlZpTHRFUjhI?= =?utf-8?B?cU02L1Jhd1M4Z1NLNHgxZmJBbERVY2JvMENhMzd4OVpWbm00bVEzM2dqOGdn?= =?utf-8?B?TlpFSUZkbEhVV0RIN2t0Zmt0cjNndm5ta2R2anVCeEVFZENoV0h1RmgxT2Z6?= =?utf-8?B?NElvWkdQNndQeW8wZENLRmpLTHlBRHlUSkQ0bzZXejJUbFNCN1dYWFhqNUtY?= =?utf-8?B?alFVRUVzTkY2QXBLQnQrNGRUWFhQdWtVVk9KZE1hOVFHSlMzWHVKbTdwYTc5?= =?utf-8?B?QlZkZG1KZHA3VlZqZ2E4U3FzSXBtUnR2cmx6OHUvU29MbGZQMlhlSzRuQm82?= =?utf-8?B?VDhxOTZaWDk1V3k4YnA3MGx6SXJHL0l0M2hTOUlWQWZ6NThWMHNxTzRaSkpO?= =?utf-8?B?Lyt0NDhMWWRlbUloZU8yZ0w5MDBja2JleU8xMXZqWHBwZGNLMzM3SWZsZmly?= =?utf-8?B?VXF2UTJLbjVseVg0M3BwU0QvYndRNk1YN0d5TlgyQkpWVi9pL3dESTZJRlZh?= =?utf-8?B?bnJPVytlRmlKVW0yM2pZRjFzcHhEQldMTG0vVDFiWGFOSVJXcmVrY01hVlNQ?= =?utf-8?B?aktHZGMvUG9oenpGWllCSDZ3UXdBbjRxVHA4WERUcjFJQUJIRnFLUDhoVjlD?= =?utf-8?B?NU9HV1NQb2QxNGgrNGFzc0JtaXRCVERmSTJGZ01xWkJqYnVaUnhJVDMxQ2lh?= =?utf-8?B?NXgwMU55UXFtTnJwa3V5RDR0czIwa3NGS0IrSklEWjNYOHM1NXVycmd0dlRw?= =?utf-8?Q?FugkwlbxXMlr/8SLUwr/e3oqP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fec18c49-dca5-4dea-b80b-08db6672760d X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8308.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 09:43:19.9273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2x4ZtdteR8vovXgKN0Qy6FuP62VnP77X4QiMyvO6U7fykiMbB4/bLofYzLu/cv1W X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6260 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/6/2023 3:00 PM, David Marchand wrote: > > On Mon, Jun 5, 2023 at 3:27 PM Nipun Gupta wrote: >> +/* set up interrupt support (but not enable interrupts) */ >> static int >> -cdx_rte_vfio_setup_device(int vfio_dev_fd) >> +cdx_vfio_setup_interrupts(struct rte_cdx_device *dev, int vfio_dev_fd, > > I had dropped a bit too much of the hunk in my previous comment, but see below: > > [snip] > >> +static int >> +cdx_vfio_setup_device(struct rte_cdx_device *dev, int vfio_dev_fd, >> + int num_irqs) > > cdx_rte_vfio_setup_device() is renamed to cdx_vfio_setup_device(). > Such a rename is unneeded noise, cdx_vfio_setup_device() should be > used from the start, in patch1. > > If there is no further comment on the series, I can fix this when applying. Thanks for pointing. I missed this part. There are some minor changes requested by Thomas and I would send out a version today with this change you mentioned as well. Regards, Nipun > > > -- > David Marchand >