From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) by dpdk.org (Postfix) with ESMTP id 86B6B66DB for ; Thu, 12 May 2016 22:36:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1357; q=dns/txt; s=iport; t=1463085398; x=1464294998; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vpq+v9kOud95R3h+7qtjnvKbzR6vsQKz4Su53/ag9YI=; b=ILz5oUR3qNoM/HhmKl5HNbd0LN9y5hMO3N8Ief7/PBCRm73PJEd8ClP+ HRYeOqSmqO28P1OjnNUkdLMUNH6dBZLome78/oUa2LDehzj2WqanpNH8P QzIGrcHX5gQYsC2HTrjqlejb8JkHA2l+sFQW7gTopyUYkG1dIznZqgnNU Q=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AdAgD86DRX/5xdJa1egziBWblQAQ2Bd?= =?us-ascii?q?oYUAoE5OBQBAQEBAQEBZSeEQwEBBDo/EAIBCDYQMiUCBAENDYgnvWABAQEBAQE?= =?us-ascii?q?BAQEBAQEBAQEBAQEBAR2GJYRMihgFmCcBjhaPII9AAR4BAUKDa4ggfwEBAQ?= X-IronPort-AV: E=Sophos;i="5.24,610,1454976000"; d="scan'208";a="103739341" Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 May 2016 20:36:37 +0000 Received: from XCH-ALN-008.cisco.com (xch-aln-008.cisco.com [173.36.7.18]) by rcdn-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id u4CKabiV019696 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 12 May 2016 20:36:37 GMT Received: from xch-rcd-007.cisco.com (173.37.102.17) by XCH-ALN-008.cisco.com (173.36.7.18) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Thu, 12 May 2016 15:36:36 -0500 Received: from xch-rcd-007.cisco.com ([173.37.102.17]) by XCH-RCD-007.cisco.com ([173.37.102.17]) with mapi id 15.00.1104.009; Thu, 12 May 2016 15:36:36 -0500 From: "John Daley (johndale)" To: Olivier Matz , "dev@dpdk.org" CC: "konstantin.ananyev@intel.com" , "helin.zhang@intel.com" , "adrien.mazarguil@6wind.com" , "rahul.lakkireddy@chelsio.com" , "alejandro.lucero@netronome.com" , "sony.chacko@qlogic.com" Thread-Topic: [RFC] mbuf: new flag when vlan is stripped Thread-Index: AQHRqtiayQQUM9WiG0CJchJcA+uwHp+1wGqQ Date: Thu, 12 May 2016 20:36:36 +0000 Message-ID: References: <57222193.2040907@6wind.com> <1462897493-6567-1-git-send-email-olivier.matz@6wind.com> In-Reply-To: <1462897493-6567-1-git-send-email-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.24.107.103] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC] mbuf: new flag when vlan is stripped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 20:36:38 -0000 Hi Olivier, > ... > This is a draft patch that implements what was previously discussed, exce= pt > the packet_type, which does not exist for vlan today (and I think it is n= ot > mandatory for now, let's do it in another patch). >=20 > After doing this patch, it appeared that ixgbe was the only driver that h= ad a > different behavior for the PKT_RX_VLAN_PKT flag. An alternative to this > patch would be to only change the behavior of the ixgbe driver, and just > document better document the PKT_RX_VLAN_PKT flags in rte_mbuf.h > without adding new flags. I think this is a better option. >=20 > Comments are welcome. > There are applications depending on the current behavior of PKT_RX_VLAN_PKT= as confusing as it may be. I know of one that has VLAN stripping disabled= and uses the flag to determine if the packet delivered to the app has a VL= AN tag. This is actually how the flag behaves for ixgbe, and they patched e= nic and maybe other drivers to act accordingly. To avoid breaking the app (= and any others like it), I think we should keep the flag behavior the same = and add the new flag PKT_RX_VLAN_STRIPPED . We should follow on with the new packet type since it enables a nice perfor= mance improvement by not forcing apps to break open the packet just to see = if there is a VLAN tag. Thanks, john