DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Jakub Grajciar <jgrajcia@cisco.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] net/memif: multi-process support
Date: Thu, 13 Jun 2019 10:40:32 +0100	[thread overview]
Message-ID: <d1375502-9b73-8d47-2d6a-4f7fc73397f9@intel.com> (raw)
In-Reply-To: <20190613064248.4930-1-jgrajcia@cisco.com>

On 13-Jun-19 7:42 AM, Jakub Grajciar wrote:
> Multi-process support for memif PMD.
> Primary process handles connection establishment.
> Secondary process queries for memory regions.
> 
> Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
> ---

<snip>

> +/*
> + * Request regions
> + * Called by secondary process, when ports link status goes up.
> + */
> +static int
> +memif_mp_request_regions(struct rte_eth_dev *dev)
> +{
> +	int ret, i;
> +	struct timespec timeout = {.tv_sec = 5, .tv_nsec = 0};
> +	struct rte_mp_msg msg, *reply;
> +	struct rte_mp_reply replies;
> +	struct mp_region_msg *msg_param = (struct mp_region_msg *)msg.param;
> +	struct mp_region_msg *reply_param;
> +	struct memif_region *r;
> +	struct pmd_process_private *proc_private = dev->process_private;
> +
> +	MIF_LOG(DEBUG, "Requesting memory regions");
> +
> +	for (i = 0; i < ETH_MEMIF_MAX_REGION_NUM; i++) {
> +		/* Prepare the message */
> +		memset(&msg, 0, sizeof(msg));
> +		strlcpy(msg.name, MEMIF_MP_SEND_REGION, sizeof(msg.name));
> +		strlcpy(msg_param->port_name, dev->data->name,
> +			sizeof(msg_param->port_name));
> +		msg_param->idx = i;
> +		msg.len_param = sizeof(*msg_param);
> +
> +		/* Send message */
> +		ret = rte_mp_request_sync(&msg, &replies, &timeout);
> +		if (ret < 0 || replies.nb_received != 1) {
> +			MIF_LOG(ERR, "Failed to send mp msg: %d",
> +				rte_errno);
> +			return -1;
> +		}
> +
> +		reply = &replies.msgs[0];
> +		reply_param = (struct mp_region_msg *)reply->param;

Replies need to be freed after use, otherwise you're leaking memory. See 
rte_mp_request_sync API doc [1] and the PG [2].

[1] 
https://doc.dpdk.org/api/rte__eal_8h.html#abc35eb3d9139a0e7b9277a844dd2a61f

[2] 
https://doc.dpdk.org/guides/prog_guide/multi_proc_support.html#communication-between-multiple-processes

> +
> +		if (reply_param->size > 0) {
> +			r = rte_zmalloc("region", sizeof(struct memif_region), 0);
> +			if (r == NULL) {
> +				MIF_LOG(ERR, "Failed to alloc memif region.");
> +				return -ENOMEM;
> +			}
> +			r->region_size = reply_param->size;
> +			if (reply->num_fds < 1) {
> +				MIF_LOG(ERR, "Missing file descriptor.");
> +				return -1;
> +			}
> +			r->fd = reply->fds[0];
> +			r->addr = NULL;
> +
> +			proc_private->regions[reply_param->idx] = r;
> +			proc_private->regions_num++;
> +		}
> +	}
> +


-- 
Thanks,
Anatoly

  reply	other threads:[~2019-06-13  9:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13  6:42 Jakub Grajciar
2019-06-13  9:40 ` Burakov, Anatoly [this message]
2019-06-18  8:48 ` [dpdk-dev] [PATCH v2] " Jakub Grajciar
2019-06-18  9:20   ` Burakov, Anatoly
2019-06-25 10:05   ` [dpdk-dev] [PATCH v3] " Jakub Grajciar
2019-06-25 10:26     ` Burakov, Anatoly
2019-06-28 18:30       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1375502-9b73-8d47-2d6a-4f7fc73397f9@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=jgrajcia@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).