From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 06FC75F25 for ; Tue, 25 Sep 2018 17:32:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 08:32:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,302,1534834800"; d="scan'208";a="265595661" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.55]) ([10.237.220.55]) by fmsmga005.fm.intel.com with ESMTP; 25 Sep 2018 08:31:13 -0700 To: "Hunt, David" , dev@dpdk.org Cc: john.mcnamara@intel.com, stephen@networkplumber.org, lei.a.yao@intel.com, bruce.richardson@intel.com References: <20180912144930.50578-1-david.hunt@intel.com> <20180914135406.52190-1-david.hunt@intel.com> <20180914135406.52190-6-david.hunt@intel.com> <47b4dbc6-48ca-f41c-86cb-e6f5b168ebf9@intel.com> <046d9290-55f9-8433-cbbd-b975f353fa47@intel.com> <5c1ca576-95ff-e150-7c4e-47bf4bfc255b@intel.com> <030089c0-bd02-4550-fdc3-7534d45754ba@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Tue, 25 Sep 2018 16:31:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <030089c0-bd02-4550-fdc3-7534d45754ba@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 15:32:31 -0000 On 25-Sep-18 4:15 PM, Hunt, David wrote: >>>> What happens if someone sends a string with a "{" or "}" inside? >>>> >>> >>> If we get to the end of the buffer without a "}", it calls the >>> library to convert, will fail, and move on.  No damage done (I hope). >>> Also, a short un-terminated (by "}") string will also exit when no >>> characters read. >>> So any invalid JSON string that's send to Jansson will fail to parse, >>> and the application will be ready for the next (hopefully valid) JSON >>> string. >> >> No, what i meant is something like this: >> >> { "json_value": "{"} >> >> According to JSON validator, this is a valid JSON string, but it will >> break your code :) >> > > You are correct if this code was designed to be a general purpose JSON > string reader. However, it's only designed to take in strings for this > sample application, and they do not expect any brace characters embedded > within quotes. So I think it's OK for this use case. Patches welcome, > though! :) > Fair enough :) > Thanks, > Dave. > > > -- Thanks, Anatoly