From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EEFBA0093; Fri, 22 Apr 2022 17:30:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 236A7410D5; Fri, 22 Apr 2022 17:30:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3826340042 for ; Fri, 22 Apr 2022 17:30:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650641421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9qeV9CNtebTSDtzgZpAX4QA/97cZbBQwKRTPf5gEjYM=; b=GnqSeWgkb+iHPbRaCL8X+5sxYRRdvaP0nQ7wOnBtnB/xreHSvWwYm3k5b0oTDjmDY7xn6N FMM3jJh2BT4fn9JwVNuJje5lj6AIKPaTeW6yePJeWbHKIKDH3rfp/52K+biJFTP+si3QOL iPTCzbZuLEmmimhmLqDPREUDrT0rVoU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-270-lfA73fWsNaawvAoF0oHXKQ-1; Fri, 22 Apr 2022 11:30:16 -0400 X-MC-Unique: lfA73fWsNaawvAoF0oHXKQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 85FFA802819; Fri, 22 Apr 2022 15:30:15 +0000 (UTC) Received: from [10.39.208.18] (unknown [10.39.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9934814A4F8E; Fri, 22 Apr 2022 15:30:13 +0000 (UTC) Message-ID: Date: Fri, 22 Apr 2022 17:30:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 1/5] vhost: prepare sync for descriptor to mbuf refactoring To: xuan.ding@intel.com, chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, cheng1.jiang@intel.com, sunil.pai.g@intel.com, liangma@liangbit.com References: <20220407152546.38167-1-xuan.ding@intel.com> <20220419034323.92820-1-xuan.ding@intel.com> <20220419034323.92820-2-xuan.ding@intel.com> From: Maxime Coquelin In-Reply-To: <20220419034323.92820-2-xuan.ding@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Xuan, On 4/19/22 05:43, xuan.ding@intel.com wrote: > From: Xuan Ding > > This patch extracts the descriptors to buffers filling from > copy_desc_to_mbuf() into a dedicated function. Besides, enqueue > and dequeue path are refactored to use the same function > sync_fill_seg() for preparing batch elements, which simplifies > the code without performance degradation. > > Signed-off-by: Xuan Ding > --- > lib/vhost/virtio_net.c | 76 ++++++++++++++++++++---------------------- > 1 file changed, 37 insertions(+), 39 deletions(-) > Nice refactoring, thanks for donig it: Reviewed-by: Maxime Coquelin Thanks, Maxime