From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BD04433E5; Mon, 27 Nov 2023 14:37:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D06CB40273; Mon, 27 Nov 2023 14:37:22 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 24BAF4014F for ; Mon, 27 Nov 2023 14:37:22 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Sf6485sMLz1P8tR; Mon, 27 Nov 2023 21:33:44 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 27 Nov 2023 21:37:19 +0800 Message-ID: Date: Mon, 27 Nov 2023 21:37:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v3 0/6] doc/features: fix some features and add new features To: Ferruh Yigit , CC: , References: <20231123135916.33315-1-lihuisong@huawei.com> <20231125014745.61348-1-lihuisong@huawei.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/11/27 20:35, Ferruh Yigit 写道: > On 11/25/2023 1:47 AM, Huisong Li wrote: >> The support for setting RSS hash algorithm has been introduced to 23.11, >> but doesn't add feature for it. So this series add this feature and perfect >> RSS other features by the way. >> >> In addition, serval features, like "set link up/down", "TM", "dump device >> private information" and "loopback mode", had beed supported, but they are >> absent from the freatures list. >> >> --- >> -v3: >> - fix description of the patchset cover >> - remove '/features' in 'doc/features' tag for every patch. >> - add Acked-by: Chengwen Feng >> - retrigger CI build because of wrong CI warning >> >> -v2: >> - add loopback mode feature. >> >> Huisong Li (6): >> doc: add RSS hash algorithm feature >> doc: add link up/down feature >> doc: add features for link speeds >> doc: add Traffic Manager feature >> doc: add dump device private information feature >> doc: add feature for loopback mode >> >> > Hi Huisong, > > Some of the patches above adds new features to the 'features.rst', but > features.rst document describes features that drivers mark in feature > list in .ini file, all features are listed in the 'default.ini'. > > When a new feature is added into 'default.ini', it can be described in > 'features.rst' and later all driver .ini files should be updated to > reflect if they support this feature or not. correct. > > And I think no need to document all features, but ones can be important > enough or differentiating features for users to know, this line is not agree with you. > easy to draw, so perhaps we can use community consensus to select. > > In this patch following features are added: > - Link speed configuration > - Traffic manager > - Device private information dump > - Loopback configuration > > > I think 'Traffic manager' can be a new feature, but I am not sure about > rest. It would be nice to get more comments. Link speed is also important for NIC. Fixed speed and Link autoneg is from this. I think it can be a new feature. what do you think? How about add others to the following block? "Other dev ops not represented by a Feature" > .