From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mohammad.abdul.awal@intel.com>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 664581D312
 for <dev@dpdk.org>; Fri,  6 Apr 2018 18:58:42 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 06 Apr 2018 09:58:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,415,1517904000"; d="scan'208";a="214497981"
Received: from awalabdu-mobl.ger.corp.intel.com (HELO [163.33.228.156])
 ([163.33.228.156])
 by orsmga005.jf.intel.com with ESMTP; 06 Apr 2018 09:58:37 -0700
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Declan Doherty <declan.doherty@intel.com>, dev@dpdk.org,
 Alex Rosenbaum <alexr@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Shahaf Shuler <shahafs@mellanox.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Remy Horton <remy.horton@intel.com>, John McNamara
 <john.mcnamara@intel.com>, Rony Efraim <ronye@mellanox.com>,
 Jingjing Wu <jingjing.wu@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Yuanhan Liu <yliu@fridaylinux.org>,
 Bruce Richardson <bruce.richardson@intel.com>
References: <20180405135148.16388-1-declan.doherty@intel.com>
 <2392634.y0Dprd7BRi@xps> <90f813f1-6306-e6ed-26ea-4f0931bdebaf@intel.com>
 <1688530.7oQI8JUYAQ@xps>
From: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Message-ID: <d19e2be6-9887-7ccd-fd47-f9f512f8108f@intel.com>
Date: Fri, 6 Apr 2018 17:58:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <1688530.7oQI8JUYAQ@xps>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action
 items support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2018 16:58:42 -0000



On 06/04/2018 16:57, Thomas Monjalon wrote:
> 06/04/2018 15:47, Mohammad Abdul Awal:
>> On 05/04/2018 17:49, Thomas Monjalon wrote:
>>> 05/04/2018 15:51, Declan Doherty:
>>>> +struct rte_flow_item_metadata {
>>>> +       uint32_t id;            /**< field identifier */
>>>> +       uint32_t size;          /**< field size */
>>>> +       uint8_t bytes[];        /**< field value */
>>>> +};
>>> Spotted C99 syntax of flexible array.
>>> Are we OK with all supported compilers?
>>>
>> Used "uint8_t *bytes;" instead of "uint8_t bytes[];"
> Why this change? It is changing the size of the structure, isn't it?
It does change the size. I also agree with Adrien's comment as he 
mentioned in the previous mail.