From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88CA1A0350; Wed, 1 Jul 2020 09:23:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 054C41C1B7; Wed, 1 Jul 2020 09:23:46 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3FAE01C1A2 for ; Wed, 1 Jul 2020 09:23:43 +0200 (CEST) IronPort-SDR: NkLda9kPOZTzanchC47RqCPxHMOClsazRc1R8n+286qs2qOUEM1Wwv+tgJ9DxSJDMeyt48qpvy Jxz9BRz6aFeQ== X-IronPort-AV: E=McAfee;i="6000,8403,9668"; a="208001356" X-IronPort-AV: E=Sophos;i="5.75,299,1589266800"; d="scan'208";a="208001356" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 00:23:42 -0700 IronPort-SDR: 0HQmDhQ/MhFPnVxBGG9RJgUxq1f8hiOOsyKSiZ00ltCRE3JjK7X0zhlT+ok+AVyioeD4jj+N2g iT9VxBdvW4dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,299,1589266800"; d="scan'208";a="321671306" Received: from mbarakat-mobl.ger.corp.intel.com (HELO [10.213.239.32]) ([10.213.239.32]) by orsmga007.jf.intel.com with ESMTP; 01 Jul 2020 00:23:41 -0700 To: Hemant Agrawal , dev@dpdk.org Cc: Nipun Gupta References: <20200527132326.1382-1-hemant.agrawal@nxp.com> <20200527132326.1382-6-hemant.agrawal@nxp.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Wed, 1 Jul 2020 08:23:40 +0100 MIME-Version: 1.0 In-Reply-To: <20200527132326.1382-6-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 05/37] bus/fslmc: rework portal allocation to a per thread basis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/27/2020 2:22 PM, Hemant Agrawal wrote: > From: Nipun Gupta > > The patch reworks the portal allocation which was previously > being done on per lcore basis to a per thread basis. > Now user can also create its own threads and use DPAA2 portals > for packet I/O. > > Signed-off-by: Nipun Gupta <...> > @@ -229,7 +264,7 @@ dpaa2_configure_stashing(struct dpaa2_dpio_dev *dpio_dev, int lcoreid) > return 0; > } > > -static struct dpaa2_dpio_dev *dpaa2_get_qbman_swp(int lcoreid) > +static struct dpaa2_dpio_dev *dpaa2_get_qbman_swp(void) > { > struct dpaa2_dpio_dev *dpio_dev = NULL; > int ret; > @@ -245,108 +280,83 @@ static struct dpaa2_dpio_dev *dpaa2_get_qbman_swp(int lcoreid) > DPAA2_BUS_DEBUG("New Portal %p (%d) affined thread - %lu", > dpio_dev, dpio_dev->index, syscall(SYS_gettid)); > > - ret = dpaa2_configure_stashing(dpio_dev, lcoreid); > - if (ret) > + ret = dpaa2_configure_stashing(dpio_dev); > + if (ret) { > DPAA2_BUS_ERR("dpaa2_configure_stashing failed"); > + return NULL; > + } > + > + ret = pthread_setspecific(dpaa2_portal_key, (void *)dpio_dev); > + if (ret) { > + DPAA2_BUS_ERR("pthread_setspecific failed with ret: %d", ret); > + dpaa2_put_qbman_swp(dpio_dev); > + return NULL; > + } > > return dpio_dev; > } > > +static void dpaa2_put_qbman_swp(struct dpaa2_dpio_dev *dpio_dev) > +{ > +#ifdef RTE_LIBRTE_PMD_DPAA2_EVENTDEV > + dpaa2_dpio_intr_deinit(dpio_dev); > +#endif > + if (dpio_dev) > + rte_atomic16_clear(&dpio_dev->ref_count); > +} There is a build error on patch by patch build [1], just moving 'dpaa2_put_qbman_swp()' static function above the 'dpaa2_get_qbman_swp()' (where it is used) solves it, and indeed next patch does it. If you will make a new version can you please fix it, if there will be no new version I can do while merging. [1] .../drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:292:3: error: implicit declaration of function 'dpaa2_put_qbman_swp' is invalid in C99 [-Werror,-Wimplicit-function-declaration] dpaa2_put_qbman_swp(dpio_dev); ^ .../drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:292:3: note: did you mean 'dpaa2_get_qbman_swp'? .../drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:267:31: note: 'dpaa2_get_qbman_swp' declared here static struct dpaa2_dpio_dev *dpaa2_get_qbman_swp(void) ^ .../drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:299:13: error: static declaration of 'dpaa2_put_qbman_swp' follows non-static declaration static void dpaa2_put_qbman_swp(struct dpaa2_dpio_dev *dpio_dev) ^ .../drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:292:3: note: previous implicit declaration is here dpaa2_put_qbman_swp(dpio_dev); <...>