From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0F3BA0C41; Wed, 17 Nov 2021 12:26:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C377407FF; Wed, 17 Nov 2021 12:26:22 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 68BFE40040 for ; Wed, 17 Nov 2021 12:26:20 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10170"; a="213961023" X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="213961023" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2021 03:26:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="735777815" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 17 Nov 2021 03:26:19 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 03:26:18 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 03:26:18 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 17 Nov 2021 03:26:18 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 17 Nov 2021 03:26:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lfBEtHKFxBBWnEnQumpwLv2x1DnF53WjWaHNCJ/2UFSw4x84TU/IiCHNR0ZPLFY47kOtbrScev2Tx4FE62wvfkAHZOgH4OrcrVJH2vkrSlkND0Tw8d9oCJE0rygSDC3Aa2BXqaGQE3KF8gXZXIuN49v8jwkSFCSXeiWeQU8HyCrqizn2VLaD4siiPNtjvsPU2/UmaNF8CmmBlOys3yCNF2I2FJorUzM2RSspWjfaR6v+UBZKjQu1gd4v/39Bn5uJ14RYwB/U3vMCP6kjYJQK6ewn0pprDwuQ3FfLD50aDsRPgKOGa0aydzXw8KVZtjB7bCXgpeNUOAE/fGzDlvIHxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GW9SqXz6iW+tWWlFuiLW6tyztcMRdtWm9dRuRWLo6AY=; b=bzakcqJajX7qtgdxOzjONxOhPN8i9OAOy/hYtyRTpZ3I8Sf8HkcKNyWcHgaU4UKrS6YfrL2CRZicdT5s0ueTEwPOV2JvG1MsI5VcibgUiiGT5VPgydVBBcUdBPHHGX6uM0ui5UJBbDDxU2V9LEvog+bNzi1J0841sUCQxOJi/KsWgP+E4Dwc76BW+mdenYu+sX7DvuOm1qrGnDSIiCnJynQNGGVAf6uE2i2pa5zlhe9yhz1KC9BHi0ytlHtxjXYNm0QjZTX7YMXgB8wXN3zoJUe9+S3VNnICqY6dY2HsdRXIqKYZ7DH464IXAppYVm/2V5jQso81jkGrvdsTF/adYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GW9SqXz6iW+tWWlFuiLW6tyztcMRdtWm9dRuRWLo6AY=; b=YMwuYEtSlEv3lY/2uJIA/7j18gFYYfgaNPG7DLv5gC4ruTYR2A4qO/YJR3klvv/9Vc9Cr3rfjkwzkqxu9MRNP52qOkd/k032kTEdtJbBiGIYibt4G1pjzDieZgEJIn1P/Os3Dn7CDlzdXfO3E7x/v89Ty+Xib70v3QH25xgvKVU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4936.namprd11.prod.outlook.com (2603:10b6:510:42::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Wed, 17 Nov 2021 11:26:17 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.028; Wed, 17 Nov 2021 11:26:16 +0000 Message-ID: Date: Wed, 17 Nov 2021 11:26:11 +0000 Content-Language: en-US To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , Kumara Parameshwaran CC: References: <20211111100621.84769-1-kumaraparamesh92@gmail.com> <701ff4b4-5350-4e96-a4d4-3e178c71bce3@www.fastmail.com> From: Ferruh Yigit Subject: Re: [PATCH] failsafe: Bug fix for the secondary process RX-TX support X-User: ferruhy In-Reply-To: <701ff4b4-5350-4e96-a4d4-3e178c71bce3@www.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0032.eurprd04.prod.outlook.com (2603:10a6:10:234::7) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0032.eurprd04.prod.outlook.com (2603:10a6:10:234::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.20 via Frontend Transport; Wed, 17 Nov 2021 11:26:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aaab461b-61ba-4ff9-59b6-08d9a9bd1200 X-MS-TrafficTypeDiagnostic: PH0PR11MB4936: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n669hC24XZJ8NcNZJmG2ryOHffv9G7/aSzXFheGqcvm6sGFF1cNxRX4BdrxG3wSbsiCvMAJwBcC34UEtqn4PuCakXGYdd+WHHPJq3Dw970+iKIEBKyiUEUXatgfVATNvZCrrIgF/x+qajD+mizkHxng3Fyy3C6XaXc+MrZ3MeZhbXNbfOQpBkG2jGjVbr+WlQFt/Zj93GTfY+Lnvv3yhU+1juyd69dkENvOjYV0DVg+chJUMr7KVpsmzr/Zqvllwv6NygVUTmU+99b6fo5FvEQwYBItgjTUSrfTeTuZozmI8VGjE8mZkqsRh3in69m4mHmHklN5rggvggIhvV4FwuvPXJdC+ZtJX2zSEnlZApSYGioBWw7tZpuFw7Db+jCaBj9NhmANPsUMpGTnsn0puc2HPqhLyH6J8Xpzwp7NRgcKqCDFz/vKjcl+ZOyF0Ppl38r4i1u/k4uJoq2MhUcTv2PPn/UipX8Rl1w+3LOgRqtWCrrqmr7XvqygJAV4aVJbbqN9biKNAJJkR95wExuTEeTX6OmJWvSqimjDlQ7eKdidVWmUfaTqxLpISyM1/vTTJ7ozghh7AfCUDT7N0lqXlNyN/bwhBF3WDbNPc7RHppyHhk9Jf1yqj2ZuPxwePElYxLeTjUGTPfSWnu5kYpVQP9R9AFc9ZgHjKOhzygyd7XrP5QXKsq3xw25QIIdyx2+d+EMMCAkG3QL0w/zVIkiPLmA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(956004)(2616005)(31696002)(6486002)(38100700002)(82960400001)(44832011)(110136005)(508600001)(316002)(83380400001)(36756003)(5660300002)(86362001)(4326008)(66574015)(53546011)(66946007)(2906002)(66556008)(66476007)(26005)(186003)(8676002)(31686004)(8936002)(16576012)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVdBUlNLcTk0a2NjbkJPV2xFalZFcnBULyt5N1RzMVVtWCthZ1JuWU1SQXBM?= =?utf-8?B?Nmd6NmFXS1NHWDlIeEpYdFB4bzFKdTd6cmVUSGp2M3c2MC9uWFpZYnIxeVpU?= =?utf-8?B?Z2RVdTJkb3czQ3VDWDlEQXZNTWxDZU9seTdXMFhTSWgraWtjeWQxaWd4UTc4?= =?utf-8?B?R3RNYjhxTTRBMTdWdGxKZHYzNXhNZDM1RUpiNTVmNEsxRmVZVnhnaUF0NkJB?= =?utf-8?B?eUZhRzVrVUN1MzllWHZnQ0pNYUFkVlZMYmpscDN0WDF5aUJzOHlnOXZkZlJx?= =?utf-8?B?S0pVdi85dlZsSkdHTVZYODUwcVU1di9wSHJNRWpaS3FQMFdwV3p5U0IzdnNv?= =?utf-8?B?d2U5cXl6K3dIWC9JNCsyVEtsU0JhUFovYnpRc0J6M3JpczZPWjhRdnJEV2s1?= =?utf-8?B?ODFPUFdjcUgremNiMzEzMWl5MDNRb293RVpsN1Z6a2hFT0dKdFp0VDNvbHNy?= =?utf-8?B?azJWU09ldzlXSUJQWmRTYXM3Y2lCcm5lTlBHTkxwazlRM2tBWldOMDNiZXov?= =?utf-8?B?bjdQbTBSOER1emFnbkNpU3grVC9qVTJIWE9jWmQrYnFpS2JBODhsaWowM1R6?= =?utf-8?B?SmRNUWVxeGtuNUd6U3B2QVYwZFF1NVEvaG1yUlBYbjRMcVpJRWxBbVFhRE5l?= =?utf-8?B?SHdZNjIvTjg4OVl6eXVJdCtMMnJXZjdKWEtJRkxwMzRHRTlEKzFZV0JiNFUy?= =?utf-8?B?UzhUYU1tZUVQWlBwUUd5Vnl3Qy9oSGZ3N2UxQ0pBdW5PRy9FenZJWEJ0L1RF?= =?utf-8?B?R29nbFJ2aWFFblFobzdBeG8zZFl6U2tkMzJPWGt4K3pHVUw3Z2tYNkZyZVJ0?= =?utf-8?B?aFpjazhpcktwR01ldmFoTEZEbmh1NEIxQmtsU2dWUE1BdVRGZ05URkFVeGlr?= =?utf-8?B?SDFzUnlMejdoSi9MVFcrVnBJZE1MTVVQVlU3VGlHREZ1SDZCWXd0NHpBbHlx?= =?utf-8?B?NVJKOE9uQVF0a3VTR0NvWU1YM25zUFFOTmxNdUVlOVFob2ZZdjhRVElZRWNI?= =?utf-8?B?ZTAzRUMvc2J5anM4N0tjWndBYjRsT2dWejhVV1pLVEpzb2lOV0RzOEE0Qllx?= =?utf-8?B?UElEZitpRVQvNml4Z29mTHlBVnNKQk5FbkV4Z0xmMExpbmIvM3NudFdKNUFW?= =?utf-8?B?ZUF5akg3TklUbVljWkpnbmR6OGU3Qi9Pd2ZlZ2I5RU9VU24wTnlFYVAvc1Ux?= =?utf-8?B?Q3JXc3hnbGsrL21lTytvemtBUmNjVVJSNGhTYjFZRzRueHhzdWhmcTFTSk1Q?= =?utf-8?B?ck0vWTBmYzh4UjIrYlVkbzRKTlcrU2tuWnVyMlArV1BJazJ4Q2ZiUzVGRXVS?= =?utf-8?B?QitvdTI5SmlrK2hiS0lpNU8veDNaY2VHN1hkeTBMTEU2SVlTK2E0YmJRM2lz?= =?utf-8?B?N3E0Q29zeVdXRUkyN0dHSnB6MU40QWEvZzB1RW1sUnV3ZmpvVWtyc1JGN0Fy?= =?utf-8?B?dHQxbXFVb0xRTDZiaXlXUituZEZXeDBOVnBwOU9NcWhSempUYmxrS3pieHhh?= =?utf-8?B?S1R1WnJsTW82cTI5SngweVFkQnk4dTM4OE9jTjZyejlZcUxQdmdkRzQ5UEJq?= =?utf-8?B?SzFacnFGSTFSNlFkZE14Q0hRMXRJTjN5WW4wZS83OGhaaWhMZUpHV3dhTGJx?= =?utf-8?B?L0lWb2ZuRlUwYS82NXc1QTl1dFZCQ05vN05FOUNpSUQ5dmJwMkFNMGhJS0pY?= =?utf-8?B?ZVl4Z1VhK1c0MHI3UkpsZjFKRWxldnZxaWd2L09QZkpiTVphTmFCUUM2TDNS?= =?utf-8?B?cHplZTRPMS9FSVU5cituZ2U0N014RFNUczVWL1p4RUNYMjZjWHNEUzNWcEtM?= =?utf-8?B?TGE2eFV0d0hTOW1lNlBwZHhmR2FSMUVGOEthRUtpRUZYVi90M3k0UXUxQ1lQ?= =?utf-8?B?OGxBZ0tDa2xObzg4bHVtNFlLODJxQnVLR3MyK1I0aUJJeGIwWHpxS1ZIYzYz?= =?utf-8?B?SUwxLzgxd3VKdDN6RFlWbm9BbHZzSWpyb2dJQmcycm1BVE84c0dPR1E4ekVD?= =?utf-8?B?bUFPYU9WZk9zalMzZ2ZuVVhzWnBEQkZPbTlZVnNWcVFYVEVmc01sUVMvVEcz?= =?utf-8?B?Q2RIQmFWR2ZhMUdraCtXZmY0c1JaQjl5R0hQdU1TYzdCZ3NETFZJQUplWFBh?= =?utf-8?B?TnBCOG9OTzF1UUIyVCsyVFptMTlrVFVaOHJRdndJOFMyNjBPeVJkWUZXRUg1?= =?utf-8?Q?rBwaUktW9/So53ULt0sIFC4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: aaab461b-61ba-4ff9-59b6-08d9a9bd1200 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 11:26:16.8170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DQxcfAmAQqJVa2np6H8N36rmlFtJ+cFvpcqEkr1ZBCObaYoNiDx4lPHNCtlEKbRK8ODAlKAoVclW7l4EplonDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4936 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/11/2021 10:59 AM, Gaëtan Rivet wrote: > On Thu, Nov 11, 2021, at 11:06, Kumara Parameshwaran wrote: >> Remove the vdev args check for secondary process which prevents the >> secondary from attaching >> to the device created by the primary process via the hotplug framework. >> This check was removed >> for other vdevs but was missed for failsafe. >> >> Signed-off-by: Kumara Parameshwaran > > Hello Kumara, > > Thanks for your patch. > If this is a fix, can you provide the fixline with a pointer to the patch it is meant > to fix please? > > I'm guessing this should be this: > Fixes: 4852aa8f6e21 ("drivers/net: enable hotplug on secondary process") > Cc: qi.z.zhang@intel.com > > Looking at this patch, I see also > > + if (rte_eal_process_type() != RTE_PROC_PRIMARY) > + return rte_eth_dev_release_port_secondary(eth_dev); > + > > Added to the remove callbacks of the ports. > It seems to be omitted from this patch, is there a reason? > Hi Gaetan, Above addition is no more required since primary and secondary release functions merged into 'rte_eth_dev_release_port()' one which has process type check inside it. And failsafe remove path already calls 'rte_eth_dev_release_port()', so it should be OK. >> --- >> drivers/net/failsafe/failsafe.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c >> index ad6b43538e..3c754a5f66 100644 >> --- a/drivers/net/failsafe/failsafe.c >> +++ b/drivers/net/failsafe/failsafe.c >> @@ -340,8 +340,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) >> INFO("Initializing " FAILSAFE_DRIVER_NAME " for %s", >> name); >> >> - if (rte_eal_process_type() == RTE_PROC_SECONDARY && >> - strlen(rte_vdev_device_args(vdev)) == 0) { >> + if (rte_eal_process_type() == RTE_PROC_SECONDARY) { >> eth_dev = rte_eth_dev_attach_secondary(name); >> if (!eth_dev) { >> ERROR("Failed to probe %s", name); >> -- >> 2.30.1 (Apple Git-130) >