From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2D0CA0547; Thu, 29 Apr 2021 14:59:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5866410DD; Thu, 29 Apr 2021 14:59:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 5FAF9406FF for ; Thu, 29 Apr 2021 14:59:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619701182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BGWpsZ1hAsMrCGgyZOXzIoNbAKbYwWPs55iRHuQPCMw=; b=eWsyA+PyLIkZ4jDZvpgGx+KQPv9EgDI/oVaKBymbot531p4oO1n8TFy1XV2UVZZtuT4Q3L /EjzwBVGZeR+B5RurieOox8+GUMAX20Ejz1XbkWTiANm7YhaePpDXCnARecbCeSwKvq5q0 AFnYzdpGViqCWywMr7QpPd6JvXSe8jI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-tsrFiD6vO4KBsABv3Dm-Ug-1; Thu, 29 Apr 2021 08:59:40 -0400 X-MC-Unique: tsrFiD6vO4KBsABv3Dm-Ug-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79EABC742C; Thu, 29 Apr 2021 12:59:37 +0000 (UTC) Received: from [10.36.110.52] (unknown [10.36.110.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 635C16F44C; Thu, 29 Apr 2021 12:59:11 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: olivier.matz@6wind.com, fbl@sysclose.org, i.maximets@ovn.org, Ruifeng Wang , Chenbo Xia , Bruce Richardson , Konstantin Ananyev , Jerin Jacob References: <20210401095243.18211-1-david.marchand@redhat.com> <20210429080438.15032-1-david.marchand@redhat.com> <20210429080438.15032-4-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: Date: Thu, 29 Apr 2021 14:59:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210429080438.15032-4-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/virtio: refactor Tx offload helper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/29/21 10:04 AM, David Marchand wrote: > Purely cosmetic but it is rather odd to have an "offload" helper that > checks if it actually must do something. > We already have the same checks in most callers, so move this branch > in them. > > Signed-off-by: David Marchand > Reviewed-by: Flavio Leitner > Reviewed-by: Ruifeng Wang > --- > drivers/net/virtio/virtio_rxtx.c | 7 +- > drivers/net/virtio/virtio_rxtx_packed_avx.h | 2 +- > drivers/net/virtio/virtio_rxtx_packed_neon.h | 2 +- > drivers/net/virtio/virtqueue.h | 83 +++++++++----------- > 4 files changed, 44 insertions(+), 50 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime