DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Hunt, David" <david.hunt@intel.com>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_power: fix using variables before validity check
Date: Thu, 29 Apr 2021 08:43:24 +0800	[thread overview]
Message-ID: <d1dcb8b1-9fd2-a779-cf93-aeadae3d7c48@huawei.com> (raw)
In-Reply-To: <BYAPR11MB3366369256169932CF7C2095FF409@BYAPR11MB3366.namprd11.prod.outlook.com>



在 2021/4/28 23:13, Pattan, Reshma 写道:
> 
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Min Hu (Connor)
>>
>> +	if (lcore_id >= RTE_MAX_LCORE) {
>> +		RTE_LOG(ERR, GUEST_CHANNEL, "Channel(%u) is out of range
>> 0...%d\n",
>> +				lcore_id, RTE_MAX_LCORE-1);
>> +		return -1;
>> +	}
>> +
> 
> This looks good.
> 
>>   	fds.fd = global_fds[lcore_id];
>>   	fds.events = POLLIN;
>>
> <snip>
> 
>>   	if (global_fds[lcore_id] < 0) {
>>   		RTE_LOG(ERR, GUEST_CHANNEL, "Channel is not
>> connected\n");
> 
> 
> Another suggestion if you would like to improve the code, is below,
> You can move "global_fds[lcore_id]"  check to immediate after  the line  "fds.fd = global_fds[lcore_id]; "
Hi, thanks Pattan.
But I think "global_fds[lcore_id]"  check may move before the line 
"fds.fd = global_fds[lcore_id];
If it failed, "fds.fd = global_fds[lcore_id];" should not be performed.
What's your opinion?

> 
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> 
> .
> 

  reply	other threads:[~2021-04-29  0:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-25 12:59 Min Hu (Connor)
2021-04-28 15:13 ` Pattan, Reshma
2021-04-29  0:43   ` Min Hu (Connor) [this message]
2021-05-11 13:25     ` Thomas Monjalon
2021-05-11 13:34     ` Pattan, Reshma
2021-05-12  2:19 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-05-12  7:03   ` David Hunt
2021-05-12  7:14     ` Min Hu (Connor)
2021-05-12  7:41       ` David Hunt
2021-05-12 15:19     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1dcb8b1-9fd2-a779-cf93-aeadae3d7c48@huawei.com \
    --to=humin29@huawei.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).