From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D5C9FF11 for ; Wed, 5 Sep 2018 08:54:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2018 23:54:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,332,1531810800"; d="scan'208";a="83137887" Received: from nikhilr-mobl1.amr.corp.intel.com (HELO [10.106.138.18]) ([10.106.138.18]) by fmsmga002.fm.intel.com with ESMTP; 04 Sep 2018 23:54:19 -0700 To: Pavan Nikhilesh , jerin.jacob@caviumnetworks.com, anoob.joseph@caviumnetworks.com Cc: dev@dpdk.org, "Rao, Nikhil" References: <20180904141223.24216-1-pbhagavatula@caviumnetworks.com> <20180904141223.24216-3-pbhagavatula@caviumnetworks.com> From: "Rao, Nikhil" Message-ID: Date: Wed, 5 Sep 2018 12:24:18 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180904141223.24216-3-pbhagavatula@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2018 06:54:22 -0000 On 9/4/2018 7:42 PM, Pavan Nikhilesh wrote: > Convert existing Tx service based pipeline to Tx adapter based APIs and > simplify worker functions. > > Signed-off-by: Pavan Nikhilesh > --- > app/test-eventdev/test_pipeline_atq.c | 269 ++++++++++++----------- > app/test-eventdev/test_pipeline_common.c | 206 +++++------------ > app/test-eventdev/test_pipeline_common.h | 62 +++--- > app/test-eventdev/test_pipeline_queue.c | 241 ++++++++++---------- > 4 files changed, 367 insertions(+), 411 deletions(-) > > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c > index 832ab8b6e..ab407dbbb 100644 > --- a/app/test-eventdev/test_pipeline_common.c > +++ b/app/test-eventdev/test_pipeline_common.c > @@ -5,58 +5,6 @@ > > > @@ -215,7 +160,6 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) > { > uint16_t i; > uint8_t nb_queues = 1; > - uint8_t mt_state = 0; > struct test_pipeline *t = evt_test_priv(test); > struct rte_eth_rxconf rx_conf; > struct rte_eth_conf port_conf = { > @@ -238,13 +182,21 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) > return -ENODEV; > } > > + t->internal_port = 0; > RTE_ETH_FOREACH_DEV(i) { > struct rte_eth_dev_info dev_info; > struct rte_eth_conf local_port_conf = port_conf; > + uint32_t caps = 0; > + > + rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps); > + if ((caps & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)) { > + t->internal_port = 1; > + } else if (t->internal_port == 1) { > + evt_err("Eventdev can't use %d port", i); > + return -EINVAL; > + } > Shouldn't this function also return -EINVAL for the case where internal_port = 0 for i = 0, and internal_port = 1 for i = 1 ? Nikhil