From: Declan Doherty <declan.doherty@intel.com>
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bonding: fix link status interrupt when down
Date: Wed, 26 Jul 2017 18:08:04 +0100 [thread overview]
Message-ID: <d2295709-f487-a84c-f994-a02ced40ff01@intel.com> (raw)
In-Reply-To: <20170726155330.20512-1-tomaszx.kulasek@intel.com>
On 26/07/2017 4:53 PM, Tomasz Kulasek wrote:
> RTE_ETH_EVENT_INTR_LSC callbacks are not called when all slaves goes down
> in bond_ethdev_lsc_event_callback. It causes that link status change of
> bonded device is not propagated up.
>
> Fixes: deba8a2f8b0b ("net/bonding: fix link properties management")
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 8f9a860..3ee70ba 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -2535,6 +2535,9 @@ struct bwg_slave {
> /* Remove from active slave list */
> deactivate_slave(bonded_eth_dev, port_id);
>
> + if (internals->active_slave_count < 1)
> + lsc_flag = 1;
> +
> /* Update primary id, take first active slave from list or if none
> * available set to -1 */
> if (port_id == internals->current_primary_port) {
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2017-07-26 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 15:53 Tomasz Kulasek
2017-07-26 17:08 ` Declan Doherty [this message]
2017-07-31 12:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2295709-f487-a84c-f994-a02ced40ff01@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).