From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 790307D2A for ; Wed, 26 Jul 2017 19:08:07 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2017 10:08:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,416,1496127600"; d="scan'208";a="1155665526" Received: from dwdohert-mobl1.ger.corp.intel.com (HELO [163.33.228.138]) ([163.33.228.138]) by orsmga001.jf.intel.com with ESMTP; 26 Jul 2017 10:08:05 -0700 To: Tomasz Kulasek , dev@dpdk.org References: <20170726155330.20512-1-tomaszx.kulasek@intel.com> From: Declan Doherty Message-ID: Date: Wed, 26 Jul 2017 18:08:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170726155330.20512-1-tomaszx.kulasek@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] bonding: fix link status interrupt when down X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2017 17:08:07 -0000 On 26/07/2017 4:53 PM, Tomasz Kulasek wrote: > RTE_ETH_EVENT_INTR_LSC callbacks are not called when all slaves goes down > in bond_ethdev_lsc_event_callback. It causes that link status change of > bonded device is not propagated up. > > Fixes: deba8a2f8b0b ("net/bonding: fix link properties management") > > Signed-off-by: Tomasz Kulasek > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 8f9a860..3ee70ba 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -2535,6 +2535,9 @@ struct bwg_slave { > /* Remove from active slave list */ > deactivate_slave(bonded_eth_dev, port_id); > > + if (internals->active_slave_count < 1) > + lsc_flag = 1; > + > /* Update primary id, take first active slave from list or if none > * available set to -1 */ > if (port_id == internals->current_primary_port) { > Acked-by: Declan Doherty