From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.hunt@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 30E864C92
 for <dev@dpdk.org>; Wed, 12 Sep 2018 12:51:42 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 12 Sep 2018 03:51:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.53,364,1531810800"; d="scan'208";a="69394227"
Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.37])
 ([10.237.221.37])
 by fmsmga007.fm.intel.com with ESMTP; 12 Sep 2018 03:51:38 -0700
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, john.mcnamara@intel.com
References: <20180830105422.1198-1-david.hunt@intel.com>
 <20180830105422.1198-3-david.hunt@intel.com>
 <20180830095932.5cd1cb9d@xeon-e3>
From: "Hunt, David" <david.hunt@intel.com>
Message-ID: <d23bb17f-32a5-f723-56f8-b6b7c93e82a3@intel.com>
Date: Wed, 12 Sep 2018 11:51:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180830095932.5cd1cb9d@xeon-e3>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v1 2/7] lib/power: add changes for host
 commands/policies
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Sep 2018 10:51:42 -0000

Hi Stephen,

On 30/8/2018 5:59 PM, Stephen Hemminger wrote:
> On Thu, 30 Aug 2018 11:54:17 +0100
> David Hunt <david.hunt@intel.com> wrote:
>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>>   lib/librte_power/channel_commands.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h
>> index ee638eefa..a82724911 100644
>> --- a/lib/librte_power/channel_commands.h
>> +++ b/lib/librte_power/channel_commands.h
>> @@ -19,6 +19,7 @@ extern "C" {
>>   #define CPU_POWER               1
>>   #define CPU_POWER_CONNECT       2
>>   #define PKT_POLICY              3
>> +#define PKT_POLICY_REMOVE       4
>>   
>>   /* CPU Power Command Scaling */
>>   #define CPU_POWER_SCALE_UP      1
>> @@ -58,6 +59,8 @@ struct traffic {
>>   	uint32_t max_max_packet_thresh;
>>   };
>>   
>> +enum core_type { VIRTUAL = 0, PHYSICAL };
>> +
> Why this enum, looks like a boolean to me.

I'll change this to a 'bool' in the next version.

Thanks,
Dave.