From: Ferruh Yigit <ferruh.yigit@amd.com>
To: David Marchand <david.marchand@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH] testpmd: fix early exit from signal
Date: Fri, 27 Oct 2023 13:30:11 +0100 [thread overview]
Message-ID: <d24c00f0-9620-42c1-b3aa-162ff585572e@amd.com> (raw)
In-Reply-To: <CAJFAV8z_LZUdqauHybLOVWmSykckXPF_LmbUU1jJhOhmaPffyQ@mail.gmail.com>
On 10/27/2023 8:30 AM, David Marchand wrote:
> On Thu, Oct 26, 2023 at 7:11 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
>>
>> Other signals may occur causing read to get interrupted.
>> Loop until quit flag is set by signal, a character is entered,
>> or end of file. This fixes bug where testpmd would exit early
>> because of signal used by TAP device.
>>
>> Bugzilla ID: 1305
>> Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal")
>
> We need this fix in LTS.
> Cc: stable@dpdk.org
>
>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>
<...>
>
> Just a nit here.
> Indent seems odd, I see an extra whitespace.
>
Empty line and indentation updated while merging.
> Otherwise the fix lgtm and resolves the issue reported in bz.
> Reviewed-by: David Marchand <david.marchand@redhat.com>
>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2023-10-27 12:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 17:11 Stephen Hemminger
2023-10-27 0:18 ` Ferruh Yigit
2023-10-27 7:30 ` David Marchand
2023-10-27 12:30 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d24c00f0-9620-42c1-b3aa-162ff585572e@amd.com \
--to=ferruh.yigit@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).