From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E25E943215; Fri, 27 Oct 2023 14:30:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 652FD402E4; Fri, 27 Oct 2023 14:30:20 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2077.outbound.protection.outlook.com [40.107.237.77]) by mails.dpdk.org (Postfix) with ESMTP id CB22F402DF for ; Fri, 27 Oct 2023 14:30:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kifhxHN1PlAc8VHrkkJNmIMkJE70iqh1Bve+xMQd/78hS3syH3i+7ACdqfzOrKz+T5EUHGbwbtLg0vV/idkby6mAnkepat9PuL/Z9j5xcVXfnSymxhR+Xpx/EtzD9HySQ2pr9L+fF9rIkMSkSObSMWtV4hJQ784WlySRxcmLD+4bFCliFG+4sXGgfDP6ylUn94ZhmvVFyhJagtPYzdoqhHpGLqy9kn7hESSBNGa68wPkHBdWCZZroCWz5hNuXhVNRQzKkSILEKsrODZbYJV5/L8PkpmbGud+BAqVP3axBDTxgMkBBSqyKqHQEf0TGzXLWGYxiBmz9f9azW1VeFgJzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jJOu+8GKcG8KWWjozr+478w2k2Gn9MxZRU24zwoqtNI=; b=DOhEqXdpTxOdaJuUvp/lEoJe/okzq7Tg4hzO73VTM0FgxFG32nHMcUR6akqeOLfqSpXVTAhXmfsWfFEFReoD/wrNClzKmHqF7DPnAGkwUI2Qh4t5wjdjzD75mL+X6RjAA/RNWV5vaM3Omqee5Sqsrq9O3m7e/DmFJNxsfqJ859zpQVu/BDZP8ordjApjc9Y1JTSJf55ZdLl8AF6ZTipyU9oXy2Y/EyBxKZ0cy00cWsktWpJ9Q2/lA1RigpYi1ZcomT2hNANxdHBYmG2gFJUHcwV5f2Yd54vT8FLfIDWwZuwD/tbLsMRgogGWrFA+YruV47iLM+Cy4y7W7wILOP8Bpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jJOu+8GKcG8KWWjozr+478w2k2Gn9MxZRU24zwoqtNI=; b=nCUyF2ouiibWmVDFzbMJYSoAB79hYwYAgc0N8XZkzWtS8L39z0ONOadMg1L7DThIuGku5azrOYniZnDEE6CBC6Rr/H2fUcethKXYUKx09IBERi4aCEOExGSxPrjEwbivayM+8DnbVABSux8E/s/2jmOpEZCZawy9I3sYgNHlHJo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB8461.namprd12.prod.outlook.com (2603:10b6:610:183::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Fri, 27 Oct 2023 12:30:16 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6933.019; Fri, 27 Oct 2023 12:30:15 +0000 Message-ID: Date: Fri, 27 Oct 2023 13:30:11 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] testpmd: fix early exit from signal Content-Language: en-US To: David Marchand , Stephen Hemminger Cc: dev@dpdk.org References: <20231026171133.250715-1-stephen@networkplumber.org> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0100.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB8461:EE_ X-MS-Office365-Filtering-Correlation-Id: b1c279aa-3f8a-4191-c59b-08dbd6e878f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g13ufCLSMZGfIDgpZ9Pt2ORT9OTSvTHMX9nStoUVOy326bhwvx/hKO/ZpYnwh7Kfe/RGDCyFm3voRdbpDiBigtna8vKcSz6RAOnuYW1WL7xJPYZ1+K430x3Ip26wM1pH0hTSyBZz2V0ukPOgxaZCJ6mmU1CJQeKzD5azoqPVTkU+iinwk12PWd6eQg8mT03dIk2lA+kkW1/SRJMkcn1Ob/Gs8EEIHUllAgf4V5hm+2wCqrOKlgJ9KVvvhwFsKWzDofGc+WZGfxMyKuSyjGf6zL7fORaX/qB3oSTFOqnnSbNVhiRdGO34CXvPyNnW9q71lAviaMEJZmAQYOvgoCSR0N03EF0Ckbc5KzKsrnXNCCVBtFE17QLIKmOgPaIdTFUwheSFxfMl0nSFLH893bYxsMWIbd5giafk7S/5hPnfxsq0PP7ddO+5thcdYCMueu1fld7hHFbo5VueqxcMAlr2p9Wk40YRTZlX0v7l2SwVk13nIUwCdW9t4bI6EbK495/s1OsD+qmRbSzudG2yVjz8MQWdaUgwSch+hpMjg+r0zTMnvVylGsZX473qiTWbeHgAOH1I07isf75NRwdGbG09Pbi565qMBcvfDmD1igT6+unYtG7OXgnGqOr6u3vKeaesZG0NCP2KmBs1jiiH6gkUCw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(346002)(136003)(39860400002)(396003)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(6512007)(2616005)(41300700001)(44832011)(5660300002)(8676002)(6486002)(26005)(8936002)(4326008)(6506007)(110136005)(66556008)(66946007)(66476007)(316002)(36756003)(478600001)(6666004)(53546011)(86362001)(31686004)(38100700002)(2906002)(4744005)(31696002)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjB0Y24wbWhqdEo4ajBoRHN6RDN0eEs4NDhtRk8wUHM3Q1hGRWZJWlNFNlUr?= =?utf-8?B?RXhWWk9iMUN3R3MrTmpjck5JQUpGUXdybldWSTZIZW5pUjZuS1lrazNleTNF?= =?utf-8?B?aXpyUnRyVGZPWXNOSy9vOU9hMkxyQSt5Z0tUVXQvTjhpWlJsbFNTMTV2NDRa?= =?utf-8?B?blkwekNIenZkdkMrcGx2ZFRiWFd1VmpXL2NOTXVKOXFiQTdJNnIvNHc5QVVF?= =?utf-8?B?VGM5ckZrSHpXUzBMRWp1Sy9HWEtvNlFaNHZSMHVuUkY5MERXamowTWNwbXBC?= =?utf-8?B?UWhmWXdESzlRa1Y1SHhJWW1TTVZEL0tkM2VjRk5UVVZ4YWswR09FVUdPOWRZ?= =?utf-8?B?Y2JqbERxK1dpZGxrZ0ZQNndMTGxielFXOGMwTXFkbXNCd3lzbHdjdjJudVFG?= =?utf-8?B?Uk1nNmZwWTJJUFpEZVNiR2pzMHg0Y3hHdmRCUGlCcGNoejh3Y0xONWpmVTNa?= =?utf-8?B?YzJwWVdvZXlxZ3J3SDFJN0MreHE0enlQcURsemt1UUd5aDFQVmYwSmRwcE1H?= =?utf-8?B?M0ZPTE9sTFhOVWFNcU5BbU51NDQ1RmFmRFN4eEVHR015dzlVMVh0QUpKQ1NT?= =?utf-8?B?RVlVY0dnY05hUG52RkI5WVNLcXRjZ2JWU1Z2OERCbFlXU3A1blZoWjN1bW5h?= =?utf-8?B?SUZUcjYwWVVaWTRoVytxSWtWL3VQakM1Mjk5K1ZTdlM0UVhHbnRRWkxmaW1U?= =?utf-8?B?TFB4ZW1aL2l1MlpmQzNrRVJscTQ2SC80VWFscXNlWEl1THM0VVJYejMvK3RY?= =?utf-8?B?SU9aU1hmOU0rZXlRa1JsZkVzV2Y0WmlSTEx6VC9zbGVQNFN6eTZiMTBoT2tY?= =?utf-8?B?aXZSUU5lMGZvckxSZlNleXI1azBCb0Z2a0JvejlkM1dxQWVPdkg2ajk2ZkVq?= =?utf-8?B?VHNubkVoRWo3MmNwdk1qYUxlZ2hpWldDRURKSlpCVzdJVW1JUDJCTEVzSXUy?= =?utf-8?B?MFJxU3dGTkw5aXRoNFU0T3dUTjdEdUFkT3cwa1dJMXJKZ3IwOUJaUVVqUm94?= =?utf-8?B?ZVFXbHZ5LzY5U3g0KytRTGNvM05MeHBBcEQ1ZFUyYi9OQXpIUTdVUHJFdHVN?= =?utf-8?B?bitRa2NaMGFOSjQ4b3hsQVRUdXBxQVZEMUpaSXhRTWhWSzBxa2xqbXpQVkhl?= =?utf-8?B?bU83ci9IZ0hWZXRwV2g5L3BqTzcxdkNrZzM0ZkJEYnRDc2liZkVtbWhLYW5n?= =?utf-8?B?K0UweXJRa2w1dmNxOEt4eGxXalJxeS8rMUtyam01WFdKb1dSejdieC9USEd5?= =?utf-8?B?dDFBN0RlRjJHYnJ0dE1YUTJiTVhoTmp1bFBLZGVvaHdhWEEvREtRNG10WE1o?= =?utf-8?B?SWcrTmZVZnN0ZmQrTzh5cHJreVFaSFF3aWk5b2RLenpiMWpINkhmd3ZhSUo5?= =?utf-8?B?ckVEak45ZXNGZlhKK0w4djN2WEZDSlYwZk9CblNWOEM5QUpsSjg5SWFjYlRk?= =?utf-8?B?aEF1N2xnak1kYW9jUkk3bUNUMWMvZEVDejZpd2I5VUpxckxsMXpHR3dsK1ZC?= =?utf-8?B?aGhiam50OUZmV1o4VnRNUnFOV3BLVHRhR1BuTWllQzU2dWVZdUtodEJwUUw3?= =?utf-8?B?K1laN3hrMkw2amRZeXJsc1dIMXg2aVNId0lTZ1lFZmNMVXRaQ0cvRCtxZElR?= =?utf-8?B?cXBtZU9YNENBYjFROFB2Z3lqd2gwZ2JEaGFic2ZwSDNmN3pwK2EzdTdnOUF2?= =?utf-8?B?dTJ0SkpZbVd5UkpNcGRaWXNkb0tVWFZQZ05UQ3BYUHRpejAyTmIxUkNqTjE4?= =?utf-8?B?T0JMRTFGbVNkSDJSbzc1ZmN2aWN6ZXh3NTYvR2h2Yk9jVGRObE9DM2ZTZm04?= =?utf-8?B?bGJCWjVQSXJjaGR6Q2JXckl6ZkUzWkl6bktXVlc5QU9mZFVKVUFvdE9FWU5N?= =?utf-8?B?b0RPUHk3YjJpQy85VGhQbzNEc2R3Nkx2djBhRlE2RzhoOXFlRXZDcHJaS0Zy?= =?utf-8?B?TVpRSXRhUjZ2eUhVZ2ZJVEdTMW1Ua3E1UWNqaE5naTBRWHJueG5rM1ZDckxX?= =?utf-8?B?ckpnNloxK2xVTGk4akxtN1BWRkF6UmtGVUFqSmFlZUV1VzdkWTZsVVllRC9S?= =?utf-8?B?ZlVyb1FLTFBUdG1wclNvRVhXRUtoUjd4SUZLMDJIbnUxc0lya2VjSkY1WVR2?= =?utf-8?Q?yl4DSskruZD3pTagzImk6fZDT?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1c279aa-3f8a-4191-c59b-08dbd6e878f9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 12:30:15.6363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /3LE9mN1wINFlPjRUdCr51TWJ3Ej1USoJKEFDIQeBkKI6/+c756sk2OztUwXA52Z X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB8461 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/27/2023 8:30 AM, David Marchand wrote: > On Thu, Oct 26, 2023 at 7:11 PM Stephen Hemminger > wrote: >> >> Other signals may occur causing read to get interrupted. >> Loop until quit flag is set by signal, a character is entered, >> or end of file. This fixes bug where testpmd would exit early >> because of signal used by TAP device. >> >> Bugzilla ID: 1305 >> Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal") > > We need this fix in LTS. > Cc: stable@dpdk.org > > >> Signed-off-by: Stephen Hemminger >> <...> > > Just a nit here. > Indent seems odd, I see an extra whitespace. > Empty line and indentation updated while merging. > Otherwise the fix lgtm and resolves the issue reported in bz. > Reviewed-by: David Marchand > > Applied to dpdk-next-net/main, thanks.