From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAE19A0547; Mon, 21 Jun 2021 10:31:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F65D41184; Mon, 21 Jun 2021 10:31:00 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 3E72B41158; Mon, 21 Jun 2021 10:30:59 +0200 (CEST) IronPort-SDR: ov5jgAYZSCB2nFBgd+6ZC0Gq8hy7w3lMLga7QdCgsa9DBhQgXuLE690EmD/OPQcFeEPQLeYIp9 sjOXyoxOqhEA== X-IronPort-AV: E=McAfee;i="6200,9189,10021"; a="203781333" X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="203781333" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2021 01:30:57 -0700 IronPort-SDR: KN9SBp/3eQIT0O77+UhHaYnrBiywhxEUF+xE/GJ1dRhvgzioc+1m76I7YjSfV8k4lu1pO2VpqV zWNeF6sE/nsA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="422865387" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 21 Jun 2021 01:30:57 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 01:30:56 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 16:30:55 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.008; Mon, 21 Jun 2021 16:30:55 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Yang, SteveX" , "dev@dpdk.org" CC: "Yang, SteveX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invalid Thread-Index: AQHXZnRbtotUJcltSE2DM7I8dZZD0qsdmTKAgACJE0A= Date: Mon, 21 Jun 2021 08:30:54 +0000 Message-ID: References: <20210611065457.988344-1-stevex.yang@intel.com> <20210621080342.184889-1-stevex.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invalid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Xing, Beilei > Sent: Monday, June 21, 2021 4:19 PM > To: Yang, SteveX ; dev@dpdk.org > Cc: Yang, SteveX ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function in= valid >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Steve Yang > > Sent: Monday, June 21, 2021 4:04 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Yang, SteveX > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function > > invalid > > > > i40e can support following rss hash function types: default/toeplitz, > > symmetric toeplitz, and simple_xor. However, when filter engine parses > > pattern action, it only supports symmetric toeplitz & default. > > > > Add simple_xor and toeplitz hash functions support when parsing > > pattern action. > > > > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") > > Cc: stable@dpdk.org > > > > Signed-off-by: Steve Yang > > --- > > v3: > > - add Cc stable line. > > v2: > > - add the fix line. > > - support simple_xor and toeplitz hash functions explicitly. > > > > drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------ > > 1 file changed, 14 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_hash.c > > b/drivers/net/i40e/i40e_hash.c index b1cb24f437..0cef21c88f 100644 > > --- a/drivers/net/i40e/i40e_hash.c > > +++ b/drivers/net/i40e/i40e_hash.c > > @@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct > > rte_eth_dev *dev, > > NULL, > > "RSS Queues not supported when pattern > specified"); > > > > - if (rss_act->func =3D=3D > > RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) > > + switch (rss_act->func) { > > + case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ: > > rss_conf->symmetric_enable =3D true; > > - else if (rss_act->func !=3D RTE_ETH_HASH_FUNCTION_DEFAULT) > > - return rte_flow_error_set(error, -EINVAL, > > - > > RTE_FLOW_ERROR_TYPE_ACTION_CONF, > > - NULL, > > - "Only symmetric TOEPLITZ > > supported when pattern specified"); > > + break; > > + case RTE_ETH_HASH_FUNCTION_DEFAULT: > > + case RTE_ETH_HASH_FUNCTION_TOEPLITZ: > > + case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR: > > + break; > > + default: > > + return rte_flow_error_set(error, EINVAL, > > + RTE_FLOW_ERROR_TYPE_ACTION_CONF, > > + NULL, > > + "RSS hash function not supported " > > + "when pattern specified"); > > + } > > > > if (!i40e_hash_validate_rss_types(rss_act->types)) > > return rte_flow_error_set(error, EINVAL, > > -- > > 2.27.0 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi