From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2F7EA04AE; Mon, 4 May 2020 21:27:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0BBF1D52E; Mon, 4 May 2020 21:27:04 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id B75E01D51F for ; Mon, 4 May 2020 21:27:03 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200504192702euoutp015f1276f5869e25674d69135de2fc2f27~L6duSgtaR2721827218euoutp01Q for ; Mon, 4 May 2020 19:27:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200504192702euoutp015f1276f5869e25674d69135de2fc2f27~L6duSgtaR2721827218euoutp01Q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1588620422; bh=rSZxlD9Bs0yGXJj/O7W0N1Q4JCDENgzxjPy83yB0SrI=; h=Subject:To:From:Date:In-Reply-To:References:From; b=lHBOQQrnmSbvYHEJXlTY9c/LSbtzYGZQGzxzqVgP67b40EOehp3i17S3ILs8KU7TN BhoyRGFxQIorrtKLuH1UWn7aPvDcrIQN+FwyKG/iZL71RG0m2yPJZY7JfOUD/VClqi iGGZNFdaqlZJ9zVe55TU1/oK8s2gU7Y7UTLoFQK4= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200504192702eucas1p2e7c67bb6e9229aaeb12b972d0ff97706~L6dt1rmZt0524405244eucas1p2U; Mon, 4 May 2020 19:27:02 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 55.E3.60679.68C60BE5; Mon, 4 May 2020 20:27:02 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200504192701eucas1p15c98665f791f1c6ebbbf2672ab352fa2~L6dteiKKw0587805878eucas1p10; Mon, 4 May 2020 19:27:01 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200504192701eusmtrp27c8824c2d1f32c316fb055a08e3dcc63~L6dteCLcT1464114641eusmtrp2S; Mon, 4 May 2020 19:27:01 +0000 (GMT) X-AuditID: cbfec7f4-0e5ff7000001ed07-98-5eb06c862ff4 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 86.F5.07950.58C60BE5; Mon, 4 May 2020 20:27:01 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200504192701eusmtip2401db21184cc7b760c1b1b3d9f6a1c79~L6ds73G0A1779917799eusmtip2N; Mon, 4 May 2020 19:27:01 +0000 (GMT) To: Bruce Richardson , dev@dpdk.org From: Lukasz Wojciechowski Message-ID: Date: Mon, 4 May 2020 21:26:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200501150549.6959-1-bruce.richardson@intel.com> Content-Transfer-Encoding: 8bit Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42LZduznOd22nA1xBjMO8lvcWGVv8e7TdiYH Jo9fC5ayeize85IpgCmKyyYlNSezLLVI3y6BK2PLw+lsBTNEK/6dWszSwDhNsIuRk0NCwERi U+t/xi5GLg4hgRWMEisvnmSCcL4wSkzd1MwO4XxmlDh65BkLTMvLF/tYIRLLGSVaPiyA6n/L KLH0+R9mkCphgWiJNc1NbCC2iIC9xPXdx9hBbDYBW4kjM7+ygti8Am4Syw+dYwSxWQRUJF4t /w+0gYNDVCBWYvq1EIgSQYmTM5+AhTmBxlzYxwsSZhaQl2jeOpsZwhaRuPGoBewECYHXbBI7 j6xjhTjURWLjyvfsELawxKvjW6BsGYn/O+czQTRsY5S4+vsnVPd+RonrvSugqqwlDv/7zQay mVlAU2L9Ln2IsKPEoR/32UHCEgJ8EjfeCkIcwScxadt0Zogwr0RHmxBEtZ7E056pjDBr/6yF eEVCwEOirStuAqPiLCRPzkLy2Swkn81COGEBI8sqRvHU0uLc9NRio7zUcr3ixNzi0rx0veT8 3E2MwIRx+t/xLzsYd/1JOsQowMGoxMMb8Xl9nBBrYllxZe4hRgkOZiURXkWzDXFCvCmJlVWp RfnxRaU5qcWHGKU5WJTEeY0XvYwVEkhPLEnNTk0tSC2CyTJxcEo1MFbdY/953JyBKUTwxt6I fpHD85JaFr2Z+n/psbbYuHcxLt45Z6SFP7V9OrMoyivC3Y+9VXqveHTEn9XbP314m/JyquS7 jTMFc9s4GWMNf9/f0WjltuB8SkPRj88BbLraNvmBOTun6NT4d87/HrHeeoaK8YzkFSZfBQ4c 89wb+XPHUvfYo9vi9yqxFGckGmoxFxUnAgAy4dQBFAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42I5/e/4Pd3WnA1xBicemVrcWGVv8e7TdiYH Jo9fC5ayeize85IpgClKz6Yov7QkVSEjv7jEVina0MJIz9DSQs/IxFLP0Ng81srIVEnfziYl NSezLLVI3y5BL2PLw+lsBTNEK/6dWszSwDhNsIuRk0NCwETi5Yt9rF2MXBxCAksZJZ48/8DW xcgBlJCR+HBJAKJGWOLPtS42iJrXjBI7v1xmBUkIC0RLrGluYgOxRQTsJa7vPsYOUTSJUWLd jJXsIAk2AVuJIzO/gjXwCrhJLD90jhHEZhFQkXi1/D8LyDJRgViJlouaECWCEidnPgELcwLN vLCPFyTMLGAmMW/zQ2YIW16ieetsKFtE4sajFsYJjIKzkHTPQtIyC0nLLCQtCxhZVjGKpJYW 56bnFhvpFSfmFpfmpesl5+duYgRGwrZjP7fsYOx6F3yIUYCDUYmHd8PX9XFCrIllxZW5hxgl OJiVRHgVzTbECfGmJFZWpRblxxeV5qQWH2I0BXptIrOUaHI+MErzSuINTQ3NLSwNzY3Njc0s lMR5OwQOxggJpCeWpGanphakFsH0MXFwSjUwtoiny57+PenXsbgPHlK39Q69jdZ3fKFlZxmx f8/u7LXZ4ZfK1uRlFfPxqtk5sidMDQuoav11uHHKJSGm7xW/kk9M49p3eeO90/YPJm15r846 +9tLPpbdjGUzVh2u0/Ox6mgwks5puZewRX7b47X8PNu1Js8LtPWQm3JbJFOrVO+GIjfH/vON SizFGYmGWsxFxYkAhT3tapoCAAA= X-CMS-MailID: 20200504192701eucas1p15c98665f791f1c6ebbbf2672ab352fa2 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200501151113eucas1p11fc2a00e07522e5a29e1918532a1bee8 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200501151113eucas1p11fc2a00e07522e5a29e1918532a1bee8 References: <20200501150549.6959-1-bruce.richardson@intel.com> Subject: Re: [dpdk-dev] [PATCH] app/test: allow building with bonding net driver disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 01.05.2020 o 17:05, Bruce Richardson pisze: > The autotest application build was partially enabled for building with > the net/bond driver disabled, but a number of items were missed, leading > to build errors when the driver was disabled, e.g. by simply doing > "-Ddisable_drivers=net/*" when calling meson. > > ../app/test/test_link_bonding.c:25:10: fatal error: rte_eth_bond.h: \ > No such file or directory > > With this fix in place, it's possible to build DPDK with meson with all > non-bus, non-mempool drivers disabled i.e. using meson option > > -Ddisable_drivers=baseband/*,compress/*,crypto/*,event/*,net/*,raw/*,vdpa/* > > Signed-off-by: Bruce Richardson > --- > app/test/meson.build | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/app/test/meson.build b/app/test/meson.build > index fc60acbe7..03dd6c3de 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -63,8 +63,6 @@ test_sources = files('commands.c', > 'test_ipsec_sad.c', > 'test_kni.c', > 'test_kvargs.c', > - 'test_link_bonding.c', > - 'test_link_bonding_rssconf.c', > 'test_logs.c', > 'test_lpm.c', > 'test_lpm6.c', > @@ -136,6 +134,8 @@ test_sources = files('commands.c', > ) > > test_deps = ['acl', > + 'bus_pci', > + 'bus_vdev', > 'bitratestats', > 'bpf', > 'cfgfile', > @@ -306,8 +306,6 @@ driver_test_names = [ > 'cryptodev_sw_zuc_autotest', > 'eventdev_selftest_octeontx', > 'eventdev_selftest_sw', > - 'link_bonding_autotest', > - 'link_bonding_rssconf_autotest', > 'rawdev_autotest', > ] > > @@ -340,6 +338,8 @@ endif > # they are used via a driver-specific API. > if dpdk_conf.has('RTE_LIBRTE_BOND_PMD') > test_deps += 'pmd_bond' > + test_sources += ['test_link_bonding.c', 'test_link_bonding_rssconf.c'] > + driver_test_names += ['link_bonding_autotest', 'link_bonding_rssconf_autotest'] > endif > if dpdk_conf.has('RTE_LIBRTE_RING_PMD') > test_deps += 'pmd_ring' testing conditions: * confirmed issue without patch and build flag: -Ddisable_drivers=net/* fails to build * with patch applied test app still builds without flags * with patch applied test app builds with -Ddisable_drivers=baseband/*,compress/*,crypto/*,event/*,net/*,raw/*,vdpa/* Acked-by: Lukasz Wojciechowski Tested-by: Lukasz Wojciechowski -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com