From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 4946858FE for ; Tue, 2 Apr 2019 21:19:08 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id h4so18059595wre.7 for ; Tue, 02 Apr 2019 12:19:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=3GbFrtM4y9Lp4Nh1PaJom/0luMdx6C0e1qfWOjZEFmE=; b=YA+V3hmsWrvDBCOdOWQIx5yzI4SyCbjuSvNr4LOP1Lx1y0zvGAXFO8u7C+H0A8N+lN 9HQh4FhF+0LFiLpxM3FfrSmkT8PnYihFFvVjEDU7b4eddIaEi2OKNPoxf7RkCHSwVpL/ heeTrNsQ3aOlIdVyRlyPqwGlN0Wmi6knWw9TciglxDB9YQxkDoBBK4DmAVSJU1DJ6Xc6 V4iAwCzpZI1Bodh3TlfejCDzrVuLNcMdpenn3XjuRRwQ53z/TzowzCQ8w0FpiWa+itnB /J84G8Q1s1Q2a85xiOE69jZ/NMGGG5Fedz5gNUJjADAKflTUZZzC3juiaQJCr7WvLa1A 2jVg== X-Gm-Message-State: APjAAAVCOOsfzdBUpg14JkhxfWzoRzqapu7mblE9w2aF3hcCI5kVe3P+ i67DuzBo0G1ShyV95gzY6Yo= X-Google-Smtp-Source: APXvYqzdXYKSHcDYe92Y+yurrIiI0Eoavs172tz5DQXf3DiNRO+X9GpIdSQR9YI9zAwFOcu+cEC07w== X-Received: by 2002:adf:ffc2:: with SMTP id x2mr34402149wrs.86.1554232747728; Tue, 02 Apr 2019 12:19:07 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id 192sm12192561wme.13.2019.04.02.12.19.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Apr 2019 12:19:06 -0700 (PDT) Message-ID: From: Luca Boccassi To: Xiaolong Ye , dev@dpdk.org, Stephen Hemminger , Ferruh Yigit Cc: Qi Zhang , Karlsson Magnus , Topel Bjorn , Maxime Coquelin , Bruce Richardson , Ananyev Konstantin , David Marchand , Andrew Rybchenko , Olivier Matz Date: Tue, 02 Apr 2019 20:19:06 +0100 In-Reply-To: <20190402154653.711-2-xiaolong.ye@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190402154653.711-1-xiaolong.ye@intel.com> <20190402154653.711-2-xiaolong.ye@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 19:19:08 -0000 On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote: > diff --git a/drivers/net/af_xdp/Makefile > b/drivers/net/af_xdp/Makefile > new file mode 100644 > index 000000000..8343e3016 > --- /dev/null > +++ b/drivers/net/af_xdp/Makefile > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2019 Intel Corporation > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name > +# > +LIB =3D librte_pmd_af_xdp.a > + > +EXPORT_MAP :=3D rte_pmd_af_xdp_version.map > + > +LIBABIVER :=3D 1 > + > +CFLAGS +=3D -O3 > + > +# require kernel version >=3D v5.1-rc1 > +CFLAGS +=3D -I$(RTE_KERNELDIR)/tools/include > +CFLAGS +=3D -I$(RTE_KERNELDIR)/tools/lib/bpf Sorry for not noticing this before, but doesn't this require the full kernel tree rather than just the typical headers package? Requiring the full kernel tree to be available at build time will make this unbuildable on distros that still use makefiles, like RHEL and SUSE. At least on Debian and Ubuntu, the kernel headers packages distributed do not include the full kernel tree, only the headers, so there's no tools/lib or tools/include. Like other dependencies, this should assume they are installed as regular libraries, eg: CFLAGS +=3D $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config --= cflags libbpf || echo "-I/usr/include/bpf") > +CFLAGS +=3D $(WERROR_FLAGS) > +LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > +LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs > +LDLIBS +=3D -lrte_bus_vdev > +LDLIBS +=3D -lbpf LDLIBS +=3D $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config --= libs libbpf || echo "-lbpf") --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 87B20A0679 for ; Tue, 2 Apr 2019 21:19:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2C9B6C9B; Tue, 2 Apr 2019 21:19:09 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 4946858FE for ; Tue, 2 Apr 2019 21:19:08 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id h4so18059595wre.7 for ; Tue, 02 Apr 2019 12:19:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=3GbFrtM4y9Lp4Nh1PaJom/0luMdx6C0e1qfWOjZEFmE=; b=YA+V3hmsWrvDBCOdOWQIx5yzI4SyCbjuSvNr4LOP1Lx1y0zvGAXFO8u7C+H0A8N+lN 9HQh4FhF+0LFiLpxM3FfrSmkT8PnYihFFvVjEDU7b4eddIaEi2OKNPoxf7RkCHSwVpL/ heeTrNsQ3aOlIdVyRlyPqwGlN0Wmi6knWw9TciglxDB9YQxkDoBBK4DmAVSJU1DJ6Xc6 V4iAwCzpZI1Bodh3TlfejCDzrVuLNcMdpenn3XjuRRwQ53z/TzowzCQ8w0FpiWa+itnB /J84G8Q1s1Q2a85xiOE69jZ/NMGGG5Fedz5gNUJjADAKflTUZZzC3juiaQJCr7WvLa1A 2jVg== X-Gm-Message-State: APjAAAVCOOsfzdBUpg14JkhxfWzoRzqapu7mblE9w2aF3hcCI5kVe3P+ i67DuzBo0G1ShyV95gzY6Yo= X-Google-Smtp-Source: APXvYqzdXYKSHcDYe92Y+yurrIiI0Eoavs172tz5DQXf3DiNRO+X9GpIdSQR9YI9zAwFOcu+cEC07w== X-Received: by 2002:adf:ffc2:: with SMTP id x2mr34402149wrs.86.1554232747728; Tue, 02 Apr 2019 12:19:07 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id 192sm12192561wme.13.2019.04.02.12.19.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Apr 2019 12:19:06 -0700 (PDT) Message-ID: From: Luca Boccassi To: Xiaolong Ye , dev@dpdk.org, Stephen Hemminger , Ferruh Yigit Cc: Qi Zhang , Karlsson Magnus , Topel Bjorn , Maxime Coquelin , Bruce Richardson , Ananyev Konstantin , David Marchand , Andrew Rybchenko , Olivier Matz Date: Tue, 02 Apr 2019 20:19:06 +0100 In-Reply-To: <20190402154653.711-2-xiaolong.ye@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190402154653.711-1-xiaolong.ye@intel.com> <20190402154653.711-2-xiaolong.ye@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402191906.cWBf28yRRpaT9KtS9n9pDo83IfSsHxnpseTc5Mv4nkM@z> On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote: > diff --git a/drivers/net/af_xdp/Makefile > b/drivers/net/af_xdp/Makefile > new file mode 100644 > index 000000000..8343e3016 > --- /dev/null > +++ b/drivers/net/af_xdp/Makefile > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2019 Intel Corporation > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name > +# > +LIB =3D librte_pmd_af_xdp.a > + > +EXPORT_MAP :=3D rte_pmd_af_xdp_version.map > + > +LIBABIVER :=3D 1 > + > +CFLAGS +=3D -O3 > + > +# require kernel version >=3D v5.1-rc1 > +CFLAGS +=3D -I$(RTE_KERNELDIR)/tools/include > +CFLAGS +=3D -I$(RTE_KERNELDIR)/tools/lib/bpf Sorry for not noticing this before, but doesn't this require the full kernel tree rather than just the typical headers package? Requiring the full kernel tree to be available at build time will make this unbuildable on distros that still use makefiles, like RHEL and SUSE. At least on Debian and Ubuntu, the kernel headers packages distributed do not include the full kernel tree, only the headers, so there's no tools/lib or tools/include. Like other dependencies, this should assume they are installed as regular libraries, eg: CFLAGS +=3D $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config --= cflags libbpf || echo "-I/usr/include/bpf") > +CFLAGS +=3D $(WERROR_FLAGS) > +LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > +LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs > +LDLIBS +=3D -lrte_bus_vdev > +LDLIBS +=3D -lbpf LDLIBS +=3D $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config --= libs libbpf || echo "-lbpf") --=20 Kind regards, Luca Boccassi