From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B1A1A0567; Fri, 13 Mar 2020 11:42:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 694BA1BF97; Fri, 13 Mar 2020 11:42:52 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id E27363B5 for ; Fri, 13 Mar 2020 11:42:50 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id 6so9357044wmi.5 for ; Fri, 13 Mar 2020 03:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=accelercomm-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=mtp1791MHL2hb723ZnKqFFJzh2nIJAG1WAFoEDaw6YE=; b=rs+qGiQgXedoObxEwH9FRzvGN2GaOQjFtkZT9UBTWVdd7rbQO0Xd+hx7tzW66Q5Tnk F/pu5jspsNfZgBdTs+Utk5hGULUwuvrYWxG/0TLQxb+Fq9AhyYO/e0UHXjGKIfts2rHY mWsgeazplRwRtJjZqlOblnuOMeLFFpP9a4csq4u6SV2yIgfOO4sX0TLBaTO+RJzVTvr0 5cpFnpRGqMz7+1c0KortkyXDXb6SFqn/2K0/NmMTe4PULpCxTzSH/P0VFw3coDsfqyXe 9a/ikvU5sstcTlfpgCoL8jSpyfzi9sUwmaio7Y0qUlrdDOrhnqEokaE5cBN8D4SsSZpL Ipuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=mtp1791MHL2hb723ZnKqFFJzh2nIJAG1WAFoEDaw6YE=; b=Dsv99tjYt1EkNWmNtJ/IqX0P8I0t4Pj9X0JY3CuAwIfi3KCpBdElSFUye0/qaXpvBx Zg41P3F5ejJFXwIG/sTlgxQ063oXs/TO9KpDhtCM6tFb1yahtT+tT47xOGfitFVSr+Ge jf3J/yaBaeFvIDgRsZ4+Qp45OJUYGr9kCpdzI+3D0jPAbf0rKBIsHZz3o9uY4ho5hVRD bkU7z2IybSPmYCSK1UnCA60tDjXrDuIRIwVjM9Zv9tEf3L2ikrM2d42fCb7Ahq5FXxjW XblapoHkvm+zakMYCg4iBKBJMV6ztuYgfYY8vqBounJuWEoyvjVxlVDRdV3BKDYzbXho 9ygg== X-Gm-Message-State: ANhLgQ0Iw0jYsjXz294JB3HW4xp89TPjmn09UNSoyduBp/AqtytMyA5N ssD+RUHxTONTKc7E3sQ/+iR5IGlwBlI= X-Google-Smtp-Source: ADFU+vsRo1KlNQ8dAH/I3QRdChwFZnG7LoGVDCSBbGjvymjZRtk+mnn7gD7wq23a6+cIF3OBeCrWVg== X-Received: by 2002:a05:600c:286:: with SMTP id 6mr10213329wmk.101.1584096170097; Fri, 13 Mar 2020 03:42:50 -0700 (PDT) Received: from [192.168.1.189] ([89.21.231.54]) by smtp.gmail.com with ESMTPSA id l64sm16702972wmf.30.2020.03.13.03.42.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2020 03:42:48 -0700 (PDT) To: dev@dpdk.org References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-1-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-2-git-send-email-nicolas.chautru@intel.com> From: Dave Burley Message-ID: Date: Fri, 13 Mar 2020 10:42:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1583348102-13253-2-git-send-email-nicolas.chautru@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 01/14] bbdev: add capability flag for filler bits inclusion in HARQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Dave Burley On 04/03/2020 18:54, Nicolas Chautru wrote: > From: Nic Chautru > > Adding capability flag for device variants when HARQ buffer > may or may not include the filler bits. > Minor cosmetic changes in same file. > > Signed-off-by: Nic Chautru > --- > lib/librte_bbdev/rte_bbdev.h | 2 ++ > lib/librte_bbdev/rte_bbdev_op.h | 12 ++++++++++-- > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_bbdev/rte_bbdev.h b/lib/librte_bbdev/rte_bbdev.h > index 591fb79..b2da190 100644 > --- a/lib/librte_bbdev/rte_bbdev.h > +++ b/lib/librte_bbdev/rte_bbdev.h > @@ -607,6 +607,7 @@ struct __rte_cache_aligned rte_bbdev { > * @param ops > * Pointer array where operations will be dequeued to. Must have at least > * @p num_ops entries > + * ie. A pointer to a table of void * pointers (ops) that will be filled. > * @param num_ops > * The maximum number of operations to dequeue. > * > @@ -638,6 +639,7 @@ struct __rte_cache_aligned rte_bbdev { > * @param ops > * Pointer array where operations will be dequeued to. Must have at least > * @p num_ops entries > + * ie. A pointer to a table of void * pointers (ops) that will be filled. > * @param num_ops > * The maximum number of operations to dequeue. > * > diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev_op.h > index 1e119a7..062f9ff 100644 > --- a/lib/librte_bbdev/rte_bbdev_op.h > +++ b/lib/librte_bbdev/rte_bbdev_op.h > @@ -31,8 +31,11 @@ > #define RTE_BBDEV_TURBO_MAX_TB_SIZE (391656) > /* Maximum size of Code Block (36.212, Table 5.1.3-3) */ > #define RTE_BBDEV_TURBO_MAX_CB_SIZE (6144) > -/* Maximum size of Code Block */ > +/* Maximum size of Code Block */ > #define RTE_BBDEV_LDPC_MAX_CB_SIZE (8448) > +/* Minimum size of Code Block */ > +#define RTE_BBDEV_LDPC_MIN_CB_SIZE (40) > + > /* Minimum size of Code Block (36.212, Table 5.1.3-3) */ > #define RTE_BBDEV_TURBO_MIN_CB_SIZE (40) > /* Maximum size of circular buffer */ > @@ -177,7 +180,12 @@ enum rte_bbdev_op_ldpcdec_flag_bitmasks { > /** Set if a device supports loop-back access to > * HARQ internal memory. Intended for troubleshooting. > */ > - RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK = (1ULL << 17) > + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK = (1ULL << 17), > + /** Set if a device includes LLR filler bits in the circular buffer > + * for HARQ memory. If not set, it is assumed the filler are not in > + * HARQ memory and handled directory by the LDPC decoder. > + */ > + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS = (1ULL << 18) > }; > > /** Flags for LDPC encoder operation and capability structure */