From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60D53A0548; Tue, 18 May 2021 09:17:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDFE84068E; Tue, 18 May 2021 09:17:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 575D040041 for ; Tue, 18 May 2021 09:17:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621322224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JO67Kn5TXbvsK4lyPTAkv81cTE1DbUCcMD0UTVcd0kQ=; b=VV5eFId7dZJprALDGw8X/7DzGIEBAu60waVQHoNZshYUYUOgHw7iXJpXKoVHDagdNSHnXK MxV7KG4kJg29KcyOZlnli5GTFN3P3z/SHAkYfUZLJv/Kb2wuBaJ3/h5+/oZTKm/PdYQ7gy Mzl3EaV3l0WZwUq/FYzZL7ai6TWjjIQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-gsjCSOpfNoyjEKvj8eLY-A-1; Tue, 18 May 2021 03:17:01 -0400 X-MC-Unique: gsjCSOpfNoyjEKvj8eLY-A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB1D21007CA7; Tue, 18 May 2021 07:16:59 +0000 (UTC) Received: from [10.36.110.30] (unknown [10.36.110.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4EAAA5D71D; Tue, 18 May 2021 07:16:54 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@intel.com, Chenbo Xia References: <20210518070728.15341-1-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: Date: Tue, 18 May 2021 09:16:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210518070728.15341-1-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/vhost: restore pseudo TSO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, On 5/18/21 9:07 AM, David Marchand wrote: > The net/vhost pmd does not comply with the ethdev offload API as it does > not report rx/tx offload capabilities wrt TSO and checksum offloading. > On the other hand, the net/vhost pmd lets guest negotiates TSO and > checksum offloading. > > Changing the behavior for rx/tx offload flags handling won't > improve/fix this situation and will break applications that might have > been relying on implicit support of TSO in this driver. > > Revert this behavior change until we have a complete fix. > > Fixes: ca7036b4af3a ("vhost: fix offload flags in Rx path") > > Signed-off-by: David Marchand > --- > The full fix requires: > - reporting rx/tx_offload_capa, > - supporting sw TSO and checksums for the case when a virtual machine > negotiates this feature, but the application does not configure > DEV_[RT]X_OFFLOAD_* appropriate flags, > > --- > drivers/net/vhost/rte_eth_vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > index 8524898661..a202931e9a 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -1505,7 +1505,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) > int ret = 0; > char *iface_name; > uint16_t queues; > - uint64_t flags = RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS; > + uint64_t flags = 0; > uint64_t disable_flags = 0; > int client_mode = 0; > int iommu_support = 0; > As we discussed yesterday, I agree that's the best thing to do while proper TSO support is implemented. Reviewed-by: Maxime Coquelin Thanks, Maxime