From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 8361225E5; Wed, 29 Nov 2017 10:52:03 +0100 (CET) Received: from pure.maildistiller.com (dispatch1.mdlocal [10.7.20.164]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id ED50E60F51; Wed, 29 Nov 2017 09:52:02 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (us4-filterqueue.mdlocal [10.7.20.246]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 625E01C004F; Wed, 29 Nov 2017 09:52:02 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id EB132B40064; Wed, 29 Nov 2017 09:52:01 +0000 (UTC) Received: from [192.168.239.128] (193.34.186.16) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 29 Nov 2017 09:51:55 +0000 To: Ferruh Yigit , CC: Mark Spender , References: <1510819481-6809-1-git-send-email-arybchenko@solarflare.com> <1510819481-6809-43-git-send-email-arybchenko@solarflare.com> <0b75e6e5-b7d0-4cd5-b840-fd1208faf220@intel.com> <638e3313-89b7-8668-c059-3d4ff39e6b21@solarflare.com> <8dab11d5-925e-e951-5a28-95cc4765bb4b@intel.com> From: Andrew Rybchenko Message-ID: Date: Wed, 29 Nov 2017 12:51:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <8dab11d5-925e-e951-5a28-95cc4765bb4b@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [193.34.186.16] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23498.003 X-TM-AS-Result: No--8.890900-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1511949122-adPefZNkJ-Vn Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 42/53] net/sfc/base: fix probes in licensing support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 09:52:03 -0000 On 11/29/2017 12:38 AM, Ferruh Yigit wrote: > On 11/28/2017 2:17 AM, Andrew Rybchenko wrote: >> On 11/27/2017 10:58 PM, Ferruh Yigit wrote: >>> On 11/16/2017 12:04 AM, Andrew Rybchenko wrote: >>>> From: Mark Spender >>>> >>> What has been fixed here? >>> If you can provide more details I can amend the commit later. >> EFSYS_PROBE1 takes one typed value (in addition to the probe name), >> whereas EFSYS_PROBE has just the probe name. >> >> Which to use is determined by the probe name – “fail1” probes are >> expected to include the function result. > Commits are amended with shared updates and pushed, this and other ones. Ferruh, many thanks for review and your notes/questions. > Thanks, > ferruh > >> Thanks, >> Andrew. >> >>>> Fixes: 05fce2ce8451 ("net/sfc/base: import libefx licensing") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Mark Spender >>>> Signed-off-by: Andrew Rybchenko > <...>