From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Kathleen Capella <kathleen.capella@arm.com>,
Xiaoyun Li <xiaoyun.li@intel.com>
Cc: dev@dpdk.org, nd@arm.com, honnappa.nagarahalli@arm.com,
dharmik.thakkar@arm.com, Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [RFC 0/1] app/testpmd: add l3fwd mode to testpmd
Date: Fri, 2 Jul 2021 13:15:37 +0300 [thread overview]
Message-ID: <d346cb90-862f-650e-dd58-aee3a07156b0@oktetlabs.ru> (raw)
In-Reply-To: <20210430213747.41530-1-kathleen.capella@arm.com>
@Xiaoyun could you share your thoughts on it?
As far as I remember there is no agreement on the topic. Adding
more people in Cc.
On 5/1/21 12:37 AM, Kathleen Capella wrote:
> Performance of the LPM mode in L3fwd example application is used as an industry
> standard to compare between various platforms.
>
> Unfortunately, L3fwd example application lacks debugging capabilities to
> understand the performance bottlenecks and fix them.
>
> While debugging performance issues we need all the flexibility possible.
> Some of the capabilities we have used are:
> 1) ability to print hardware and software statistics - xstats, stats at
> port/queue level, burst stats to identify any headroom available,
> CPU cycles/packet etc
> 2) ability to modify all possible configurable parameters for the PMD
> as well as the application at run time without recompiling the code.
> Some of the parameters we have used are RX/TX queue depths, burst size,
> number of receive queues, PMD specific parameters etc. This
> configurability at runtime helps to understand and debug L3fwd
> performance issues quickly and effectively.
>
> It is possible to add all these capabilities to L3fwd example application.
> However, doing that we will result in L3fwd example application losing
> its purpose (of being a sample application). At the same time, testpmd
> application has all these capabilities to debug an application. In my opinion
> it makes sense to add L3fwd mode to testpmd.
>
> This patch adds l3fwd mode into testpmd to take advantage of the
> existing infrastructure in testpmd.
>
> I'd like to hear from the community if the structure of this change makes sense,
> namely, adding l3fwd as a separate fwd_engine into testpmd.
>
> This feature is not yet implemeted for SSE or AltiVec.
>
> Kathleen Capella (1):
> app/testpmd: add l3fwd mode to testpmd
>
> app/test-pmd/config.c | 66 +++++++
> app/test-pmd/l3fwd.c | 356 ++++++++++++++++++++++++++++++++++
> app/test-pmd/l3fwd.h | 143 ++++++++++++++
> app/test-pmd/l3fwd_common.h | 268 +++++++++++++++++++++++++
> app/test-pmd/l3fwd_lpm.h | 107 ++++++++++
> app/test-pmd/l3fwd_lpm_neon.h | 169 ++++++++++++++++
> app/test-pmd/l3fwd_neon.h | 234 ++++++++++++++++++++++
> app/test-pmd/meson.build | 3 +-
> app/test-pmd/testpmd.c | 4 +-
> app/test-pmd/testpmd.h | 20 ++
> 10 files changed, 1368 insertions(+), 2 deletions(-)
> create mode 100644 app/test-pmd/l3fwd.c
> create mode 100644 app/test-pmd/l3fwd.h
> create mode 100644 app/test-pmd/l3fwd_common.h
> create mode 100644 app/test-pmd/l3fwd_lpm.h
> create mode 100644 app/test-pmd/l3fwd_lpm_neon.h
> create mode 100644 app/test-pmd/l3fwd_neon.h
>
next prev parent reply other threads:[~2021-07-02 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 21:37 Kathleen Capella
2021-04-30 21:37 ` [dpdk-dev] [RFC 1/1] " Kathleen Capella
2021-07-02 10:15 ` Andrew Rybchenko [this message]
2021-08-24 13:00 ` [dpdk-dev] [RFC 0/1] " Ferruh Yigit
2021-08-24 14:46 ` Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d346cb90-862f-650e-dd58-aee3a07156b0@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=ferruh.yigit@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=kathleen.capella@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=sthemmin@microsoft.com \
--cc=thomas@monjalon.net \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).