From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C3B94236B; Thu, 12 Oct 2023 04:25:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB5FD402BA; Thu, 12 Oct 2023 04:25:50 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 12EB040279 for ; Thu, 12 Oct 2023 04:25:49 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S5YMg6dj0zrTGc; Thu, 12 Oct 2023 10:23:11 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 12 Oct 2023 10:25:46 +0800 Message-ID: Date: Thu, 12 Oct 2023 10:25:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 08/40] net/cnxk: check RSS hash algorithms To: Ferruh Yigit , , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao CC: , , References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-9-haijie1@huawei.com> From: Jie Hai In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/10/12 1:04, Ferruh Yigit wrote: > On 10/11/2023 10:27 AM, Jie Hai wrote: >> A new field 'algorithm' has been added to rss_conf, check it >> in case of ignoring unsupported values. >> >> Signed-off-by: Jie Hai >> --- >> drivers/net/cnxk/cnxk_ethdev.c | 5 +++++ >> drivers/net/cnxk/cnxk_ethdev_ops.c | 3 +++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c >> index 01b707b6c4ac..dc150de745df 100644 >> --- a/drivers/net/cnxk/cnxk_ethdev.c >> +++ b/drivers/net/cnxk/cnxk_ethdev.c >> @@ -976,6 +976,10 @@ nix_rss_default_setup(struct cnxk_eth_dev *dev) >> if (rss_hash_level) >> rss_hash_level -= 1; >> >> + if (eth_dev->data->dev_conf.rx_adv_conf.rss_conf.algorithm != >> + RTE_ETH_HASH_FUNCTION_DEFAULT) >> + return -EINVAL; >> + >> flowkey_cfg = cnxk_rss_ethdev_to_nix(dev, rss_hf, rss_hash_level); >> return roc_nix_rss_default_setup(&dev->nix, flowkey_cfg); >> } >> @@ -1373,6 +1377,7 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev) >> } >> >> /* Configure RSS */ >> + >> > > Looks like unintended change. Will check it before setup in cnxk_nix_configure(). > >> rc = nix_rss_default_setup(dev); >> if (rc) { >> plt_err("Failed to configure rss rc=%d", rc); >> diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c >> index 3ade8eed3626..b6cba99cbb7f 100644 >> --- a/drivers/net/cnxk/cnxk_ethdev_ops.c >> +++ b/drivers/net/cnxk/cnxk_ethdev_ops.c >> @@ -1054,6 +1054,9 @@ cnxk_nix_rss_hash_update(struct rte_eth_dev *eth_dev, >> int rc = -EINVAL; >> uint8_t alg_idx; >> >> + if (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT) >> + goto fail; >> + >> if (rss_conf->rss_key && rss_conf->rss_key_len != ROC_NIX_RSS_KEY_LEN) { >> plt_err("Hash key size mismatch %d vs %d", >> rss_conf->rss_key_len, ROC_NIX_RSS_KEY_LEN); > > .