From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBD20A04B5; Wed, 13 Jan 2021 12:18:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 813CA140D12; Wed, 13 Jan 2021 12:18:15 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 32444140CFC; Wed, 13 Jan 2021 12:18:12 +0100 (CET) IronPort-SDR: zCZkcK6e5v7SUSyYa8Fj9DnEuROtTkVeKGfgfK+RtqAm7ufOpn7MpQYxVlR7O8v9XVaHgcSgYF ebvWB1d0pqrA== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="165863222" X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="165863222" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 03:18:11 -0800 IronPort-SDR: v2lQuUm/OCORYM2GnPEJEPSWr3oDhiglziPBeqZ6Ch43i+krLZko2GVuitzLdebmxo1sq8pDnX VyScJucrKDmw== X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="381806989" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.253.108]) ([10.213.253.108]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 03:18:10 -0800 To: David Hunt , dev@dpdk.org Cc: stable@dpdk.org References: <20201217113656.28884-1-david.hunt@intel.com> <20210108143048.23755-1-david.hunt@intel.com> <2a4c607c-8919-7572-0646-c9627e6cbe48@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Wed, 13 Jan 2021 11:18:09 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/6] power: fix make build for power apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13-Jan-21 11:14 AM, David Hunt wrote: > Hi Anatoly, > > On 13/1/2021 11:08 AM, Burakov, Anatoly wrote: >> On 08-Jan-21 2:30 PM, David Hunt wrote: >>> The power example applications that uses the virtio-serial method of >>> communication cannot currently be built with make, and can only be built >>> using meson/ninja. >>> >>> The guest channel message definitions and functions in guest_channel.h >>> are needed by applications and need to be made public. >>> >>> This worked pre-20.11, but now with all the meson/ninja changes, making >>> these apps externally no longer works. To fix, we need to move the >>> header >>> file with the API definitions for the channel commands public, and >>> rename >>> the functions accordingly. >>> >>> The main change is to rename channel_commands.h to >>> rte_power_guest_channel.h so that it gets picked up by the installer and >>> copied to /usr/local/include. Other changes include renaming #defines to >>> have RTE_ at the beginning instead of CPU_. Finally we refactor the code >>> to work with those changes. >>> >>> --- >>> v2 changes >>>    - re-worked from monolithic patch to a 6 patch patchset for easier >>> review >>> >>> [PATCH v2 1/6] power: create guest channel public header file >>> [PATCH v2 2/6] power: make channel msg functions public >>> [PATCH v2 3/6] power: rename public structs >>> [PATCH v2 4/6] power: rename defines >>> [PATCH v2 5/6] power: add new header file to export list >>> [PATCH v2 6/6] power: clean up includes >>> >> >> Just a general question: wouldn't it be better to move this stuff >> entirely into sample app and not bother with keeping it in the >> library? There is precedent - ethtool app has a "library" and an >> "application" part, i think you should be able to move it out of the >> library and into the sample app entirely without too much trouble, as >> code looks to be fairly self-contained. >> > > Agreed, that's a great idea. I could have a common lib under > examples/vm_power_manager, then two apps, vm_power_manager and > guest_cli. That would keep everything nicely local, and not expose the > channel API publicly. The only reason we were making it public was to > allow "make" to work, so that's not a good enought reason, tbh. I'll > throw a prototype together today. Yep, IIRC Make works perfectly fine with ethtool, so i don't see why it wouldn't work for your sample app as well. Thanks! > > Thanks, > Dave. > > > > -- Thanks, Anatoly