From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32DC443215; Fri, 27 Oct 2023 15:38:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DD0F42DE7; Fri, 27 Oct 2023 15:38:40 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2043.outbound.protection.outlook.com [40.107.212.43]) by mails.dpdk.org (Postfix) with ESMTP id 0B47C402B9 for ; Fri, 27 Oct 2023 15:38:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=awMPL7FihiutEjYvhS7YTzCnCkAaAl1jYBXuTcrxW0LsJa+p41L4EmTLn0b5RWpZ68L1KjDPR62wjWHUjY2XzlDwRWCgl3xmQy/m8qmD7R3jzhXWu28bz+kmjMPnznm3okUnIi1EQAw64qXJZeAVyUD1YpKsDCg/EjPvm0Rxj1QchRHhXGqdOYjMMcAHqZnyxqW3rtG9YIh8cZpXnCM/B0urcczFTvHWKgbMPUvywDXK1cWD1vySo3D32bUitIRGlpe1YyM8O4tNXZ9dFockRGhs/IviCHgaw5lOCnDLmhGIz8VHO+0r7jv8rZcR8GIw70645iGxGLb9A99SBraIxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QwvwIP90ml/xlGQaS93oRI0dB2tP2a50rrwMV0pSQRs=; b=QqIsVkB1FK08p1KEacvzUdI1lW94VoA0BdzeLT6j/5zfEvXfEeybOQdCWjBuWKtMAYzCkZcXrzSupwza4XuxWTTvKpWZeJLAZQHbfiw+8bplpr81aeNERLa+V4ansYUln6Xda0ysUlvfxOR2HLvcboS4L2BNrBmykDSw4CZhXLh4uTg7Pe7FD4W30J4F1hC9GYWkdKbY1E03jzfz51ubhCZuBAIER9fn8xX9pXTmjC52sx3VeY9kXfHtoQgU3BHfOw5DlZF4LNXjdVrr9qKsM+pws0BUpYj60NV6GDkYyVMCwxIyHHwq6hNvYDQ4KWKku6SbRH/shvkW4O/zytsFrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QwvwIP90ml/xlGQaS93oRI0dB2tP2a50rrwMV0pSQRs=; b=SjrNLd+36/bEBTYKdej61Znqq/J0ZMFwlEzfdt5rp/QDwVxFoiPuBOB7L0w1Kxmx2GpySIFzEJ1QaXq7YRSKGw6rxYo4QMefLrJb2urt34oCLUmqzLh7WRhzo8UMenVnbgzS73ZDskDKM/C0HO1UMv5uKDQjb0Jh386xi4LmWCM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL1PR12MB5379.namprd12.prod.outlook.com (2603:10b6:208:317::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.24; Fri, 27 Oct 2023 13:38:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6933.019; Fri, 27 Oct 2023 13:38:34 +0000 Message-ID: Date: Fri, 27 Oct 2023 14:38:28 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 00/24] add the NFP vDPA PMD Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com References: <20231026064324.177531-1-chaoyong.he@corigine.com> <20231027030001.602639-1-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231027030001.602639-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0246.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL1PR12MB5379:EE_ X-MS-Office365-Filtering-Correlation-Id: 98d94c50-e2b5-417d-6a51-08dbd6f203bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MLLZUwVyFnzo/w4IKzj9Hpt1HXvsfwJLd0HQ6wW7Ut6mhYoyrPB3izjJ6wJTqWMoTBWYRKBYDrQcbZd9zwsEen3qO4BH/ty4JR5BEutuIleQ6O90n0BcUJyjr9pYX3TPyBjb8c/qg9isGCUt0/R4XEHEH28JDVAjsQ6S88jrUcbuaaaTZaloKM2+MKT76Ky334ajtP45fHbtHnW/M1aq+gYWzVpHCvehV+9NYpuo2jXMwfe+FGov+rE9pGcTtFOND29ZzZXEzJ+sk9eOrqr15h12rlvY7YmTRBTLDuzlZ17xrnQdNFHveK46IZIHcXComNHRDn1CvrvhFlss/9l9e18UsPmU3TbLFIzSvu0CvWNFaS8aJZLNdro0P17leyKpH/XEP5V8HnurcFjp9OcGrzQOIZWD3zvr1Oip9gUNxz40xzgj53W9YY9JAUvXItb93JJELhpT1RZICo7qkUXbSIFfjUVJgkDQb//9UKgiIq5sfGkbfU6hTEqluyktrsdJpkUpbbIzehghgJsMn5wzrh4QX0Jp0urc3PYfAy1dVIFacEa27k1gTgVuXeNaUYzgKe1ya6IubccSxxMdg+umLSKSzUQ22ABFB2qZgWIgjzcTxDcMCItN1+Tvplyc30dysDjt7pNmIxwV3hTjroY0Ze0/ryhMcAmuhpxrCWLO2Jw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(396003)(39860400002)(366004)(346002)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(6666004)(6506007)(53546011)(6512007)(6486002)(478600001)(83380400001)(316002)(26005)(2616005)(2906002)(5660300002)(66946007)(66556008)(66476007)(44832011)(8676002)(8936002)(4326008)(41300700001)(31696002)(86362001)(36756003)(38100700002)(31686004)(21314003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0pxRDB3azR6VmJrbmttVjYxVkI4b3Q0UXBBSEN4Y01DYi9CR0l4L1Y3QVZY?= =?utf-8?B?MHJGd0R0QXl4WnNJLzQvQzZvdFNJMjZzMkV2a09zREhyNllkTjEraGJpYThj?= =?utf-8?B?ZUlKVkEwcjdaR0EreU9FMTVtZU41SXluU3lkYnYyNDJSdjdHU2htbmpIaENP?= =?utf-8?B?S09mVjNyemJIRmxJUHNtSmNIekNpaEJ4VzBicFRJUklZRlRWaVp0N3pVbHdX?= =?utf-8?B?OFQxVkRQa3FVYzQxS2VKa3VUcGJBSWQyR2FUMjVsVzE0SnBwSERtcVhLL1VD?= =?utf-8?B?TWtyS0VlTk85VUVyenBJbnI3OWZnRWhnTW82S2ZsVnNsSHltU3c2L2hQRTV6?= =?utf-8?B?THpycjRiSnZzZ2U5M1JlbFRXUWtWRUNoK1pqZnMwRXVkQ1dGVXgxSU9sUDdS?= =?utf-8?B?MENsUEtYTGxNelhhVGlXQVE5bDhNRWtITzZGZ0JqdEN0RWxPK2NmWk8yZjdD?= =?utf-8?B?SVdOQVczUlZERkNFd3U1WTk2NVVIbkRXT3U2S1Q5blRpdGJYODB1alRPOXEx?= =?utf-8?B?ekUvdCt0ekhaYlp6ZGxCUjN6Rm4zMXpZOGZ0OERKSWt0a0FLUDFGeHVqNFZN?= =?utf-8?B?RnJhRkdZNGh6U1VvMGFsU29adU80YnEwSFoyNVl4Mlo2WEprUUNPNUNOeG1Z?= =?utf-8?B?UFB4a05mL2prd3JnZ1pEWDlOVGU5cERQRklqTFVYQ01iMkl0WTlXUVR3ZWhy?= =?utf-8?B?WGM5NSszTU1wbldUTjc2WlY5YmttTE5nTmE0aU1UWXZMWm1PQkJMbjZPeFVl?= =?utf-8?B?U1p3LzN1dDJqU3RoTktYMnFUdDJqLzJTT3kvY0JjRnV6bW56cW9nMXFxY0VJ?= =?utf-8?B?SmFacHRUYmh2TmJOZEc4SmNrUHo0bWhSTlRWYXRJNThNNmRONjRxTU5SeTFD?= =?utf-8?B?MVZaWE81Sk9jT2lzN0FOVHVBTG5EZ3habVlob0ZrdzgwSS9yZVRoRXZxVFRv?= =?utf-8?B?ZDhuMXhtSklnbjBoczVmdDdENFJRdEd3V28rbHREN0FoZzZHZnpOaHZlVjdi?= =?utf-8?B?VlA1Sk9DS1dvTWR4cy9BNFl0bXg2ZjlVZHo1Z2pXa3FMUkRDL1M4c28zWHBV?= =?utf-8?B?bVppRFVTWGNSSjkzcGptZlJsczR2bE5BY1FFOGI5VU43MCtVcEhNaS9mS3Nn?= =?utf-8?B?RWlDSDVhZkNFcm55c3VpbStXb0lDeDE2NGdGK3REdzhRUmFkUEJqc0o1Qnk2?= =?utf-8?B?NmRsUlQvaUFSS3ZmWko3dVNaZ1BDSjRHY0hSR05DTGRteTBQcTlkbHRHVThk?= =?utf-8?B?a3BzVHVGSUt3ZW5DNnBuZW5RSXFRRlczL1IrRks3bDVxV1Iva1RTODlLMDBC?= =?utf-8?B?YlQrZExXR3BDVDZuZnRxTm1oNTFaZmJYdEhZbEQxZTJSVWw3UUlsRUxVTFJz?= =?utf-8?B?YlYyRDZlTmpDMWozVUJZYWxsQXN3OXpINDZHSlZBNS9oY1BYNnY1Uy9SQnlO?= =?utf-8?B?bndVUGFzVnBRZDFRQUhxVDdnZU54QVBwM09UNVlTWjFzVGhDMVJxY3IxQm9z?= =?utf-8?B?eEdJNTZkTktFNTVjb0FxZm5LNlA3V2pUYUdxUzJ1UGE0L2x2bTN3VS9ZOXVE?= =?utf-8?B?eDFySE5XdFYzQ2hQaTdIUmFKMnRYNlNIcFpBTFJYU0tpcnpYVzRtKzN3VFBh?= =?utf-8?B?a0dISkxSNjlaeWZ1QUxuR0lPM2NhUUM5Vmh0QVBQUHcrTjJNeThwL0xzTVlU?= =?utf-8?B?WmhUeVZ4d1M0Ykh1UFMzZ3FIMGxUSzBhdFRUcTNjLzJMb1FvbkRGRDdMMWFP?= =?utf-8?B?L0p3QTVmMjU1bTlHUnhaQ281ejB0UW5XMWFuZitaa2hsVVdZNkJtcmdYQWdV?= =?utf-8?B?NjV5Q1F4R3djOXdQbW12U3FhSnN1dHFmQm81bDJoc0lGQmtGOHo4cHIzZjN1?= =?utf-8?B?bjkrdUVkM0hVL2twN1lNUEFib1ppUUJMY3FVb25lV01jRHFPc3RDV3czVktO?= =?utf-8?B?UXgrYmdYOUdySVRRYWlXb3ZGOFlOWGx5RkcySDZCY0tnVS9sL0k1eHJhZ2FE?= =?utf-8?B?R3dTWUZmSXRLM2JkVG0veFJzQzg4R0dSbEpLVG94RG1tYUIrLzMySmlyYXNX?= =?utf-8?B?T0JFc3hGbFRhTzBQYjRiSEF3U3JSaVNzWHFMRWNrTHlOVHpJd3VJZ1VhckJs?= =?utf-8?Q?5t0PlOvegilTUIEZmWKA4r+gD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98d94c50-e2b5-417d-6a51-08dbd6f203bd X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 13:38:33.9221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dvNklG3EHNzbMEty2JheHthS5ct+CWC0GatD1zUz/+8ju7WHloXXyc+lt52ChIXP X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5379 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/27/2023 3:59 AM, Chaoyong He wrote: > This patch series aims to add the NFP vDPA PMD, we also grab the common > logic into the `drivers/common/nfp` directory. > > --- > v4: > * Try to fix compile error in clang environment. > * Merge the modify of release notes into suitable commit. > * Rewrite the commit headline as the advise of reviewer. > v3: > * Replace 'pthread_xxx' API with 'rte_thread_xxx' API. > * Replace '__atomic_xxx' built-ins with 'rte_atomic_xxx'. > * Drop the check statement in meson.build file which prevent build of > PMD. > * Fix a problem about the logtype prefix. > * Move the document modification to the commit which should be. > v2: > * Grab more logic into the `drivers/common/nfp` directory. > * Delete some logic which should be when moving logic. > --- > > Chaoyong He (24): > common/nfp: introduce driver > net/nfp: make VF PMD use NFP common driver > net/nfp: rename net common module > net/nfp: rename ctrl module > net/nfp: extract cap data field > net/nfp: extract qcp data field > net/nfp: extract ctrl BAR data field > net/nfp: extract ctrl data field > net/nfp: change parameter of functions > net/nfp: change parameter of reconfig > net/nfp: extract MAC address data field > net/nfp: rename parameter in related logic > common/nfp: add common ctrl module > common/nfp: add common module > common/nfp: move queue logic > common/nfp: move platform module > common/nfp: move device module > vdpa/nfp: introduce driver > vdpa/nfp: add basic framework > vdpa/nfp: add remap PCI memory > vdpa/nfp: add hardware init > vdpa/nfp: add datapath update > vdpa/nfp: add notify related logic > vdpa/nfp: add device operations > Series applied to dpdk-next-net/main, thanks. Need to resolve conflict on 'nfp_net_supported_ptypes_get()' because of previous patch merged, can you please double check if the final output is good.