From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C3C9CFFA for ; Wed, 9 Nov 2016 10:39:11 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 09 Nov 2016 01:39:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,465,1473145200"; d="scan'208";a="189366342" Received: from rmitura-mobl1.ger.corp.intel.com (HELO [10.252.24.154]) ([10.252.24.154]) by fmsmga004.fm.intel.com with ESMTP; 09 Nov 2016 01:39:07 -0800 To: Thomas Monjalon References: <20161109082341.19825-1-bjorn.topel@intel.com> <1500406.Wuc0qeu8Dv@xps13> Cc: dev@dpdk.org, qian.q.xu@intel.com, lei.a.yao@intel.com, jingjing.wu@intel.com From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Message-ID: Date: Wed, 9 Nov 2016 10:39:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1500406.Wuc0qeu8Dv@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2016 09:39:12 -0000 > Thanks for raising the issue. It is completely defeating the generic > ethdev API. We must not have different behaviours depending of the > driver. Why it cannot be fixed in the driver? I should probably refer to the thread, where the concern was raised: http://dpdk.org/ml/archives/dev/2016-July/044555.html So, the issue is that i40evf *only support* CRC stripping for some setups (i40e Linux driver for PF, i40evf DPDK driver VF). The l3fwd application disables CRC stripping for all ports, which leads to i40evf_dev_configure() failure -- which from my POV is correct. Mis-configuring a port shouldn't be allowed. I'm open to suggestions here. What would be a better way to solve this? Maybe just adding a command-line option to the l3fwd application is a better way around? Björn