From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 97972A05D3 for ; Fri, 24 May 2019 15:04:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F5FA25D9; Fri, 24 May 2019 15:04:04 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 51F0EA69; Fri, 24 May 2019 15:04:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 May 2019 06:04:00 -0700 X-ExtLoop1: 1 Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.36]) ([10.237.221.36]) by fmsmga007.fm.intel.com with ESMTP; 24 May 2019 06:03:58 -0700 To: "Zhao1, Wei" , "dev@dpdk.org" Cc: "stable@dpdk.org" , "Peng, Yuan" , "Lu, Wenzhuo" References: <1557386447-57225-1-git-send-email-wei.zhao1@intel.com> <703bdff4-70c3-2c95-ac49-6ecb0165a3cc@intel.com> <8b5cd25b-5245-b385-ae91-5ecc7084ccac@intel.com> <000aa73c-fe6f-60d1-6060-5edf45e4349a@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQkI71rKFiEE 0jZTh0IuwoTjmYHH+TPrQ98TYR8FAlznMMQFCwkIBwMFFQoJCAsFFgIDAQAACgkQ+TPrQ98T YR/B9Q//a57esjq996nfZVm7AsUl7zbvhN+Ojity25ib2gcSVVsAN2j6lcQS4hf6/OVvRj3q CgebJ4o2gXR6X12UzWBJL7NE8Xpc70MvUIe0r11ykurQ9n9jUaWMjxdSqBPF93hU+Z/MZe5M 1rW5O2VJLuTJzkDw3EYUCbHOwPjeaS8Qqj3RI0LYbGthbHBIp9CsjkgsJSjTT5GQ8AQWkE7I z+hvPx6f1rllfjxFyi4DI3jLhAI+j1Nm+l+ESyoX59HrLTHAvq4RPkLpTnGBj9gOnJ+5sVEr GE0fcffsNcuMSkpqSEoJCPAHmChoLgezskhhsy0BiU3xlSIj1Dx2XMDerUXFOK3ftlbYNRte HQy4EKubfZRB8H5Rvcpksom3fRBDcJT8zw+PTH14htRApU9f8I/RamQ7Ujks7KuaB7JX5QaG gMjfPzHGYX9PfF6KIchaFmAWLytIP1t0ht8LpJkjtvUCSQZ2VxpCXwKyUzPDIF3co3tp90o7 X07uiC5ymX0K0+Owqs6zeslLY6DMxNdt8ye+h1TVkSZ5g4dCs4C/aiEF230+luL1CnejOv/K /s1iSbXQzJNM7be3FlRUz4FdwsfKiJJF7xYALSBnSvEB04R7I2P2V9Zpudkq6DRT6HZjBeJ1 pBF2J655cdoenPBIeimjnnh4K7YZBzwOLJf2c6u76fe5Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXOcvZgUJBvIWKAAKCRD5M+tD3xNhHxhBD/9toXMIaPIVFd9w1nKsRDM1GE6gZe4jie8q MJpeHB9O+936fSXA0W2X0het60wJQQ45O8TpTcxpc9nGzcE4MTaLAI3E8TjIXAO0cPqUNLyp g0DXezmTw5BU+SKZ51+jSKOtFmzJCHOJZQaMeCHD+G3CrdUHQVQBb5AeuH3KFv9ltgDcWsc8 YO70o3+tGHwcEnyXLdrI0q05wV7ncnLdkgVo+VUN4092bNMPwYly1TZWcU3Jw5gczOUEfTY7 sgo6E/sGX3B+FzgIs5t4yi1XOweCAQ/mPnb6uFeNENEFyGKyMG1HtjwBqnftbiFO3qitEIUY xWGQH23oKscv7i9lT0gg2D+ktzZhVWwHJVY/2vWSB9aCSWChcH2BT+lWrkwSpoPhy+almM84 Qz2wF72/d4ce4L27pSrS+vOXtXHLGOOGcAn8yr9TV0kM4aR+NbGBRXGKhG6w4lY54uNd9IBa ARIPUhij5JSygxZCBaJKo+X64AHGkk5bXq+f0anwAMNuJXbYC/lz4DEdKmPgQGShOWNs1Y1a N3cI87Hun/RBVwQ0a3Tr1g6OWJ6xK8cYbMcoR8NZ7L9ALMeJeuUDQR39+fEeHg/6sQN0P0mv 0sL+//BAJphCzDk8ztbrFw+JaPtgzZpRSM6JhxnY+YMAsatJRXA0WSpYP5zzl7yu/GZJIgsv VQ== Message-ID: Date: Fri, 24 May 2019 14:03:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by default configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/24/2019 2:55 AM, Zhao1, Wei wrote: > > Hi, Ferruh > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Tuesday, May 21, 2019 11:43 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: stable@dpdk.org; Peng, Yuan ; Lu, Wenzhuo >> >> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by >> default configuration >> >> On 5/21/2019 2:30 AM, Zhao1, Wei wrote: >>> Hi, Ferruh >>> >>>> -----Original Message----- >>>> From: Yigit, Ferruh >>>> Sent: Monday, May 20, 2019 11:23 PM >>>> To: Zhao1, Wei ; dev@dpdk.org >>>> Cc: stable@dpdk.org; Peng, Yuan ; Lu, Wenzhuo >>>> >>>> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix offloads >>>> overwrite by default configuration >>>> >>>> On 5/14/2019 2:56 AM, Zhao1, Wei wrote: >>>>> Hi, Ferruh >>>>> >>>>>> -----Original Message----- >>>>>> From: Yigit, Ferruh >>>>>> Sent: Tuesday, May 14, 2019 12:36 AM >>>>>> To: Zhao1, Wei ; dev@dpdk.org >>>>>> Cc: stable@dpdk.org; Peng, Yuan ; Lu, Wenzhuo >>>>>> >>>>>> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix offloads >>>>>> overwrite by default configuration >>>>>> >>>>>> On 5/9/2019 8:20 AM, Wei Zhao wrote: >>>>>>> There is an error in function rxtx_port_config(), which may >>>>>>> overwrite offloads configuration get from function >>>>>>> launch_args_parse() when run testpmd app. So rxtx_port_config() >>>>>>> should >>>> do "or" for port offloads. >>>>>>> >>>>>>> Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") >>>>>>> cc: stable@dpdk.org >>>>>>> >>>>>>> Signed-off-by: Wei Zhao >>>>>>> --- >>>>>>> app/test-pmd/testpmd.c | 5 +++++ >>>>>>> 1 file changed, 5 insertions(+) >>>>>>> >>>>>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >>>>>>> 6fbfd29..f0061d9 100644 >>>>>>> --- a/app/test-pmd/testpmd.c >>>>>>> +++ b/app/test-pmd/testpmd.c >>>>>>> @@ -2809,9 +2809,12 @@ static void rxtx_port_config(struct >>>>>>> rte_port *port) { >>>>>>> uint16_t qid; >>>>>>> + uint64_t offloads; >>>>>>> >>>>>>> for (qid = 0; qid < nb_rxq; qid++) { >>>>>>> + offloads = port->rx_conf[qid].offloads; >>>>>>> port->rx_conf[qid] = port->dev_info.default_rxconf; >>>>>>> + port->rx_conf[qid].offloads |= offloads; >>>>>> >>>>>> OK to this changes as a fix for this release. >>>>>> >>>>>> But I think intention is, if no offload information is provided by >>>>>> user to use use the driver provided defaults, if user explicitly >>>>>> provided some values to use them, instead of OR these two. >>>>>> >>>>>> With this approach it is not possible to disable a driver default >>>>>> value, so it becomes mandatory offload instead of default offload values. >>>>>> >>>>>> Wei, what do you think, does it make sense? >>>>> >>>>> >>>>> I agree with you, but it is sure that the original code has offloads >>>>> overwrite >>>> issue. >>>>> What is your suggestion for code implement? >>>>> I find that Thomas has apply it, if you has other idea, maybe you >>>>> has to >>>> commit patch base to this patch. >>>> >>>> Hi Wei, >>>> >>>> Yes this needs to be incremental fix to existing code. >>>> >>>> Queue specific offload can be altered either by providing Rx/Tx >>>> offload as command line argument [1] (port configs set to each >>>> queues) or via testpmd commands [2]. >>>> Does it make sense to set a global flag when one of above occurs and >>>> use default config only if it is not set? >>> >>> I AGREE with you to submit an incremental fix, and it make sense to >>> set a global flag when one of above occurs and use default config only if it is >> not set when implement code, but I do not have time to prepare such a patch >> by now, so maybe later or some else. >> >> I see, can you submit a public defect to record the issue, so it can be addressed >> later without forgotten? > > Sure, but what is a public defect patch? Do you mean I need to update some doc? Can you give me a link as an example No documentation, please create an issue in public DPDK bug tracker: https://bugs.dpdk.org/ > > >> >>> >>>> >>>> [1] >>>> Tx >>>> tx-offloads >>>> Rx >>>> disable-crc-strip >>>> enable-lro >>>> enable-scatter >>>> enable-rx-cksum >>>> enable-rx-timestamp >>>> enable-hw-vlan >>>> enable-hw-vlan-filter >>>> enable-hw-vlan-strip >>>> enable-hw-vlan-extend >>>> >>>> [2] >>>> "port config rx_offload ..." >>>> "port rxq rx_offload ..." >>>> "port config tx_offload ..." >>>> "port txq tx_offload ..." >>>> >>> >