From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6A5EA04B5; Wed, 13 Jan 2021 12:27:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26D95140D21; Wed, 13 Jan 2021 12:27:14 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id EB9F8140D1E for ; Wed, 13 Jan 2021 12:27:10 +0100 (CET) IronPort-SDR: X2OgSTlMHTPDJvT4+j5rjAWxErQLrmuSQFo8XuxA1MrRj2wvQbEmX0IizPADBWv999ANeojE1t ympEDDUUXu+A== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="157964850" X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="157964850" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 03:27:09 -0800 IronPort-SDR: VznATQT5+ujWOLPCu+G1yA9qEH4ve/8uKBGdOenl5cyGNMOR7wvoea9hg+ft7c64seX9vn64ZX +Zi1CpWwRDGA== X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="363855192" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.253.194]) ([10.213.253.194]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 03:26:54 -0800 To: Steve Yang , dev@dpdk.org Cc: wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, asomalap@amd.com, rahul.lakkireddy@chelsio.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, jia.guo@intel.com, haiyue.wang@intel.com, g.singh@nxp.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, xavier.huwei@huawei.com, humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com, jingjing.wu@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, rosen.xu@intel.com, sthotton@marvell.com, srinivasan@marvell.com, heinrich.kuhn@netronome.com, hkalra@marvell.com, jerinj@marvell.com, ndabilpuram@marvell.com, kirankumark@marvell.com, rmody@marvell.com, shshaikh@marvell.com, andrew.rybchenko@oktetlabs.ru, mczekaj@marvell.com, thomas@monjalon.net, ivan.boule@6wind.com, konstantin.ananyev@intel.com, samuel.gauthier@6wind.com, david.marchand@6wind.com, shahafs@mellanox.com, stephen@networkplumber.org, maxime.coquelin@redhat.com, olivier.matz@6wind.com, lihuisong@huawei.com, shreyansh.jain@nxp.com, wei.dai@intel.com, fengchunsong@huawei.com, chenhao164@huawei.com, tangchengchang@hisilicon.com, helin.zhang@intel.com, yanglong.wu@intel.com, xiaolong.ye@intel.com, ting.xu@intel.com, xiaoyun.li@intel.com, dan.wei@intel.com, andy.pei@intel.com, vattunuru@marvell.com, skori@marvell.com, sony.chacko@qlogic.com, bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, rad@semihalf.com, slawomir.rosek@semihalf.com, kamil.rytarowski@caviumnetworks.com, wei.zhao1@intel.com, junyux.jiang@intel.com, kumaras@chelsio.com, girish.nandibasappa@amd.com, rolf.neugebauer@netronome.com, alejandro.lucero@netronome.com References: <20201209031628.29572-1-stevex.yang@intel.com> <20201217092312.27033-1-stevex.yang@intel.com> <20201217092312.27033-3-stevex.yang@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 13 Jan 2021 11:26:51 +0000 MIME-Version: 1.0 In-Reply-To: <20201217092312.27033-3-stevex.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 02/22] app/testpmd: fix max rx packet length for VLAN packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/17/2020 9:22 AM, Steve Yang wrote: > When the max rx packet length is smaller than the sum of mtu size and > ether overhead size, it should be enlarged, otherwise the VLAN packets > will be dropped. > > Removed the rx_offloads assignment for jumbo frame during command line > parsing, and set the correct jumbo frame flag if MTU size is larger than > the default value 'RTE_ETHER_MTU' within 'init_config()'. > > Fixes: 384161e00627 ("app/testpmd: adjust on the fly VLAN configuration") > Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") > Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > Fixes: 150c9ac2df13 ("app/testpmd: update Rx offload after setting MTU") > > Signed-off-by: Steve Yang <...> > @@ -1446,6 +1447,25 @@ init_config(void) > rte_exit(EXIT_FAILURE, > "rte_eth_dev_info_get() failed\n"); > > + /* Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU */ > + if (port->dev_info.max_mtu && Similar to the ethdev comment, above check can be dropped. > + port->dev_info.max_mtu != UINT16_MAX && > + port->dev_info.max_rx_pktlen && > + port->dev_info.max_rx_pktlen > port->dev_info.max_mtu) > + eth_overhead = port->dev_info.max_rx_pktlen - > + port->dev_info.max_mtu; > + else > + eth_overhead = > + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN; > + > + if (port->dev_conf.rxmode.max_rx_pkt_len <= > + (uint32_t)(RTE_ETHER_MTU + eth_overhead)) > + port->dev_conf.rxmode.max_rx_pkt_len = > + RTE_ETHER_MTU + eth_overhead; > + else > + port->dev_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_JUMBO_FRAME; > + > if (!(port->dev_info.tx_offload_capa & > DEV_TX_OFFLOAD_MBUF_FAST_FREE)) > port->dev_conf.txmode.offloads &= >