From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 40A201B019 for ; Wed, 17 Jan 2018 16:03:46 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 8BF50B000A3; Wed, 17 Jan 2018 15:03:44 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 17 Jan 2018 15:03:39 +0000 To: Olivier MATZ CC: , "Artem V. Andreev" References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com> <1511539591-20966-2-git-send-email-arybchenko@solarflare.com> <20171214133640.3obnjsw7yu5sbq4w@platinum> From: Andrew Rybchenko Message-ID: Date: Wed, 17 Jan 2018 18:03:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20171214133640.3obnjsw7yu5sbq4w@platinum> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23600.003 X-TM-AS-Result: No--10.571100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1516201425-ljAW+j+tEczA Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC PATCH 1/6] mempool: implement abstract mempool info API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 15:03:46 -0000 On 12/14/2017 04:36 PM, Olivier MATZ wrote: > On Fri, Nov 24, 2017 at 04:06:26PM +0000, Andrew Rybchenko wrote: >> From: "Artem V. Andreev" >> >> Primarily, it is intended as a way for the mempool driver to provide >> additional information on how it lays up objects inside the mempool. >> >> Signed-off-by: Artem V. Andreev >> Signed-off-by: Andrew Rybchenko >> --- >> lib/librte_mempool/rte_mempool.h | 31 +++++++++++++++++++++++++++++++ >> lib/librte_mempool/rte_mempool_ops.c | 15 +++++++++++++++ >> 2 files changed, 46 insertions(+) >> >> diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h >> index 721227f..3c59d36 100644 >> --- a/lib/librte_mempool/rte_mempool.h >> +++ b/lib/librte_mempool/rte_mempool.h >> @@ -217,6 +217,11 @@ struct rte_mempool_memhdr { >> void *opaque; /**< Argument passed to the free callback */ >> }; >> >> +/* >> + * Additional information about the mempool >> + */ >> +struct rte_mempool_info; >> + > While there is no compilation issue, I find a bit strange to define this > API without defining the content of rte_mempool_info. Agree. Mainly it was an attempt to fit required way to store objects in memory into existing approach. I agree that it is significantly better to solve it in the different way as you suggested. So, the patch will go away.