From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD937433E2; Mon, 27 Nov 2023 17:36:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63EAB40648; Mon, 27 Nov 2023 17:36:08 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2050.outbound.protection.outlook.com [40.107.94.50]) by mails.dpdk.org (Postfix) with ESMTP id 111A3402A3 for ; Mon, 27 Nov 2023 17:36:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m4whH+faFRsu5eX8ClWs+xnFiZR9pxj8gQBvEkwkfmln9Vr8HGmL5iprC74mjdk4occEQgBEerL1LfiY4uU5XNCDda71DLD/LKvNkc0mXT0xFJhWGQuKhMN8zL90LEc26Sn9yDn79LT5MQwYq/kqiwxi0sNGQOp3LtfvNQLWYtZSTb6XS1W4R78Lx/U/hNB8U1NyYO98k1UWaGGsLZ7jwFuU4I7itmceldfSq5TfKK6saDF7jBIQvn4si4yqAlc3c+DpIPsYA6nWcG/IBzv+DNYGW8h/BTlA70uQGg/fsGc8KALMMEcMS5J638pfw3DBKI3rDK3zFuFcpq4HHSY7Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Aao6XDiWOBW2eX9uvblYPQyxg8Q3amuDhOsHkatGLU=; b=WODSIaGuryB5BCrqk7o3w5PIp6gedfmgBP2+AR8o0f36/1/QpMsVZ5DfcRJQAMAI0cHLpeE2vtX4FbVPYAC+fDA7uWUX2XaEzNexw37LK3aO8T4vTcprvZyLvMuvC8Lx/EWL23XLRy/WACrAvn6IIFrRpv5UJm+Is0XwtSxZsIIZ2S9Vtd4ajTKEY1s9n00pxrmA0JopdGLQhSFCkYDhyfL1UQcBZrcn9TYy/ceWdpayNe3sUlOoaUZQpxW6gC1oKAtOJqx0SZM6ypFXVeHWbFkqL1TaKu5dPI0ZEefzlvSko51b7Bfvisz5zfbKW7EVd0exotV/3nfe4LHbAHva+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Aao6XDiWOBW2eX9uvblYPQyxg8Q3amuDhOsHkatGLU=; b=fXCFJvP1B2wRhcMW+tOQ98VJMRXlLzETmeLbti+W6YzuHPNiF2DBmUfPb7QMly+RCnjvg7w7qtdS4GbTM3b8Xc2TOeDCUdv+hOY0J2+lfekDeeV1jSD2m4C5ngy6wByFo6n2Cq4s+L9Nq4F0jtmvF89TIUHj3LpSnIx3r714Kv0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB8059.namprd12.prod.outlook.com (2603:10b6:806:32b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Mon, 27 Nov 2023 16:36:03 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 16:36:03 +0000 Message-ID: Date: Mon, 27 Nov 2023 16:35:57 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature Content-Language: en-US From: Ferruh Yigit To: "lihuisong (C)" , dev@dpdk.org Cc: liuyonglong@huawei.com, thomas@monjalon.net, Chengwen Feng , Dongdong Liu , Jie Hai References: <20231123135916.33315-1-lihuisong@huawei.com> <20231125014745.61348-1-lihuisong@huawei.com> <20231125014745.61348-2-lihuisong@huawei.com> <89b73632-8a7a-e54c-2957-04c347027c2e@huawei.com> <8968ac41-bf19-40ac-a057-aad7b46b7ca8@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <8968ac41-bf19-40ac-a057-aad7b46b7ca8@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0116.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB8059:EE_ X-MS-Office365-Filtering-Correlation-Id: 66e02846-f04a-486d-aa66-08dbef66f263 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CBktPrOG1XgXusoi12yMQ+VIw7VBWmsLjIiGzqteQLEccECL8o/RRmTEpIVhVl2OSRWc8C+Y0IlOjS/HXbv97ZHmUjtlLxSTlgkMsGbovWImTJ3Dk9rhFABYOfk7Ap+cdlUv4esl7ffR3hKwEhiM7E9UJvHB7uZ4jbN0oFfS5Gdw8ht441Z7jIbf5KD6ky7S3PwzHMr0mlSlSBZpD7Sn7Prt2chxts90kAqK3tbPPmj6sx8yxwUUFO6x35Q88790Q19qUHmVEWbpBGpTe7xo8ueoZ8DsLt8sLtbdiBtK4gXok/GrsYo+lU+HP3OpEo585VjjYxipzaYJ07CCikky6tRF+oAp39fUSzYfQWUi7xrgX8MomxtvZWJ9CGLsfRJQcV9iWX8b8kxCIFX3whIroE0193XIQxe3jQeI/vC6LrPX4WBnnsvc25tNJ0bgNt/OzUyF1+Wk5HI0SwPOyEIEqz+Ge/2g1zcJsgcfTIbl3CvpKrY36UT/quDGdZ6Aj6Ub9qtZJAQsMG2N9Y1r0H6UrIHTtO4E1ShL+UwI0u9MJlgYFYKChJ+DdoZJnVj6ux41bQSuXyQI/QWb/Du+tjH1unAjsDjeFG/f5tT6Utk0ddxg7It+eDpO0AuQerbwZ/mcorOeixNRuQ9z7acTikSgsA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(346002)(376002)(366004)(39860400002)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(31686004)(4326008)(41300700001)(2906002)(8936002)(8676002)(2616005)(31696002)(6512007)(53546011)(6506007)(86362001)(316002)(66556008)(66946007)(5660300002)(66476007)(44832011)(54906003)(478600001)(36756003)(6666004)(6486002)(26005)(83380400001)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amxFYWVPdmRibEVWdVdSY3RsZUQzKyt5SFZqY1JKbjU1clM4bDgxdXFzSTlk?= =?utf-8?B?elpKbC80anJLUThJa2JlRVY0WU9OQm05czFFSVhRQlppRjBONnBQZEVaemVa?= =?utf-8?B?d3BTelQxUkVmQVh5My8zblk2azJpVDQ3UEcvQWpMTlpyalc0NjN6K25HYWsv?= =?utf-8?B?cGRSVkZWZUVCN2p1T0ZxRC9FL0I1ZnFidWVKUTI1L1E5QklXc2t5Y0pqUC9E?= =?utf-8?B?cGZOK0oxTUV0czVPcWQ2YzNSb1d4OC83SSs5dGNIb0ZaZC85K2FMSWlTVG00?= =?utf-8?B?MStDcHVOZWRQUk9rUnFPMTNNU09rTm03MVRvalEzZ2ZEUE45cTRBYUd6d1BD?= =?utf-8?B?ZWUzMTBBMExmSG1tOVpPNWtRL3dSTzFHd3ZzM2ZGRkw0cWlaN2krOXEwMVl5?= =?utf-8?B?ei90K2UvbEdSNi93Wkd2SEx1NDlSZmpUWVpWblR5MTVjK2tGcDhVQzlaemVq?= =?utf-8?B?YkZucS81TG9COVpKbUk1WTNjamhKZmtoNlo1YXR0VUpVMzUwQW9yeUZENTQ3?= =?utf-8?B?bFJkbXJhK1B2Rmdjd3hvMnpMNVdIeTVqT2lHYXZuK1g2TVZwYjE5RE8vUE9D?= =?utf-8?B?bWgrQUdoR1BuMmxTdnZLWERqZnI5ckNxcXIxSjZFZ0VTVVp6RnkzVWo3VDMr?= =?utf-8?B?TEhIcUJJcWI1V0kveTZNb092NVJ4amxZQW83VWVUalY3L3N1WUw3WlBDUUVY?= =?utf-8?B?aDhiSEF0NlNIaDNjajNrVEZCQTMzcWYxbkdiU2FkaHA1SjRTZXQ5R014OVpa?= =?utf-8?B?enp0L0RzQWVqb0RiOW51dG9nVm43K1NTTGxVeElTWUxCaVh3YTgrdGN5YWpS?= =?utf-8?B?NjkzRzNEcVNOWmpZdG5UTTVTR0tzVitLb1krdEoxSGkxY0c5Ym9hM1Q2SFZJ?= =?utf-8?B?eWg0UkhSM1FoTUNhU0t5VlVEVjVrVTZ0WTRrMTlLcC9MdFRqeXFNaDJwbkh1?= =?utf-8?B?RFhQa3UrNWs1VmpvL1pJZkxxWWxMR21reldBdUlOc1NTTmVRU1JKd2VrQmFE?= =?utf-8?B?QWVxRFlnWnAvb24rc2pDbXg3UmZoQnFINlJ0cFdMTlZ5a3QyLzAySVdjZ05R?= =?utf-8?B?ZUVTTzgzamNKNlFuSTJqcmxiQnY4Vm1PZ0R4QjkwSXV6ZFFrWnF1R3lOU05l?= =?utf-8?B?NEtGR1ovV3k5YzYwZHhzUDZCVUM5czJmNHZ3MVZHLzNBaERaeVhkbXFrT2hn?= =?utf-8?B?d1JXbVlDWW4zVUdLVFRMTmVETDhIakxvTjZWYkVsdVVLT0tpSFNjUjVkMUNs?= =?utf-8?B?U2NHOEZUZmkxWlRaNFBBSjhqNU1DWVNSVGJuZmo1aW5kUlArc2M0RzdyZHFY?= =?utf-8?B?THFrOUpUeFZTd3YxVlNxMXlwT3pyVDEvWTQ0VEczeWFIcnBhWHJSZXhiNDA1?= =?utf-8?B?VjhVcHQ5N2hlaSswSWd3U2JEdWVmVFFHMVpBQ1FxL0wvYkh5L01UV2dPdjZQ?= =?utf-8?B?SENHRnZFYUY5RXNVRDhIdnlzTjVvYmZhckxiaDZKT2VFS1N4d3lYaTdsNVlZ?= =?utf-8?B?NE5MTmFBcHRXS0c3TXI4UWRmbVQ3V1lTTHpZMXV6bEtrVUVXOEdUMHV2ZVBJ?= =?utf-8?B?Z0RIV3dwaURBQWNXcXZXL1lPVldnWEsybFk1NlIxZFFHMDZ6VTVMc1JaelQ0?= =?utf-8?B?dDlzcWNqdHJGSG9aUkl0MncyanhBT1liTTZWQ0lEUlFtbmpEdnZra0NEU2dQ?= =?utf-8?B?aGgxZFBUQ3pMQ0d0dk1WNWNsRGFjQWNxSkp5V3haSDUrU1diTngwQlRJUEt2?= =?utf-8?B?b1JKczZmc3VSWGxBRWZsNDdHUVdIWGl1VmtyL2tIVyt5MTlFaWNCcUozVG5Y?= =?utf-8?B?cSt3bVNZc3RXMStFZjl2N1Y3UjVZMWtTeXc4NzR2RWxrWGJsN0hUUUpjVjRl?= =?utf-8?B?aGFnU0h0ckRqblBIVVdjME1FTlRHZENaZUcrVC9HUzRVR1pkV2kzLzVIVkNr?= =?utf-8?B?S1loTUhpQnBxYXpsU1NyODJJNmllYUsvVkFOWXNNU3hYeC83TUVKdVhaeGVP?= =?utf-8?B?OGk1am1ZUGdyZE9DL1VMSUpFTVRUNWY1ZnN4SzNzVm5Pd01odVNZcUNjZEx3?= =?utf-8?B?T21FWnlkR3IwVkpLYWcxOGV3cENJT2hoQ1I3VnpXd1kvMjVTUkZsTlFENjZa?= =?utf-8?Q?DVxRbpenVMaiM4CC1rvwa4TRo?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66e02846-f04a-486d-aa66-08dbef66f263 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 16:36:03.7742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VaSoqqQNemsmGIOjKLda2jUZMeepveqKEi/JWfocila0XdzjwfnuNIpTzFqfDa4m X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8059 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/27/2023 3:43 PM, Ferruh Yigit wrote: > On 11/27/2023 1:12 PM, lihuisong (C) wrote: >> >> 在 2023/11/27 20:19, Ferruh Yigit 写道: >>> On 11/25/2023 1:47 AM, Huisong Li wrote: >>>> Add hash algorithm feature introduced by 23.11 and fix some RSS features >>>> description. >>>> >>>> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm") >>>> >>>> Signed-off-by: Huisong Li >>>> Acked-by: Chengwen Feng >>>> --- >>>>   doc/guides/nics/features.rst | 26 ++++++++++++++++++++++---- >>>>   1 file changed, 22 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst >>>> index 1a1dc16c1e..0d38c5c525 100644 >>>> --- a/doc/guides/nics/features.rst >>>> +++ b/doc/guides/nics/features.rst >>>> @@ -277,10 +277,12 @@ RSS hash >>>>   Supports RSS hashing on RX. >>>>     * **[uses]     user config**: ``dev_conf.rxmode.mq_mode`` = >>>> ``RTE_ETH_MQ_RX_RSS_FLAG``. >>>> -* **[uses]     user config**: ``dev_conf.rx_adv_conf.rss_conf``. >>>> +* **[uses]     user config**: ``rss_conf.rss_hf``. >>>> >>> Feature title is "RSS hash", it can be two things, >>> 1. "Receive Side Scaling" support >>> 2. Provide RSS hash to application >>> >>> When this document first prepared RSS hash value was always provided to >>> the application when RSS enabled. >>> So intention with this feature was "Receive Side Scaling" support, hence >>> 'RTE_ETH_MQ_RX_RSS_FLAG' added. >>> >>> Later providing RSS has to the application separated as optimization, >>> 'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for this >>> support. >> What should I do for above two comments？ >> To tell application how to use it? >> > > Just tried to give some context. > > >>> >>> As the intention of this feature is "Receive Side Scaling" support, we >>> shouldn't reduce configuration struct to 'rss_conf.rss_hf'. >>> >>> Instead perhaps can expand to: >>> 'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf' >> >>  I just pick their common part.😁 >> >> ok, will fix it. >> >>> >>> >>>>   * **[uses]     rte_eth_rxconf,rte_eth_rxmode**: >>>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. >>>>   * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``. >>>>   * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``, >>>> ``mbuf.rss``. >>>> +* **[related]  API**: ``rte_eth_dev_configure``, >>>> ``rte_eth_dev_rss_hash_update`` >>>> +  ``rte_eth_dev_rss_hash_conf_get()``. >>>>   >>> ack >>> >>>>     .. _nic_features_inner_rss: >>>> @@ -288,7 +290,7 @@ Supports RSS hashing on RX. >>>>   Inner RSS >>>>   --------- >>>>   -Supports RX RSS hashing on Inner headers. >>>> +Supports RX RSS hashing on Inner headers by rte_flow API. >>>>   >>> This should be clarified with details below, not sure if it required to >>> limit description to rte_flow. >> But this block like rte_flow_action_rss is from rte_flow. >> And ethdev ops doesn't support inner RSS. >> So I think it is ok. >> > > Yes it is supported by rte_flow, and '[uses]' information should already > clarify it. > > >>> >>> >>> And I guess similar confusion exist with the providing hash to user. >>> Need to check if rte_flow implementation puts hash to mbuf along with >>> doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload, >>> and update below items accordingly. >> Do we need to tell user how to use it here? >> I feel this document is a little simple and main to list interface for >> user. >> In addition, it is better that the more detail about RSS should be >> presented  in rte_flow features. >> > > No, I am not suggesting to add more detail. > > My concern is 'RTE_ETH_RX_OFFLOAD_RSS_HASH' information may not be > correct, ethdev APIs checks offload flags, but does rte_flow > implementation check it? > > My suggestion is double check that piece of information and fix it if > required. > Thinking twice, ethdev API or rte_flow or different ways to configure RSS, but datapath that puts hash value to mbuf is same. So same 'RTE_ETH_RX_OFFLOAD_RSS_HASH' check is used for both method, and it is OK to have it documented. > >>> >>> >>>>   * **[uses]    rte_flow_action_rss**: ``level``. >>>>   * **[uses]    rte_eth_rxconf,rte_eth_rxmode**: >>>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. >>>> @@ -303,9 +305,25 @@ RSS key update >>>>   Supports configuration of Receive Side Scaling (RSS) hash >>>> computation. Updating >>>>   Receive Side Scaling (RSS) hash key. >>>>   -* **[implements] eth_dev_ops**: ``rss_hash_update``, >>>> ``rss_hash_conf_get``. >>>> +* **[implements] eth_dev_ops**: ``dev_configure``, >>>> ``rss_hash_update``, ``rss_hash_conf_get``. >>>> +* **[uses]     user config**: ``rss_conf.rss_key``, >>>> ``rss_conf.rss_key_len`` >>>>   * **[provides]   rte_eth_dev_info**: ``hash_key_size``. >>>> -* **[related]    API**: ``rte_eth_dev_rss_hash_update()``, >>>> +* **[related]    API**: ``rte_eth_dev_configure``, >>>> ``rte_eth_dev_rss_hash_update()``, >>>> +  ``rte_eth_dev_rss_hash_conf_get()``. >>>> + >>> ack >>> >>> There is an inconsistency in the documentation but I think it is good to >>> use '()' when documenting API, like: 'rte_eth_dev_configure()' >> +1 will fix it. >>> >>> >>>> + >>>> +.. _nic_features_rss_hash_algo_update: >>>> + >>>> +RSS hash algorithm update >>>> +------------------------- >>>> + >>>> +Supports configuration of Receive Side Scaling (RSS) hash algorithm. >>>> Updating >>>> +RSS hash algorithm. >>>> + >>>> +* **[implements] eth_dev_ops**: ``dev_configure``, >>>> ``rss_hash_update``, ``rss_hash_conf_get``. >>>> +* **[uses]     user config**: ``rss_conf.algorithm`` >>>> +* **[provides]   rte_eth_dev_info**: ``rss_algo_capa``. >>>> +* **[related]    API**: ``rte_eth_dev_configure``, >>>> ``rte_eth_dev_rss_hash_update()``, >>>>     ``rte_eth_dev_rss_hash_conf_get()``. >>>>     >>> >>> This document describes features listed in the 'default.ini', so we >>> shouldn't have above. >>> >>> And I don't think RSS hash algorithm update is a big enough feature to >>> list in the feature list, perhaps it can be embedded in the RSS support >>> block, what do you think? >> Yes it is not a bit feature. >> so put it to RSS hash, right? >> > > Yes please. >