* [dpdk-dev] [PATCH] igb: fix Tx queue number
@ 2017-11-29 2:50 zhouyangchao
2017-12-19 7:18 ` Zhang, Helin
2017-12-19 12:22 ` Dai, Wei
0 siblings, 2 replies; 4+ messages in thread
From: zhouyangchao @ 2017-11-29 2:50 UTC (permalink / raw)
To: dev; +Cc: wenzhuo.lu
Internal variable containing the number of TX queues for a device,
was being incorrectly assigned the number of RX queues, instead of TX.
Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific drivers")
Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
---
drivers/net/e1000/igb_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index fdc139f..a600fba 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -1212,7 +1212,7 @@ igb_check_mq_mode(struct rte_eth_dev *dev)
enum rte_eth_rx_mq_mode rx_mq_mode = dev->data->dev_conf.rxmode.mq_mode;
enum rte_eth_tx_mq_mode tx_mq_mode = dev->data->dev_conf.txmode.mq_mode;
uint16_t nb_rx_q = dev->data->nb_rx_queues;
- uint16_t nb_tx_q = dev->data->nb_rx_queues;
+ uint16_t nb_tx_q = dev->data->nb_tx_queues;
if ((rx_mq_mode & ETH_MQ_RX_DCB_FLAG) ||
tx_mq_mode == ETH_MQ_TX_DCB ||
--
2.9.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] igb: fix Tx queue number
2017-11-29 2:50 [dpdk-dev] [PATCH] igb: fix Tx queue number zhouyangchao
@ 2017-12-19 7:18 ` Zhang, Helin
2017-12-19 12:22 ` Dai, Wei
1 sibling, 0 replies; 4+ messages in thread
From: Zhang, Helin @ 2017-12-19 7:18 UTC (permalink / raw)
To: zhouyangchao, dev; +Cc: Lu, Wenzhuo
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhouyangchao
> Sent: Wednesday, November 29, 2017 10:50 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: [dpdk-dev] [PATCH] igb: fix Tx queue number
Basically please follow the style of 'net/igb:', thanks!
/Helin
>
> Internal variable containing the number of TX queues for a device, was being
> incorrectly assigned the number of RX queues, instead of TX.
>
> Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific
> drivers")
>
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
> drivers/net/e1000/igb_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index fdc139f..a600fba 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -1212,7 +1212,7 @@ igb_check_mq_mode(struct rte_eth_dev *dev)
> enum rte_eth_rx_mq_mode rx_mq_mode = dev->data-
> >dev_conf.rxmode.mq_mode;
> enum rte_eth_tx_mq_mode tx_mq_mode = dev->data-
> >dev_conf.txmode.mq_mode;
> uint16_t nb_rx_q = dev->data->nb_rx_queues;
> - uint16_t nb_tx_q = dev->data->nb_rx_queues;
> + uint16_t nb_tx_q = dev->data->nb_tx_queues;
>
> if ((rx_mq_mode & ETH_MQ_RX_DCB_FLAG) ||
> tx_mq_mode == ETH_MQ_TX_DCB ||
> --
> 2.9.0.windows.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] igb: fix Tx queue number
2017-11-29 2:50 [dpdk-dev] [PATCH] igb: fix Tx queue number zhouyangchao
2017-12-19 7:18 ` Zhang, Helin
@ 2017-12-19 12:22 ` Dai, Wei
2017-12-20 6:26 ` Zhang, Helin
1 sibling, 1 reply; 4+ messages in thread
From: Dai, Wei @ 2017-12-19 12:22 UTC (permalink / raw)
To: zhouyangchao, dev; +Cc: Lu, Wenzhuo
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhouyangchao
> Sent: Wednesday, November 29, 2017 10:50 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: [dpdk-dev] [PATCH] igb: fix Tx queue number
>
> Internal variable containing the number of TX queues for a device, was being
> incorrectly assigned the number of RX queues, instead of TX.
>
> Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific
> drivers")
>
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
Acked-by: Wei Dai <wei.dai@intel.com>
> ---
> drivers/net/e1000/igb_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c
> b/drivers/net/e1000/igb_ethdev.c index fdc139f..a600fba 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -1212,7 +1212,7 @@ igb_check_mq_mode(struct rte_eth_dev *dev)
> enum rte_eth_rx_mq_mode rx_mq_mode =
> dev->data->dev_conf.rxmode.mq_mode;
> enum rte_eth_tx_mq_mode tx_mq_mode =
> dev->data->dev_conf.txmode.mq_mode;
> uint16_t nb_rx_q = dev->data->nb_rx_queues;
> - uint16_t nb_tx_q = dev->data->nb_rx_queues;
> + uint16_t nb_tx_q = dev->data->nb_tx_queues;
>
> if ((rx_mq_mode & ETH_MQ_RX_DCB_FLAG) ||
> tx_mq_mode == ETH_MQ_TX_DCB ||
> --
> 2.9.0.windows.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] igb: fix Tx queue number
2017-12-19 12:22 ` Dai, Wei
@ 2017-12-20 6:26 ` Zhang, Helin
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Helin @ 2017-12-20 6:26 UTC (permalink / raw)
To: Dai, Wei, zhouyangchao, dev; +Cc: Lu, Wenzhuo
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dai, Wei
> Sent: Tuesday, December 19, 2017 8:22 PM
> To: zhouyangchao; dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: Re: [dpdk-dev] [PATCH] igb: fix Tx queue number
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhouyangchao
> > Sent: Wednesday, November 29, 2017 10:50 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> > Subject: [dpdk-dev] [PATCH] igb: fix Tx queue number
> >
> > Internal variable containing the number of TX queues for a device, was
> > being incorrectly assigned the number of RX queues, instead of TX.
> >
> > Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to
> > specific
> > drivers")
> >
> > Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> Acked-by: Wei Dai <wei.dai@intel.com>
Applied to next-net-intel with minor format fix. Thanks! /Helin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-20 6:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 2:50 [dpdk-dev] [PATCH] igb: fix Tx queue number zhouyangchao
2017-12-19 7:18 ` Zhang, Helin
2017-12-19 12:22 ` Dai, Wei
2017-12-20 6:26 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).