From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4E18A0032; Fri, 1 Oct 2021 11:06:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 519BE4067A; Fri, 1 Oct 2021 11:06:49 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id DA99A40040 for ; Fri, 1 Oct 2021 11:06:47 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 38EF27F6BC; Fri, 1 Oct 2021 12:06:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 38EF27F6BC DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1633079207; bh=hOx9Y9L7MhG77B5FBvWaGAniOc3GeSb5lmSmKLUez0g=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=IoWSLHXlkFYfdMksIeeAPaxfEgN5ocxULCGrnxjj4MBRVkjF1ljNosIGioWx4tsm8 AMuOGaEsRtxCUE/wJHH8K8Uiz2h3gI8qB9FQA0xGAFhJC6+rWt4oT7hoe2xAJh0rh+ dcw6Nj22/zoVuuRA0nZHB2McPpQx1AgI6ES78h1c= To: Ferruh Yigit , Igor Russkikh , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Viacheslav Ovsiienko , Liron Himi , Stephen Hemminger , Long Li , Jerin Jacob , Devendra Singh Rawat , Jiawen Wu , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang , Thomas Monjalon Cc: dev@dpdk.org References: <20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru> <20210930160527.962319-1-andrew.rybchenko@oktetlabs.ru> <20210930160527.962319-5-andrew.rybchenko@oktetlabs.ru> <7a9a3257-3c7d-555a-7610-5ac3e9c2f177@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Fri, 1 Oct 2021 12:06:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <7a9a3257-3c7d-555a-7610-5ac3e9c2f177@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 5/5] ethdev: merge driver ops to get all xstats names and by ID X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/30/21 7:47 PM, Ferruh Yigit wrote: > On 9/30/2021 5:05 PM, Andrew Rybchenko wrote: >> All xstats names may be retrieved passing NULL ids. >> >> If a driver does not support getting names by IDs, the callback should >> return -ENOTSUP on attempt to use it. If so, the request is handled >> on ethdev layer by getting all names and filtering out requested only. >> > > Since '-ENOTSUP' has special meaning (request ethdev layer fallback), I think it > would be good to explicitly document this in the dev_ops comment. Yes, good idea. Done in v9. > >> Signed-off-by: Andrew Rybchenko