From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74D2FA0547; Fri, 28 May 2021 03:07:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0169940143; Fri, 28 May 2021 03:07:08 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 54F1240040 for ; Fri, 28 May 2021 03:07:06 +0200 (CEST) IronPort-SDR: 9GpX7Adl6crk6f//LPtaeOzMz0lPGLdmzBZf7qHFOQCEhnE9Qr/XovVRo6q9FRFGAppM4vvVrC wJZaOWaYL1JA== X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="288461582" X-IronPort-AV: E=Sophos;i="5.83,228,1616482800"; d="scan'208";a="288461582" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 18:07:05 -0700 IronPort-SDR: /PUIJ+derp6uOVV8na1qpCPwZN2dc6dgwv7sDO8VMGd0T0hwyhX2pDn9L7Lkl0bYGTCgEX77qv N4VS13ZWe7tQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,228,1616482800"; d="scan'208";a="477725560" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 27 May 2021 18:07:04 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 27 May 2021 18:07:03 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 28 May 2021 09:07:01 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.008; Fri, 28 May 2021 09:07:01 +0800 From: "Liu, Yong" To: "Burakov, Anatoly" , "dev@dpdk.org" , "McDaniel, Timothy" , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "Zhang, Qi Z" , "Wang, Haiyue" , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , "Richardson, Bruce" , "Ananyev, Konstantin" , "Li, Miao" CC: "Loftus, Ciara" Thread-Topic: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor check Thread-Index: AQHXRnr4qj89uFd6hEWiFDG5S/0lVarz+9TggALjVYCAAU4XMA== Date: Fri, 28 May 2021 01:07:01 +0000 Message-ID: References: <819ef1ace187365a615d3383e54579e3d9fb216e.1620747068.git.anatoly.burakov@intel.com> <4b05f3b389e04e098ab298f49b97d6a2@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Burakov, Anatoly > Sent: Thursday, May 27, 2021 9:07 PM > To: Liu, Yong ; dev@dpdk.org; McDaniel, Timothy > ; Xing, Beilei ; Wu, > Jingjing ; Yang, Qiming ; > Zhang, Qi Z ; Wang, Haiyue > ; Matan Azrad ; Shahaf > Shuler ; Viacheslav Ovsiienko > ; Richardson, Bruce > ; Ananyev, Konstantin > > Cc: Loftus, Ciara > Subject: Re: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor > check >=20 > On 25-May-21 10:15 AM, Liu, Yong wrote: > > > > > >> -----Original Message----- > >> From: dev On Behalf Of Anatoly Burakov > >> Sent: Tuesday, May 11, 2021 11:32 PM > >> To: dev@dpdk.org; McDaniel, Timothy ; > Xing, > >> Beilei ; Wu, Jingjing ; = Yang, > >> Qiming ; Zhang, Qi Z ; > >> Wang, Haiyue ; Matan Azrad > >> ; Shahaf Shuler ; Viacheslav > >> Ovsiienko ; Richardson, Bruce > >> ; Ananyev, Konstantin > >> > >> Cc: Loftus, Ciara > >> Subject: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor che= ck > >> > >> Previously, the semantics of power monitor were such that we were > >> checking current value against the expected value, and if they matched= , > >> then the sleep was aborted. This is somewhat inflexible, because it on= ly > >> allowed us to check for a specific value. > >> > >> We can reverse the check, and instead have monitor sleep to be aborted > >> if the expected value *doesn't* match what's in memory. This allows us > >> to both implement all currently implemented driver code, as well as > >> support more use cases which don't easily map to previous semantics > >> (such as waiting on writes to AF_XDP counter value). > >> > > > > Hi Anatoly, > > In virtio spec, packed formatted descriptor utilizes two bits for repre= senting > the status. One bit for available status, one bit for used status. > > For checking the status more precisely, it is need to check value again= st the > expected value. > > The monitor function in virtio datapath still can work with new semanti= cs, > but it may lead to some useless io call. > > Base on that, I'd like to keep previous semantics. > > > > Regards, > > Marvin > > >=20 > Thanks for your feedback! Would making this an option make things > better? Because we need the inverted semantics for AF_XDP, it can't work > without it. So, we either invert all of them, or we have an option to do > regular or inverted check on a per-condition basis. Would that work? >=20 That will be great if we can select the check type based on input parameter= . Just in virtio datapath, we need both inverted and original semantics for d= ifferent ring formats.=20 Regards, Marvin >=20 > -- > Thanks, > Anatoly