From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.hunt@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 63CFB388F
 for <dev@dpdk.org>; Thu, 19 Jan 2017 13:11:05 +0100 (CET)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga102.jf.intel.com with ESMTP; 19 Jan 2017 04:11:04 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,253,1477983600"; d="scan'208";a="54838946"
Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.69])
 ([10.237.221.69])
 by orsmga005.jf.intel.com with ESMTP; 19 Jan 2017 04:11:03 -0800
To: Bruce Richardson <bruce.richardson@intel.com>
References: <1482381428-148094-2-git-send-email-david.hunt@intel.com>
 <1483948248-91364-1-git-send-email-david.hunt@intel.com>
 <1483948248-91364-3-git-send-email-david.hunt@intel.com>
 <20170116164008.GB26296@bricha3-MOBL3.ger.corp.intel.com>
Cc: dev@dpdk.org
From: "Hunt, David" <david.hunt@intel.com>
Message-ID: <d40feb7a-b891-080e-195b-d6c58883572d@intel.com>
Date: Thu, 19 Jan 2017 12:11:02 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <20170116164008.GB26296@bricha3-MOBL3.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 2/6] lib: add distributor vector flow
	matching
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jan 2017 12:11:06 -0000


On 16/1/2017 4:40 PM, Bruce Richardson wrote:
> On Mon, Jan 09, 2017 at 07:50:44AM +0000, David Hunt wrote:
>> --- a/lib/librte_distributor/rte_distributor_burst.c
>> +++ b/lib/librte_distributor/rte_distributor_burst.c
>> @@ -352,6 +352,9 @@ rte_distributor_process_burst(struct rte_distributor_burst *d,
>>   		}
>>   
>>   		switch (d->dist_match_fn) {
>> +		case RTE_DIST_MATCH_VECTOR:
>> +			find_match_vec(d, &flows[0], &matches[0]);
>> +			break;
>>   		default:
>>   			find_match_scalar(d, &flows[0], &matches[0]);
>>   		}
> Will link not fail on non-x86 platforms due to find_match_vec not having
> any implementation on those platforms?
>
> /Bruce

I've added a fallback find_match_vec in rte_distributor_match_generic.c 
that calls find_match_scalar.

Rgds,
Dave.