From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by dpdk.org (Postfix) with ESMTP id D0B175699 for ; Tue, 13 Jun 2017 12:01:34 +0200 (CEST) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 919BAAD78 for ; Tue, 13 Jun 2017 10:01:34 +0000 (UTC) To: Nirmoy Das , dev@dpdk.org References: <20170602163116.4631-1-ndas@suse.de> <197454f5-8435-ed5f-63f5-8b6138e613f3@suse.de> From: Markos Chandras Message-ID: Date: Tue, 13 Jun 2017 13:01:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <197454f5-8435-ed5f-63f5-8b6138e613f3@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] mk: disable new gcc truncation flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jun 2017 10:01:35 -0000 On 06/13/2017 12:18 PM, Nirmoy Das wrote: > > > On 06/12/2017 04:35 PM, Markos Chandras wrote: >> On 06/02/2017 07:38 PM, Markos Chandras wrote: >>> On 06/02/2017 05:31 PM, Nirmoy Das wrote: >>>> disable truncation check to ignore below warning >>>> dpdk/x86_64-native-linuxapp-gcc-default/build/lib/librte_eal/linuxapp/kni/igb_main.c:2476:30: error: '%d' directive output may be truncated writing between 1 and 5 bytes into a region of size between 0 and 11 [-Werror=format-truncation=] >>>> >>>> Signed-off-by: Nirmoy Das >>>> --- >>> I haven't check the code but is this a bogus warning or a real one? If >>> it's bogus then could you explain why in the commit message so we do not >>> bring it back in the future? If it's a real problem, then perhaps worth >>> fixing it instead of masking it? >>> >> Actually this should have already been fixed in the series posted in >> http://dpdk.org/ml/archives/dev/2017-May/065261.html > I see the issue in master with CONFIG_RTE_KNI_KMOD_ETHTOOL=y > Yeah I think you are right. This doesn't seem to have been fixed yet. In the end, I think your patch is good so: Reviewed-by: Markos Chandras -- markos SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg