From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74D1DA034C; Thu, 28 Apr 2022 11:28:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1729C40E50; Thu, 28 Apr 2022 11:28:01 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2042.outbound.protection.outlook.com [40.107.96.42]) by mails.dpdk.org (Postfix) with ESMTP id 8DA274013F for ; Thu, 28 Apr 2022 11:27:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UlgjdsBqc0GnMxGKGxcKNqzQUAFLv12m826hFVlCkQgSImJP9gKB8ihYLksaQBaSiHAfPQ9dmsdbdFN+/7CDTNsZcnv9SPw6lta+Eam5kH9NCtBthQGNbyIhm50i1uPTSlIANeXvyBAhjKw5TpNolHRi4xXCSydD7YAGUUbA7/BKdQFp0xlxRHV/oCnkOUl/IB1/n6r0bm7MLzwUWmy7gW3lXigvx7SXXPZOGn/pay3ojGNXANlFVUs0o/EjwMC9VtwlLt2V23aELjLUqkPruM6/L2oeDBHvIjHm/xqRE42WXonQUXZ0/vDJC+q0JQUhIh84p+kdQQecbiUbcAwBhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jHSEGVkhNP8I8IbIRhDUY2WNHbrgOBbtmsKYOadnoAw=; b=KBNLZC8OZcxhWUuQeO8uHC0iNsmXgSrVjOs/JQdq3d/A5VkholMpL3mpxGi8UnymlOtgeAGWW3jaGJOXnYdMqPT0ffvUBRO5uk++ovnIHmtQvjxkaUwqlGsXXNcnhgVjQorTPMSTX7czxNudKsyQIeUZl7GK1+umxV0anu9M2I4D6wagCCkKeO2C5m2h1+nN8tRJSepxnDcAVzncLsgpEERi/iwyQ+uteFL+mM4HaBIYXJt/k9PjcVrmUXB+I/d/jiWX/mbvN0JMhL0QL5CFB7JXm5o693mo+65VI0efzdBcRPW1pRovUv51JP9EkhnSrThLNeyXdJdREn1be2BFsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=163.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jHSEGVkhNP8I8IbIRhDUY2WNHbrgOBbtmsKYOadnoAw=; b=ZXaQJszdHFAyB70GLKY+CC8OaQ8NbwuaprXrEbgEk/AWt4UmDukdxql+oCYgqFQUZ3XzNMdwazhVqix3o0YmD48dyilG5SBCR5UT00hJJsXLVkBZE2tBb1rHLmDfuKGbXQGlBrXcArdRRFMU9Nio0GYkWws8fHKRG2uO5Iz7aHI= Received: from SN7PR04CA0187.namprd04.prod.outlook.com (2603:10b6:806:126::12) by SN6PR02MB4814.namprd02.prod.outlook.com (2603:10b6:805:90::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 28 Apr 2022 09:27:57 +0000 Received: from SN1NAM02FT0030.eop-nam02.prod.protection.outlook.com (2603:10b6:806:126:cafe::2) by SN7PR04CA0187.outlook.office365.com (2603:10b6:806:126::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend Transport; Thu, 28 Apr 2022 09:27:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0030.mail.protection.outlook.com (10.97.5.194) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Thu, 28 Apr 2022 09:27:57 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 28 Apr 2022 10:27:55 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 28 Apr 2022 10:27:55 +0100 Envelope-to: zhangxing_neurs@163.com, qi.z.zhang@intel.com, beilei.xing@intel.com, chas3@att.com, shougangx.wang@intel.com, dev@dpdk.org Received: from [172.21.34.28] (port=58662) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nk0RH-0002Ab-Cb; Thu, 28 Apr 2022 10:27:55 +0100 Message-ID: Date: Thu, 28 Apr 2022 10:27:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: know more about the LLDP agent Content-Language: en-US To: xing zhang , Qi Z Zhang , Beilei Xing CC: , , References: <5269b69d.511a.1806f2e93f0.Coremail.zhangxing_neurs@163.com> From: Ferruh Yigit In-Reply-To: <5269b69d.511a.1806f2e93f0.Coremail.zhangxing_neurs@163.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55d35cd0-eaf5-4928-509c-08da28f9617c X-MS-TrafficTypeDiagnostic: SN6PR02MB4814:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b37WwGILzEHQ3XPEfayNYf6Gzilw/9bywRSrdqVWArlmNWnRxUxCl8/Z0dK6OweZGmlH/+Uqp5T7SDfYBTyINA19iZml4YRHUyCq2kcVPAC9hwE2MP/l+aSqQ4/xFG5y9X7q1h1qXKvgBYmwBESuIaiva6CpTZHKJDZ9AErVaza7BYuziQQRJVtQ2yL27VYF5ZndtQXRlS6ejuuhfuLgCz8cU/E3I0ml2QI0oTc+erNMEbkW9dKrf3k8eki5aCb+4/Xcem1fW9hHUBcug+7riMt1q0zW9yGvH3B+GLCpd4nL+R7+GpawJs4P6stFfjRlrnAKQf5YELNE0U8VNuQnmD/PKIqvJ9lyQD7kBL7E6ON2aMYgoYOOfpX9n8GFC1F23qRkGXv0SQTu4+ZdgupldGQrALfcGaFe3NM0wEgoTZ+RpHZj3g/axfgeguZ1rb6IUZRr4UMy8c2Onj4DN7GSNQxC0wi/AbQdrZKZGPg6KuaXslU36Ft/YWLstJVPhhInzM41c13pUMYIUEZYcqwz2LaF3vVCVp6NwM/5zw6g/FCAXb/5JWSDt4V/3pyIO1oinYz5mJEIt73Wbxg+RwAbflu8Ay4i8GNeEe1O0opEwrFfow1HrTNdPh9CPBG3523LBqP98JELDUw+JzgCdA3z6LjluebTwdIwOrEFKN9sHjrtU0Kf4n1GAlpH4ZWQ2S8ZTR3Z905JpqMYI7qmhtyR3G6GhGduL37aakfLmvlzlwD9P4QtjkFbD9Bv+DUqZDqNLPGauA9ZjcaUnYklgZBA2q+Hc0u7qcq8fWEis/+caBxN8mVeT+xhTbir3H856sv0 X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(40460700003)(36756003)(54906003)(2906002)(7636003)(5660300002)(82310400005)(356005)(47076005)(336012)(426003)(316002)(44832011)(110136005)(2616005)(36860700001)(31686004)(4744005)(8676002)(70206006)(4326008)(70586007)(186003)(26005)(53546011)(9786002)(31696002)(83380400001)(8936002)(966005)(508600001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 09:27:57.1038 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55d35cd0-eaf5-4928-509c-08da28f9617c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0030.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB4814 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/28/2022 8:59 AM, xing zhang wrote: > Dear: >     I am writting to want to know more about the below two patches. > >     I see the first patch that stopping the LLDP agent is to avoid > diagnostic:  default dcb config fails. err = -53, aq_err = 1. So stop > the LLDP agent before we attempt to call i40e_set_dcb_config. > > https://git.dpdk.org/dpdk/commit/?id=044846f071cc5ca78165360f5788036d09758820 > > >     But, the latest patch stop LLDP agent after we attempt to call > i40e_set_dcb_config. > https://git.dpdk.org/dpdk/commit/?id=b1eca6cc8573d162462f240641e43c88255f54a6 > > > >     I think there is a contradiction between the two patches. So what > is the role of stop lldp agent? If I delete it, what will be the impact? > > Look forward to your reply. > Hi Xing, I don't have the answer. Cc'ing Qi and i40e maintainers who can answer better.