From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5CA345B7C; Mon, 28 Oct 2024 13:51:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81A62402A3; Mon, 28 Oct 2024 13:51:59 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 0945D400D7 for ; Mon, 28 Oct 2024 13:51:56 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XcYC44NpTz1jvph; Mon, 28 Oct 2024 20:50:24 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 1FED414010C; Mon, 28 Oct 2024 20:51:54 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 28 Oct 2024 20:51:53 +0800 Message-ID: Date: Mon, 28 Oct 2024 20:51:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/6] Reduce scope address-of-packed-member warning To: Bruce Richardson , CC: References: <20241017142214.1669370-1-bruce.richardson@intel.com> <20241025165020.1856733-1-bruce.richardson@intel.com> Content-Language: en-US From: fengchengwen In-Reply-To: <20241025165020.1856733-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org LGTM Series-acked-by: Chengwen Feng On 2024/10/26 0:50, Bruce Richardson wrote: > The warning for address-of-packed-member was being disabled globally in > DPDK. While for drivers which need to access hardware-defined > data-structures the use of packed may make sense, for normal libs and > applications the use of packed data should be generally avoided. > > This patchset initially applies some fixes for cases where we are > unnecessarily causing the warning to trigger. Thereafter the 6th patch > removes the global enabling of the warning and replaces it with more > selective disabling for drivers and for a couple of other components > which have not yet been fixed. > > v2: > * rebase on latest main (rte_ip.h -> rte_ip4.h) > * remove unnecessary 0-check in IP checksum calc > > Bruce Richardson (6): > ip_frag: remove use of unaligned variable > efd: remove unnecessary packed attributes > bus/ifpga: remove packed attribute > pipeline: remove packed attribute > net: add smaller IPv4 cksum function for simple cases > build: limit scope of packed member warning disabling > > app/test-eventdev/test_pipeline_common.c | 25 +----------- > app/test-pmd/icmpecho.c | 23 +---------- > app/test-pmd/txonly.c | 22 +---------- > app/test/packet_burst_generator.c | 49 +----------------------- > app/test/test_reassembly_perf.c | 29 +------------- > config/meson.build | 1 - > drivers/bus/ifpga/bus_ifpga_driver.h | 2 +- > drivers/meson.build | 9 +++-- > examples/ipsec-secgw/meson.build | 6 +++ > lib/efd/rte_efd.c | 4 +- > lib/ip_frag/rte_ipv4_reassembly.c | 4 +- > lib/net/rte_ip4.h | 32 ++++++++++++++++ > lib/pipeline/rte_table_action.c | 2 +- > lib/vhost/meson.build | 5 ++- > 14 files changed, 59 insertions(+), 154 deletions(-) > > -- > 2.43.0 >