From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>, Ori Kam <orika@nvidia.com>,
Alexander Kozyrev <akozyrev@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] app/testpmd: fix async flow create failure handling
Date: Fri, 1 Mar 2024 11:55:52 +0000 [thread overview]
Message-ID: <d44947a2-5c16-4201-9864-842dfa38351d@amd.com> (raw)
In-Reply-To: <20240228185707.186522-1-dsosnowski@nvidia.com>
On 2/28/2024 6:57 PM, Dariusz Sosnowski wrote:
> In case of an error when an asynchronous flow create operation was
> enqueued, test-pmd attempted to enqueue a flow destroy operation
> of that flow rule.
> However, this was incorrect because:
>
> - Flow rule index was used to enqueue a flow destroy operation.
> This flow rule index was not yet initialized, so flow rule number 0
> was always destroyed as a result.
> - Since rte_flow_async_create() does not return a handle on error,
> then there is no flow rule to destroy.
>
> test-pmd only needs to free internal memory allocated for
> storing a flow rule. Any flow destroy operation is not needed
> in this case.
>
> Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2024-03-01 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 18:57 Dariusz Sosnowski
2024-03-01 11:55 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d44947a2-5c16-4201-9864-842dfa38351d@amd.com \
--to=ferruh.yigit@amd.com \
--cc=akozyrev@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).