From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8FEB43BD1; Fri, 1 Mar 2024 12:56:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B63724026C; Fri, 1 Mar 2024 12:56:00 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id EE841400D5; Fri, 1 Mar 2024 12:55:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MpA6iyKeJflR4Va/Eqo5cILiHmli1MDwa1fm19gdG7XoRCtJyX7y2xRf7STihYHuFXv3IekuoOY/YPFmbOuIvpDuK0VxGr65ZSpZuAWWSBuxBCBYNdCssgOrCuMYD8xtalw95a33L58f4W+JHAZHqtzSGplplGZ2GMj0xN/eoDukQB34uSMxxiRP8X6AwDgJoqUukwZugIqkRje8yTpbIWKwWbz5cmpT/Nrkx4Xujz++fOUpfp9fHJwKTMbUIefxrhhdFT42Vgx2v32a+OooO6Id5rm6/TvPu/YfPjplbvToy4XseDW9N9TeLya1catPSactNHoo9+Ky9pP9ON84Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0jDWbwcloT374QsExeP6jCpo/AWmZCQ29cEy8QrLLfE=; b=AUnUT/4GRBrC5rebU+NKPmifHcJkyxkqIhn+EDGruc4MGICvN/H2/5PMAui1fCLiEXkA6vgE1wKYSnFxT15QbDZZWHGAaPXqfDz+I6QdNXsOiJitJyda4gQasNHGOKZUH7nbSXDRiOEhmjQY2V2/TR7pSOAvUYbItcpdlxslu4mVZd/qlHga7jgeDfjl6x/abfAayhAE6c/LhXvtrmZTYjS2C87PCGDb2Joa3RnNnbGtuEZBaQNJ/5PDUkDm2o61WQBWqh5NKIm7/Ler/x5Q46IOUMdWRxSPjn1/zhp1F99Ilv4e8SyfPWg9Tr2YSUoxNabE0jtlryKXmI/DzXr9oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0jDWbwcloT374QsExeP6jCpo/AWmZCQ29cEy8QrLLfE=; b=gfpWZQs8GxU3/looBFJ4TXDzJjLPsicTvBeaa2/tTxo+n7lWBxbL574B0yhnAPHhjzSE62RogJpjY2LqNeUoaN5k/jkMWpBVLk+Gx3ul4215VDXGEykAnDFkrNsso2e9moFsgFRww8shx4R1vLjpSBLfdj6wqFTiotY5K99LUHc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW6PR12MB7086.namprd12.prod.outlook.com (2603:10b6:303:238::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.32; Fri, 1 Mar 2024 11:55:57 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.039; Fri, 1 Mar 2024 11:55:56 +0000 Message-ID: Date: Fri, 1 Mar 2024 11:55:52 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: fix async flow create failure handling Content-Language: en-US To: Dariusz Sosnowski , Aman Singh , Yuying Zhang , Ori Kam , Alexander Kozyrev Cc: dev@dpdk.org, stable@dpdk.org References: <20240228185707.186522-1-dsosnowski@nvidia.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240228185707.186522-1-dsosnowski@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0059.eurprd04.prod.outlook.com (2603:10a6:10:234::34) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW6PR12MB7086:EE_ X-MS-Office365-Filtering-Correlation-Id: f72a1e49-b688-4459-081d-08dc39e68dd0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3raqcnf6iXZAYnwJSDZ5dcc3A6+rIoUQ+awaf8sgdmAbu9laoSRuiaSE1NzEEsnyxXKWe5xJNyFD6BoTuvfcoTakc9zKL1BgVCEtGjaOyZweyHAh66B/D4NXJ3MfgfVFhR+wRavPmuUcr4qm9fO6lNX+TIVMQ2qC2JMJPu5xAH30vp3Poy1omNcLtnDPQ94vKpMHjIYOI0EhzNYdFYT7HKnqdDR8j1VLwTH3grSqCv7wQMgMq6O27d4TzMtJcAshKr9hRWUrxhDqNIMvv2d1uSfG7/3w1ZLYBdsFnQks683zxTKsCqPpfHcG8ZXmj6yw4EJKR9H9vbyj2SX4Sz9AfjU+BqXvIGEzfzF4B/ORYKOnDCWs7NqLAHQ25mTS2AgpVYE/N/PxLmkA4nroBu6pe41uur+TuQ47JJUzIrJMT2qLbl0Hld6QCKOaFYXLlKSddTBKn3O588Llu+/kHyTMHTrz759BRxJavxrK8ydQZhd5feOrM7SCTxew5Xmo55lwVbao/A7qF9CIK+CndyurewL7owSo3TPvp2hspdymZBj/2j9iOrHu2guaa5zFA3pzV24nPn+ujxKq+GkwZz2i5wQC8RcwSm9bhsCDrBDysU2KY0A7XcXlBPfzP74qZYtJ487DgsTAc31GLycZApDwvw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3BpZFJkcGs1ZXZWNnRDRGZ0WXpoSXlraStHS3d4UmRtUnRidGEvbWUwNnBn?= =?utf-8?B?cVR6NnVZUVQzU21hZWlDWlc4ekU1L0NUVEU3SDVTeDFkYzEvWXp1TFFKYmxO?= =?utf-8?B?blZOeGZkYllzM0dGakpOZXdzUWo1ZitUNUR5aXptSlFHcGgzTngxbUd5ZWww?= =?utf-8?B?aVV4UFpiQ2gwcXRwSk83dFYxakxjaUhCS2NqVlBKejc0Uy9SQy8wZytqb2Rr?= =?utf-8?B?dndrSTlvYnk3Rzc5SWZyUlVYcnFhYVUxbzNWdk5rZ1JmQTU1R2M4OVJBM0dL?= =?utf-8?B?S2trV1RZQUJIeVVpcnlrTExsa2JjYnNxcDEreEx5MnJNOU9tZmRxUGpGYnFD?= =?utf-8?B?dXZpZFBwazk5NXA3VmM4MC9HQVdUbE1lTlljamduUS9sSk84MktCTlh6cFl2?= =?utf-8?B?YjFxR2xidUNHenpQbEhlcnRFNjM5Rkh5N1RRY01xNHpHcEVYYnpSdjJteFBI?= =?utf-8?B?R2FxL0Y0MFhKb2lrOEdPa0I3a0UwMSs2NDBXQUVQSHA5QzhqaGJsVlB3eERT?= =?utf-8?B?UVNZUkpLd0xQRFFUSzV1VFRSVHpmUjVucHRweTF2czJtK1ZjQlN5ZmorM3dk?= =?utf-8?B?WkJ2aklreStQRUI4OERiU29xNVVRWHNtQmdtSlhtdnZPUUgzQmRaNnJOYm9J?= =?utf-8?B?K1dtTktLU055TFlxQzFDZnNzTHQ2bmduNWhlQ0NsTFFjMEc2ZGxWdTBFTXBi?= =?utf-8?B?eFJhalU0TVNweWpoc2lXK2dGbkUzdlZhdC9ab1VxTERYQ01XMExPYnVORi9q?= =?utf-8?B?T2MzTElMNGhsdURHVGlUTmI1YVVueU02aTRsOVBkZUNNbzhKbTFUQ3hjUGNW?= =?utf-8?B?UXlwTUFHUVVuVW5FZHljN29iSnRUWjBxZU5td0NRUEFXNUJCQjYyOUx6S0Nj?= =?utf-8?B?VTVGbkRUdlRpTFY2TURDYXNhek9vZXA2L3BMRWh3TTNlWHhDNVV6cHMrS2kw?= =?utf-8?B?N0dWYjRYcXVGZ2FOLyt4cTRJN0VxaWx4OEpLVkYwc3ZQU1J0NzBJZFBqem5r?= =?utf-8?B?RUR4OXFKeWRqN2l4TGNVeUl3WTZZOGp3N1N1Z1lpTzFzYnBhRW1WNTllYS9E?= =?utf-8?B?bmtma1dpbkJzWTg1UHdaakJWUCtYWURveFg5QXBnZFNJaVh1ZXpZbnJ4djlV?= =?utf-8?B?aDhPbml4UHFyUHZZZHdLY2pqRHJZcHpiNmZ6TkV0SUJoRThuYnhFVy9Dc2Qw?= =?utf-8?B?YUNQcUVCaWtWMWxxVGhsQ3dYV2FBQVVrekpXaDlidjdxdXkvMEo1K0MxVEhC?= =?utf-8?B?YTM2eDVIR003YitHYTAvK2RLazJwcGFxM3A3SzVSN0JFc2xHeVBqQ2xncFJ4?= =?utf-8?B?TGpCSFRFcVNnZlMraFdBM1d2UGFyeFVGdk0rMkFGVXRuRXlmNFJvNGpaeS8v?= =?utf-8?B?eU5JNE1MaUxtKy96NFhacUVqY2k4cGxHTEdBN2JveWhNbVJ3R3hNVHhjdmpn?= =?utf-8?B?MFg0RFFzQVZpdkVqVTZUd21WTlhsL091WDVrMkxVRnR3bGRjVWZUblA0MDlJ?= =?utf-8?B?MXFpa3JhVGNoOXFkaUtqTWxDT2ZHRHlMNUtlNXRvTDREbGhFUkZmUFgrakJr?= =?utf-8?B?dU1LaWMweTFZaUZscnd5TDllOU42aTVGMHZ2d2NGam1RNlM3cnNqSTBJZjIx?= =?utf-8?B?Vk1JQjAxTVcxZWpsYUxrdXE4cFhkb245RlJESndNOUtYbGE2Vm9Vcyt4Ym1H?= =?utf-8?B?WG04ZDZhYzZmYS9rdG43aDdZZlpsM25EdFd5U3JoaldqbTZnMmorbEZaRVQ0?= =?utf-8?B?UnNtcmtITDZ1bGx4TUtsNGIvY3lmNFlGN1NFczFvc0VHQ1p6VllnSXFZYlkz?= =?utf-8?B?STdDOW0zVXltNHQ3K1BNZ3l5eTIzMXhQVnhWNDVmdzBZZE5vRTc3ekxCbVJD?= =?utf-8?B?Q09la2xGSEM5aWVYTzU0amxiMllyNStlM0VMc3BmVVI0WEtBYXRFd2NTOGJO?= =?utf-8?B?UGVOaDhQRG5Gc3hjYU5ZdHk1T0FleGVnK2hOdDhId1VaZU8zK2ZVcFc3bTl3?= =?utf-8?B?a1dkNzVkVHhHUm84KzJMSk5OYjk2MHdvUnpRN1NBU3ZyQXpIV0w3TFA5bTdH?= =?utf-8?B?b1Z1MCtYZWxmU1BHcWxYVmMyRGl5bU5CTERrVjFmZGpRN3NHYnFUaHRySjFx?= =?utf-8?Q?dSsw439gxLS1/oIDy3MBOmiej?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f72a1e49-b688-4459-081d-08dc39e68dd0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 11:55:56.8717 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iNksMEDtUFBzgir4rrO7DNqJ1TTj9E5DHK07RNN3UUO4cyy/oioGqpYDqg7k3gPA X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7086 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/28/2024 6:57 PM, Dariusz Sosnowski wrote: > In case of an error when an asynchronous flow create operation was > enqueued, test-pmd attempted to enqueue a flow destroy operation > of that flow rule. > However, this was incorrect because: > > - Flow rule index was used to enqueue a flow destroy operation. > This flow rule index was not yet initialized, so flow rule number 0 > was always destroyed as a result. > - Since rte_flow_async_create() does not return a handle on error, > then there is no flow rule to destroy. > > test-pmd only needs to free internal memory allocated for > storing a flow rule. Any flow destroy operation is not needed > in this case. > > Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations") > Cc: stable@dpdk.org > > Signed-off-by: Dariusz Sosnowski > Acked-by: Ori Kam > Applied to dpdk-next-net/main, thanks.