From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7109A00C4; Fri, 7 Oct 2022 19:28:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F21540151; Fri, 7 Oct 2022 19:28:18 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2072.outbound.protection.outlook.com [40.107.212.72]) by mails.dpdk.org (Postfix) with ESMTP id 29A6840042 for ; Fri, 7 Oct 2022 19:28:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jmDa9+wwb8BPzqY5aup00q3d765jw2Xo3ouJyVmjxW6T7oWz/TqV6rxDAZJYCtc+VQQkctd7ZypkY2Kd5ViiZa7MDkeYgHKb3WBUW8IPq+FKvHcDF4x2NbeWadcWd2UWbuSj37y44c0uORoPoJPD34SQ9uof+owVWzgtXIuJ+WH0FsFNLa86h81SWsvhrqxygFZqQ16dYuAiNJJVEuMIuRcBcQ7hj9HaT8T1EoQMBcaOhGhYc6GmIy5r6WJUd5LOfKwoU0TZ0boSfuYM+mzQhbwMHoxa911BNnme7KXoimA1Q4ThTFS9b6cJXn2OFigM/4xk8HESLtW8OLBLd8jTnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GKEd4p5Zpi+fctQ9MhIE5/dMTG3IXOz0yBvIDMQlgWY=; b=KuPlTC6IPZGJA15maVz90zSISUKPH4X9T+0VKMAxc3zAMdrX8M+yGCSFLImn7aCPd3Rgk8UvHiQN30BTiLYZt7aH2zIwK/sxlZWE8cCkvYKjrd2cBhTFUJvTS/nHuNU4EzFvSv7HGXUTuR35gDORLwa7MXkeOLsr16E66SrHKwyFEG/PwX1+6cL6urXdhJgDi/dE5Z1mUZP7ghGhGRQaLz727W5uaMRi9AjDVAezrdncC+tllRPuxFyYv+4NV3IAuiqaaGsr5w4GYePVJn8pjn4/LmgPHRce5xhrpqvJ4zeTS6oJs+avJrYsp9amSKpM1iQ04TFOHpF6RKJcuZ2EQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GKEd4p5Zpi+fctQ9MhIE5/dMTG3IXOz0yBvIDMQlgWY=; b=EC1Mcaw40OhLUiqqk4XloPOZWBKfUjneS6MQ5DCHiAq5Ds7CtgTzw98xQW7lPx7WtinahCYUkecCHX9z94YiPO0FDCRNP2g+Z/jmUERfgkaaNcL+QgFzTe+YQkgQctf2HZh8kDySjoO4Nk8EZlDaYFh3v0vKAqybfPE0tK6uyhE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DM6PR12MB4514.namprd12.prod.outlook.com (2603:10b6:5:2a7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Fri, 7 Oct 2022 17:28:14 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%6]) with mapi id 15.20.5676.036; Fri, 7 Oct 2022 17:28:14 +0000 Message-ID: Date: Fri, 7 Oct 2022 18:28:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v4 6/6] net/af_xdp: make compatible with libbpf v0.8.0 Content-Language: en-US From: Ferruh Yigit To: Andrew Rybchenko , Ciara Loftus , Qi Zhang Cc: dev@dpdk.org, Bruce Richardson References: <20220624102354.1516606-1-ciara.loftus@intel.com> <20221006062654.1420349-1-andrew.rybchenko@oktetlabs.ru> <20221006062654.1420349-7-andrew.rybchenko@oktetlabs.ru> <983cf017-bb4d-0bd9-abb4-d3dcacab03ca@amd.com> In-Reply-To: <983cf017-bb4d-0bd9-abb4-d3dcacab03ca@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0281.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::29) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|DM6PR12MB4514:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b8f5e22-2b95-4514-b1d6-08daa889508b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lKdNiyMazvmtwPmsM4230US0TDmcukjQTzpnElvM8sxapxI3wPTcnIPEEw56hgWgZyFUzf/6EZwtmqZhAcjF5lvSZj+5PsYh9Dv2Sqf5guMjvaTTGX1X22jHheJZpZwwSfQ/N4MLAdtxEvUQJA9KHdTHkRXhFcHxNB/8t1og75IVsllNRWflsD7ERBpDSvpqBqKFXECRGu263+e7y4c8fiJf45NLKXQRoSAGoEDf+ZjzlpUOKdQz/Bj570RYxoVzunxcOgvuj30YGKyBI1X1Z4Vr99qgcj4XI1Wj5xS0eiaajewGdY3BuAteiT0Lf6v5SMQb6Bcvk0ZsD0z29dU6yM4izNkcIM9C9vs4rH1NO7lpujPStBsoNMgHgbB1BGDbLSvhn7NKs+Nu9zDPR5Rb+5xvLyHiS59h6sYQRdds9nLJGdph0wOj0zwMHjiJqgp+s3HeC7DolIAJip5z/rFVbHFBONYpz/ZM7PxPzb+rCsNYzICC/m6TaP3mQKpoi2+pICJTpSOOX6tBBUoMGUwiwDir/tAcS8rV+mzRB7CTTxrPFTfhkdxtRMlhFddcl7pIx8DY4b2daYmpts7G6JMRL99C9mb10NPF+DQzUqbViSEql/eml+pf6NyzTvJ+xtVPS3n8PE9jd7zwyD0l3VRHh6HAIFS33OVi6njorrVCVpQIU+CoUuZeSwZM6K8LCXf9As1zRUKw2WUzRpBcCrtHEkLNPSk9DrLSU7VM25znrkvigQq6bCSx2Fettp56yigwl9zD5nCO9YSNywcKxkYkwOGofTCrSX4wdQFg9ZXQh2o= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(366004)(346002)(136003)(396003)(451199015)(31686004)(36756003)(6666004)(66946007)(8676002)(66556008)(4326008)(316002)(110136005)(44832011)(66476007)(6512007)(31696002)(2906002)(8936002)(6486002)(478600001)(86362001)(6506007)(26005)(53546011)(38100700002)(5660300002)(41300700001)(2616005)(83380400001)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0U1MWVMT1JOUzlrZW1KclFmbUhTbG9KSGt4VGxteXJSTFFnRE1RSzdMQy9i?= =?utf-8?B?QnczdjN5Vmk1QVUwVHBxRHVhVFNwdzRjMHN2alAwM3NKbHNlWDROU0U0Qjls?= =?utf-8?B?YXBkU21lbTlWZFVURnFQenlnaTEvZGFydjVCdVBCL2FsdlYrWG5iMkdKRlBy?= =?utf-8?B?RWQ4OU8yUHhqTmoyTGJRY2QzZHJFd0lWOUNJZFpmWlprQXhuUUpNV25ETmsv?= =?utf-8?B?dnd6S2E4VW5pbU9BTnRsM2lSVkxCVjdweTRmNzJvdkk0a0haZmIzYm1ZVE9G?= =?utf-8?B?d3VuTlZvMWVvcFEzSWxTUWhVRzRBYWZWWERNMEVTSHNESHVFMVpMekRSMW16?= =?utf-8?B?Q0lkSHZ2RThKWUY5cUhrTnNzaWpCbFdpRDl0RUVkbjFGVGF5ZDFLVlA4K0h2?= =?utf-8?B?clpnM2dpSG9oL2ZXajZlNmQxdENrTGtFY1llUFRHb29TQ1dEZG1YbHRSYTJC?= =?utf-8?B?UDJQU1FFa2ZNd1pYVCtsRkRyd3FlUVdaRlhhT1YyQWFCWnU3RDJ0SVVkYkds?= =?utf-8?B?dXpUcWxpQ0tuWGZyZUpiZjVTbExEdVM4clVaYlFxRytmSHFHZXo5ejZlWi9N?= =?utf-8?B?Q1dOLzRTMXpFU0VuN2hWTWt2bzFmZkExQjJEUTVaVmwrQUl6YmZzQzZnR01D?= =?utf-8?B?OUt3YUNuZkhHM2NFQlQybGlQMSt6VDVicUxQN3VmaXRpS3Y0YzlacFpuMzVL?= =?utf-8?B?QmFDcWllVmhoTnNnc3VqNlM1L2xnWkYyYU5xb0thRTZIcTV2N2VOWkpuQldY?= =?utf-8?B?OTVaSE1Ba2RUYzFZL2VnUE0rTEZRTGdNS0Ywb3U2TmtncGRWU20wNC9Eays5?= =?utf-8?B?a3JCVmtLWXRJTjFlU2VYZDNSOHFFaGhSRW05bHdDNW9kT0FXbUdFYkh6dFBx?= =?utf-8?B?aU1VNmRWSHRIZkJGUUxjdUdaelFjQnJuaGVYWVVPb2E1UUs1UUtPMldPQm1i?= =?utf-8?B?TW83K2RhaFBkbHBBcXhlSFBsT0JNY1ZwenJQbjJ6c3UzMmdTdXAza3E1YXF4?= =?utf-8?B?ZHdWdEd6NVJFMGRrZG1yV1VMVVdYM1lBd2ZreVllWUdBR0srYVFyT1hoaFVr?= =?utf-8?B?V1UwNHBhLzFmSWoxUWsxR3VFN3NVZGVpNVlvWUZhdG0vazAyaHBZakc0d3dz?= =?utf-8?B?aVo2UDllbzVGbzNLOEN4bHd6UUVSaHJ0MkdKL2xDNXdsZGFKZ0pRcDUwWVkx?= =?utf-8?B?ZWdWaW9tWHZpY0U4ak9wa3ZuZkRHV0RMbEpqWFhyNElMVklKTkhqN21Pa1pS?= =?utf-8?B?RDVqczMxckRFcGFMT01xY0s5OTZOZDVnRGlaOVprSnZvNU9yUjZnV3NWKzh4?= =?utf-8?B?RS9XdXM2emRGSkZLN2x1YnlYYjgzMit0UFM5U2NlbUNiNDFYZ0d4UkJ6cm9t?= =?utf-8?B?TnlTM283V2YzUjcrc1VqQTE1R2V2Y0Y3bUNOcXlEODFKSytpUXVwMEVmWHph?= =?utf-8?B?RVZMOU0rS2dCRUg4YzJ6d0Q0bjhYZWdSRXlzakFvWTRqMzJ3dU5FcTN4OEVE?= =?utf-8?B?MWhScmVRYVNnU1YvR01tOVhKUDU0UUJmZEFmY3R2U29mS0FKVW1EQXFINGVk?= =?utf-8?B?dlFBaWxvemh4YWFTdU1wRytCWnBORmc2WXE5ZWlhVmJJM3lCdDh4RkFodHRD?= =?utf-8?B?OUdWQmg5N0VCY0d5bDJ3YzU5aGkzbkxQSlNUcVpuQWlVM0E3WGQ2MFMvYXps?= =?utf-8?B?dklOSzdBc2ZFc0ZzbVRoMjhZS0JKZjFHZFJ6eFNON1RBcjQ1Ukh0cGJtbEZp?= =?utf-8?B?MVM3eHFKSjdwWlFIM3lFZDlRWkQxb0w0Q29GSWZ0N2FJVVY0NTJFOURMUWZK?= =?utf-8?B?UDJIWS9xdG9sMkRBNXBScDZqOGhnR2Q4aEdkdEMyUHZWb25LNTdTUmlndk5a?= =?utf-8?B?T3hzcGdZSGN0UUhnMHR0djJEU2YzeWNYRDIrb0kwZU11b3hsZlllNXZqL29y?= =?utf-8?B?cSsvTEpBbDJlS3ZTSkJieUIyY0N0THpZVEtwZTJqRTVZZTRSUkt5OURXTlpy?= =?utf-8?B?Q0sxcXpyeWlOdHVtazhDbGVUbnBuMUpQUzVxbExDYlJFUVE5RGlXNmxKOTNk?= =?utf-8?B?bzN0SlJYeC9KOG1tTmZZNGxwYnBxMDdUZzAwdHhsajRaSzdYMkZTK1dTVWt4?= =?utf-8?Q?2+16CMuvJE3ItfYxUNyktjUP7?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b8f5e22-2b95-4514-b1d6-08daa889508b X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 17:28:14.3539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x7ju+9PadX6aepbx2eFcvhf55ofkc4zIl5jXcfML3s+MsQ+CU/WAv13Giktn98c1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4514 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/7/2022 6:19 PM, Ferruh Yigit wrote: > On 10/6/2022 7:26 AM, Andrew Rybchenko wrote: >> From: Ciara Loftus >> >> libbpf v0.8.0 deprecates the bpf_get_link_xdp_id() and >> bpf_set_link_xdp_fd() functions. Use meson to detect if >> bpf_xdp_attach() is available and if so, use the recommended >> replacement functions bpf_xdp_query_id(), bpf_xdp_attach() >> and bpf_xdp_detach(). >> >> Signed-off-by: Ciara Loftus >> Signed-off-by: Andrew Rybchenko > > <...> > >> diff --git a/drivers/net/af_xdp/meson.build >> b/drivers/net/af_xdp/meson.build >> index 9d5ffab96b..858047989e 100644 >> --- a/drivers/net/af_xdp/meson.build >> +++ b/drivers/net/af_xdp/meson.build >> @@ -64,4 +64,9 @@ if build >>                        dependencies : bpf_dep) >>         cflags += ['-DRTE_NET_AF_XDP_LIBBPF_OBJ_OPEN'] >>     endif >> +  if cc.has_function('bpf_xdp_attach', >> +                     prefix : '#include ', >> +                     dependencies : bpf_dep) >> +      cflags += ['-DRTE_NET_AF_XDP_LIBBPF_XDP_ATTACH'] >> +  endif > > meson is not detecting functions, I am getting following log, any idea > what is going wrong: > > Run-time dependency libxdp found: YES 1.2.2 > Run-time dependency libbpf found: YES 0.8.1 > Has header "linux/if_xdp.h" : YES > Has header "xdp/xsk.h" : YES > Has header "bpf/bpf.h" : YES > Checking for function "xsk_socket__create_shared" with dependencies > libxdp, libbpf: NO > Checking for function "bpf_object__next_program" with dependency libbpf: NO > Checking for function "bpf_xdp_attach" with dependency libbpf: NO > It is OK, this was my environment issue, libbpf.so permission was wrong although I compile and installed from source, anyway latest log: Run-time dependency libxdp found: YES 1.2.2 Run-time dependency libbpf found: YES 0.8.1 Has header "linux/if_xdp.h" : YES Has header "xdp/xsk.h" : YES Has header "bpf/bpf.h" : YES Checking for function "xsk_socket__create_shared" with dependencies libxdp, libbpf: YES Checking for function "bpf_object__next_program" with dependency libbpf: YES Checking for function "bpf_xdp_attach" with dependency libbpf: YES