From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id 6B3681B5F8 for ; Fri, 13 Oct 2017 03:16:39 +0200 (CEST) Received: by mail-pf0-f169.google.com with SMTP id b79so7493747pfk.5 for ; Thu, 12 Oct 2017 18:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=NT3za3ws9TKwpxbzkBxG39/kLMXRWMbJJIbJuQR8u8c=; b=tW2SM8HnRZFZX3nqUCotSSIlx4cvMirUAX21207J5TWY+w5JMiO1+PFf+coLG67y+V r/EnwJIYSdCd2lYY/H6xlH56a5uc2D1HkVi8JPDG16Civ20lfht1NGQzf73NmjSx80t+ 2BIGwBMyjlqpSAStxUXcfylXVICZuUW5WLyXV27HklrVTJqkbleotVx5otxVzj/QpAb5 j1Fvw8PaLTkX3QffQPLfw80M9lSc5cLmRJKtV5wW/mXEeSmqQbNu+ky/E9/UL9Z2CU50 mKiJPchhIc0/KDsT9CCmMe43PjQlyJqf3QPXmJXk1HYYdSBG3r8BMdKHK+H20AXEG0ok Wc6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=NT3za3ws9TKwpxbzkBxG39/kLMXRWMbJJIbJuQR8u8c=; b=dK5cs7feRIbn7uHfQQDmvCNNMBf2A/j8tLtQ2P4GG9RYtebbf2dqwUUP4u7Dr5yXVR F04AgPv1xLv2tHX0NiICNOhuyEzjNsbu0MQheeg546HGnU0wUNMovice5au03AZo4qva aIcU6EZ2usGuQ7uuCCnyiNXMIMFBAXBiDW8pC54hNXEyzjREaZbBrTqDaTGt2AA6LLA7 u6SlWBi8pe23glSyc4h7vYr0L4mgJ2NPyb8YvLUPUwax0lGtgGgCisx12x+RtuGOzxtY D0RUeRAiezaLAmo3Nc98htTLJszqQrNe3rdEict/5MjEPPQ1DfEU3Js8FGJakya4bKjq TRsg== X-Gm-Message-State: AMCzsaXVolHDKhiN4HteTq6L2avGPm2wo8qwOR0BygvGN67gk/oVmmSN 4Hx5yjZfZ/I1lCidVIatPd0c6Gft X-Google-Smtp-Source: AOwi7QACKPd13bDNCaRAoelpOCtq2zH0oaeHismaU1nlBZ3zOxMi0tpLSm0mO5kDFs0glVj2+f2K1A== X-Received: by 10.101.74.206 with SMTP id c14mr1648105pgu.190.1507857398484; Thu, 12 Oct 2017 18:16:38 -0700 (PDT) Received: from [0.0.0.0] (67.209.179.165.16clouds.com. [67.209.179.165]) by smtp.gmail.com with ESMTPSA id e3sm27661740pga.80.2017.10.12.18.16.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 18:16:37 -0700 (PDT) From: Jia He To: Jerin Jacob , "Ananyev, Konstantin" Cc: Olivier MATZ , "dev@dpdk.org" , "jia.he@hxt-semitech.com" , "jie2.liu@hxt-semitech.com" , "bing.zhao@hxt-semitech.com" References: <20171010095636.4507-1-hejianet@gmail.com> <20171012155350.j34ddtivxzd27pag@platinum> <2601191342CEEE43887BDE71AB9772585FAA859F@IRSMSX103.ger.corp.intel.com> <20171012172311.GA8524@jerin> Message-ID: Date: Fri, 13 Oct 2017 09:16:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 01:16:39 -0000 Hi On 10/13/2017 9:02 AM, Jia He Wrote: > Hi Jerin > > > On 10/13/2017 1:23 AM, Jerin Jacob Wrote: >> -----Original Message----- >>> Date: Thu, 12 Oct 2017 17:05:50 +0000 >>> [...] >> On the same lines, >> >> Jia He, jie2.liu, bing.zhao, >> >> Is this patch based on code review or do you saw this issue on any of >> the >> arm/ppc target? arm64 will have performance impact with this change. sorry, miss one important information Our platform is an aarch64 server with 46 cpus. If we reduced the involved cpu numbers, the bug occurred less frequently. Yes, mb barrier impact the performance, but correctness is more important, isn't it ;-) Maybe we can  find any other lightweight barrier here? Cheers, Jia > Based on mbuf_autotest, the rte_panic will be invoked in seconds. > > PANIC in test_refcnt_iter(): > (lcore=0, iter=0): after 10s only 61 of 64 mbufs left free > 1: [./test(rte_dump_stack+0x38) [0x58d868]] > Aborted (core dumped) > > Cheers, > Jia >> >> >>> Konstantin >