DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Etelson, Gregory" <getelson@nvidia.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: ferruh.yigit@amd.com, aman.deep.singh@intel.com,
	david.marchand@redhat.com, dev@dpdk.org, dsosnowski@nvidia.com,
	mkashani@nvidia.com,  thomas@monjalon.net,
	yuying.zhang@intel.com
Subject: Re: [PATCH v6] testpmd: add hairpin map parameter
Date: Thu, 31 Oct 2024 07:02:35 +0200 (IST)	[thread overview]
Message-ID: <d495ab1b-99bf-61eb-9c16-9c2ca5f899c8@nvidia.com> (raw)
In-Reply-To: <20241030123735.62156d88@hermes.local>

Hello Stephen,

>
> Did you consider that most of the hairpin_conf values could just be set directly,
> avoiding intermediate variables.
>
fixed.
>
>> +             diag = rte_eth_rx_hairpin_queue_setup
>> +                     (pi, qi, nb_rxd, &hairpin_conf);
>
fixed.


  reply	other threads:[~2024-10-31  5:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19 10:10 [PATCH] testpmd: add hairpin-map parameter Gregory Etelson
2023-09-20 12:22 ` [PATCH v2] " Gregory Etelson
2023-09-28 15:36 ` [PATCH v3] " Gregory Etelson
2023-12-14  8:06   ` Dariusz Sosnowski
2024-03-01 18:54   ` Ferruh Yigit
2024-03-05  3:04     ` Gregory Etelson
2024-09-22  6:50     ` [PATCH v5 1/1] " Gregory Etelson
2024-10-16  8:11       ` Ferruh Yigit
2024-10-28 10:23       ` Gregory Etelson
2024-10-29 21:51       ` Ferruh Yigit
2024-10-29 22:23         ` Stephen Hemminger
2024-10-30  7:37       ` [PATCH v6] testpmd: add hairpin map parameter Gregory Etelson
2024-10-30 19:37         ` Stephen Hemminger
2024-10-31  5:02           ` Etelson, Gregory [this message]
2024-10-31  4:58       ` [PATCH v7] " Gregory Etelson
2024-09-11  5:08   ` [PATCH v4 1/1] testpmd: add hairpin-map parameter Gregory Etelson
2024-09-20 13:48     ` Singh, Aman Deep
2024-09-22  9:33       ` Etelson, Gregory

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d495ab1b-99bf-61eb-9c16-9c2ca5f899c8@nvidia.com \
    --to=getelson@nvidia.com \
    --cc=aman.deep.singh@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dsosnowski@nvidia.com \
    --cc=ferruh.yigit@amd.com \
    --cc=mkashani@nvidia.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).