From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7A9745C1B; Thu, 31 Oct 2024 06:02:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79E8143548; Thu, 31 Oct 2024 06:02:50 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062.outbound.protection.outlook.com [40.107.220.62]) by mails.dpdk.org (Postfix) with ESMTP id 1A401400EF for ; Thu, 31 Oct 2024 06:02:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aZ4NkUuth5NegjEZqFSTqdYkR9RUJMh8SH4huC3kpQBXwDe3UDtWYkpXRQS70764J4vJhoA1cBoxbUJ0dw04d9A4LZVkSPFNmdUqQRUJZqKBpf5ezia2uROwuH1qFaA40srGZmPuUI/8aYbfFPEJIpnTZL5qGH2aJ9dcnxxq+HRp2MF1pE9tToI9GLnAeCIAfMuGqJX/RqTvO9tOUB6csoHyKxSJuBYfgFst09/+rHA5Q1MDHfohSufyJ99BuNK+5/SttM5PMp4fkPQsFqcsdXgBINzID/3Xaqhc7FRDti4tBf91L/Md6QFJuczQo4O9zr80zO9De/plS8MIF0hs/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1kFdag/LxsnqVGII7VO8a7szwYn6oUfO/v7HnJqldaA=; b=pc5nqTdNaCRHTsSgW+wmqKwoEVCcl/vy2yS8XQ7IrGBSsWmn76BmKQ2vczeuwz8KihGkAtljum3HK9tyt/VuNVagvRa0jepbzZZykHnBMBngOV6U4/uB0ez2HqFOIDJSK8tndLK6bNKXWNBtcTN/IKQc/+QOSrxSTT+l5PTqcr6NIhie3qutSAmyXpVRzGq90/E/NTIJvwxkri8UDo7pEz3kBxUdxCkOGKsPbQbFMUE1rBmOifVB1CpGaNjY61bvFLHcGG0XvlySB0yo22kIdgZu9iMly72xCo5d7IQ0M2bfLhaebuXayu7S18421YO6TElCbjV3YRI49zqiU8yvZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1kFdag/LxsnqVGII7VO8a7szwYn6oUfO/v7HnJqldaA=; b=AjaiLDcD3859Cg3yZcf8LuSKx+eFdIfOsfwiqWq30T+hd+FC5uCnwBPSnUOrkkqm7dfLvE9XCJmovZBNQ7ZKcTWUrjsvjYWVKdtvpEQaYvbuBEkKg0ZyUpKflLG9FS1HiowasiS8hR/g9NbDDA2k2zHXRtHm7LAn90W1zQF5EucuCeDuY1LuvU0zY/1IWVtgkQ9TMI+xKrj6+YTQbET8g7ZXB7vdztc0v0vSz+jWuZ19UqByrX5ypEXkyDZIBHfduXvT6ZSl2jmD9fwWK1/EGXW5/Ew7Wm94AAitQcn/YqWew2wR7k7tDzjh0A7Wj8WCx05yltcufEHbVIfw1sWS6A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from PH7PR12MB6811.namprd12.prod.outlook.com (2603:10b6:510:1b5::9) by SN7PR12MB6767.namprd12.prod.outlook.com (2603:10b6:806:269::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.25; Thu, 31 Oct 2024 05:02:44 +0000 Received: from PH7PR12MB6811.namprd12.prod.outlook.com ([fe80::8f8e:db0b:ddfc:a5b8]) by PH7PR12MB6811.namprd12.prod.outlook.com ([fe80::8f8e:db0b:ddfc:a5b8%7]) with mapi id 15.20.8093.027; Thu, 31 Oct 2024 05:02:44 +0000 Date: Thu, 31 Oct 2024 07:02:35 +0200 (IST) From: "Etelson, Gregory" To: Stephen Hemminger cc: ferruh.yigit@amd.com, aman.deep.singh@intel.com, david.marchand@redhat.com, dev@dpdk.org, dsosnowski@nvidia.com, mkashani@nvidia.com, thomas@monjalon.net, yuying.zhang@intel.com Subject: Re: [PATCH v6] testpmd: add hairpin map parameter In-Reply-To: <20241030123735.62156d88@hermes.local> Message-ID: References: <20240922065053.996568-1-getelson@nvidia.com> <20241030073724.103112-1-getelson@nvidia.com> <20241030123735.62156d88@hermes.local> Content-Type: text/plain; charset=US-ASCII; format=flowed X-ClientProxiedBy: TLZP290CA0009.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:9::18) To PH7PR12MB6811.namprd12.prod.outlook.com (2603:10b6:510:1b5::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB6811:EE_|SN7PR12MB6767:EE_ X-MS-Office365-Filtering-Correlation-Id: b1dd40d9-9032-4b5c-82cd-08dcf969412e X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8Qy6lRqnLTioBmlp8suy9sgt9QRDx4Ni1sWIJeiCwR8KiLQLYBzjjzD7fmTP?= =?us-ascii?Q?Jz/tH2IMqOgzo54QajupS8Tjrf33sFzsGwZbSzbPUdSC4KQ46FlbH9yR4OFh?= =?us-ascii?Q?6mU20dy9+qwUCTlrMouudQl2bTxCzZPYs/ZdNhMbxIs2cJBw4cIwSIbS+CGl?= =?us-ascii?Q?ewR8whyHn7dwKq9pRIkbDA2oEJWAdmiMTUE9hYnD6kOEVbcRHodOzdu7yfjD?= =?us-ascii?Q?a07jYU6AF8Ds69tvAeTHltsXN327wIvFMGz5xaQ5YizoFhGuwTzEjt0+Aepo?= =?us-ascii?Q?soqDitViDtgIfKyno1XKk3O7Z9eBMqwq/E4aYUQ7gS9nh/LATgTZ76JqsOkc?= =?us-ascii?Q?xU2GZmIPBxWp9zgAjwA4PDjnrsS3vwS8fNo4I8kAm65/Fbh4CmQl56sb6uoP?= =?us-ascii?Q?4VuZxQ0nOmND7iPxKNhFEx/Z7leI00wyUSFny5/NwMggiJ8cuBHU/kWxZBgW?= =?us-ascii?Q?c3zk1XmA7E/JSok8Xs4jSKYjozki3JX5IFi0+pQ8RSunQOsH1wvd6TV4vbAg?= =?us-ascii?Q?SJUKTzSnLqMeHZUEl1C7JJZQ/N8OTtc0POmWzJmDJRR1esOvikKptUCWlQwi?= =?us-ascii?Q?5JCrTuBmfzkc8PKo031A093gAMmCeEq4BLmV+J7c3yTgME2aYGUMyvdz1rlc?= =?us-ascii?Q?CRG4wI2dlgVl2ehokImtDFSl4NEkIpswoVTNFXuYhA0bkv6c9YbUgtnqaxrr?= =?us-ascii?Q?9QuCBLwQCNvfCoAy0ADDQL0fon8Pz6AJDw/2+6Eyt4cw0O9vTUggxgXGyjDw?= =?us-ascii?Q?oB2xHY+nF3qEDEBd32VKKQTaRDOE1wojystJDrFWc/QCALoQX2JztvmC0dsa?= =?us-ascii?Q?8zjmN92k9dXHbb9IRZaaw2J733NHLph92XWT2mW2l0W3HlEm48Gahay7nY7T?= =?us-ascii?Q?KzKf7igEV9se96IWq27nJ6bq6xlNSxb7w7QEYPcYyj/agK8li5N+psYhFjm4?= =?us-ascii?Q?wD48zoL44nK9lWW6LUfJuFPzx/R/MwWaMI4GhBv2xwD1XCCW5LCY4T7qMZF/?= =?us-ascii?Q?0ubuILj15qahLfrBMCf02r31NIcQAf6UQ1XQvWUGUlp1ZNels6Txx0utZAhP?= =?us-ascii?Q?s9+/wl/5k9dw8leZqrLDr6KsejV9GGT2F9adWGZfk/vGwybwZeE3YAconiu0?= =?us-ascii?Q?IkgoRBDms5bmkDnhgWUHkJwy93KQ1mq4IvJ9J9nfJPhMo9+uAfPuWwjkZsER?= =?us-ascii?Q?Pzt3vB+GVC5hfwwWqJW8pplBYNvXWQ/n7ADycT8k2mLsFbDG4II7MUbGYpAH?= =?us-ascii?Q?Uyg5Y832riPguj3s7YmZOR6YdCU+UjKS4M6H59MXa4rC3SEYsnbCyQxwYSj/?= =?us-ascii?Q?wE7dbAF8/xQuTS76xeKAAFfe?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB6811.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NHES28fDD01A9Dx+7RqNaWmMlZmjKcTVmC91gxK6PZe3cePvwoLlMekym2Sw?= =?us-ascii?Q?gXpDGl5l9zSz7ScXdevd2NQHAOHqKII/9NuI1eGNN2A41t1XOHBlGwFPrbQy?= =?us-ascii?Q?QqeSMVqt/TWW8q9j2G9j2F8a1o6IOvDS+MpmJvXFwj0Sz9wI9FiKR7m7HOyx?= =?us-ascii?Q?NwBCVzBQNhuwSK6sp+YLPUlr82jjplZiBLW6PAgeQo9MZMpd8+YpxagWz6UC?= =?us-ascii?Q?/Id4LbkkRZkJf38AUBqC0f6rZSOMZAivuQ3RSJA5Q7BZGyxKnHN7ri9qAxjo?= =?us-ascii?Q?IkGZePOHRZfXBQpfbjDI38A6fiT3u5zMHznCnesP57xWihV1snhZEnOWOmdU?= =?us-ascii?Q?yqqZW2S3ON021aYaa7BTH6/E+lS/iON6MvtrBBa21Gm68/1VzjJjxXAyO5HE?= =?us-ascii?Q?HOiIJdyoFmB7YB5pBTjELC/IWrzXADKUWb6h0f0rSQLnDgzL1FENPIdxG4lr?= =?us-ascii?Q?x46NgfbFYRyz9OWc0g+pwXxcvIPRGsIAilYf7SRIB0wrdAAMxAQndEH5Bbbx?= =?us-ascii?Q?GM/NldbzwUWIuIkZq7nzPW4P1MaIbYq1DOzpQ3Igv8fxeAI7IIQdkOINZciT?= =?us-ascii?Q?aTODwlK+t/dt6t/Ny3KiNyuPnpmL3acw9sB/uot0rrtVgJFh8M6VN6CXpgtt?= =?us-ascii?Q?MZ6WsyBAg2qWPGKsFa3xHR2LRcFJQk/nY5J4FP9M6rIeKu7OfkzqYZ2LE2Ji?= =?us-ascii?Q?5jSQILOwVaZ2rs3Q0n7DiqZ0pjLugUAWwvdXDIggz1gfeuH0sQ2zUvGJ8Pt8?= =?us-ascii?Q?W1GzjS1lLVR6n4tciMgDQ5cXaNTK/am+bO14SDQNuVPjWFBhvS9b7QP5csdW?= =?us-ascii?Q?Dh+QoUE22l8LTyg9qsxSZ0Z6q3zTOj4aTXlaQjUO1+F2siqjIa4r/I+t9h0V?= =?us-ascii?Q?Gkm7s66n13BIQ4L0wXaiecM+YgHpu1OJX45kJB93JxBfR9NlePbXgihtTLmw?= =?us-ascii?Q?0VYuLsmfiFNSZZyfKOm5hZoswzp8hKGvWB4t6SlBhWQOg3x+d6g7Vf4NVAFg?= =?us-ascii?Q?Vpy4bhCjM9rUJyFMyINFIcuNWBTG2ZQeSCpzUfmXl4AXwhEN42i5MFEli8a3?= =?us-ascii?Q?TX7OL9OEtMkAXs83Lqb3baEpA/SZrAEYqDX8jHxli0SoObetToCaRp6pTQAL?= =?us-ascii?Q?FPTouUdBbZ7ZYlBM725Dhw8ZTjk/MPPs3nhzbOaeB3NmAsT4LFoT6XBsVTk7?= =?us-ascii?Q?TI/afun8KETul5LDlaJdQ4/7tHdIWcf6MCTffeCuLv8FcVWxOPXjmXjBljkv?= =?us-ascii?Q?K50UJQ39LmV1ZU0j+pD3oNkTMyoaR1sIJD6SmtLZ2gvHzKW4Q4TmgcbNvmJ4?= =?us-ascii?Q?pefEbkZmLey8bsdQoo+N8QnQ3HIKReImY6qiFG8TWM6V/tN0BqZ4jcstU1kB?= =?us-ascii?Q?gx+rDwsTuMC2VR4i/BCzctObZ9obAgl24F4Xq5Szrbe5iyDrR+cob6x1jZ23?= =?us-ascii?Q?CEmqhz480DF3OZM3b18sRsAybRFZvY/USccGd3bN9SKq77tKDKgN25il3BfX?= =?us-ascii?Q?CAnsJ3wxNIpjCMjIGWTiCQdVHmy8kHpxAyQSJ+kj0+x0rgSVOFViBzAvp5dS?= =?us-ascii?Q?RdIlK64Xi7q0Q8q3JGgi2b7Oq5rrlT3Ru5dovlF2?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1dd40d9-9032-4b5c-82cd-08dcf969412e X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6811.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2024 05:02:44.1922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VaXSLlnoc0rIlJOO/sn5+p24AO7AoI64QUvV/vGHDczus2ykPvZ5jDBZn7eLMuVcNH8so7P9iEXJpYRxNSbYgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6767 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Stephen, > > Did you consider that most of the hairpin_conf values could just be set directly, > avoiding intermediate variables. > fixed. > >> + diag = rte_eth_rx_hairpin_queue_setup >> + (pi, qi, nb_rxd, &hairpin_conf); > fixed.