From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD3BEA04DB; Thu, 15 Oct 2020 20:57:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C2341DA0A; Thu, 15 Oct 2020 20:57:17 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 563491D5BE for ; Thu, 15 Oct 2020 20:57:15 +0200 (CEST) IronPort-SDR: ksOqLe2LFJ+3K7GR6Fg1YqXNz0/HBeoUoDQR4C/wCo6IeCWpsAhD63CYEDBUKIoBMCmVevvRId PFCe2bAqEA5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="154252332" X-IronPort-AV: E=Sophos;i="5.77,380,1596524400"; d="scan'208";a="154252332" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 11:57:13 -0700 IronPort-SDR: UlJ5YMCa6q1afNprH4eXGhhFGngTgZCbC+iqvbhM1/ejc61L4CxdpLG1VD+LC4AyE3CRUxi7ld vqYI6Bo5QX1w== X-IronPort-AV: E=Sophos;i="5.77,380,1596524400"; d="scan'208";a="464406166" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.84.112]) ([10.251.84.112]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 11:57:12 -0700 To: Tianfei zhang , dev@dpdk.org, rosen.xu@intel.com, wei.huang@intel.com References: <1600846213-18093-1-git-send-email-tianfei.zhang@intel.com> <1601257218-6606-1-git-send-email-tianfei.zhang@intel.com> <1601257218-6606-3-git-send-email-tianfei.zhang@intel.com> From: Ferruh Yigit Message-ID: Date: Thu, 15 Oct 2020 19:57:10 +0100 MIME-Version: 1.0 In-Reply-To: <1601257218-6606-3-git-send-email-tianfei.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/4] raw/ifpga/base: free resources when destroying ifpga device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/28/2020 2:40 AM, Tianfei zhang wrote: > From: Wei Huang > > Add two functions to complete the resources free work, one > is ifpga_adapter_destroy(), the other is ifpga_bus_uinit(). > Then call opae_adapter_destroy() in ifpga_rawdev_destroy(). > > Additional modifiction is removing opae_adapter_free() from s/modifiction/modification > ifpga_rawdev_destroy() because opae adapter will be released > in rte_rawdev_pmd_release(). I can see following call stack, rte_rawdev_pmd_release() rte_rawdev_close() ifpga_rawdev_close() In this path 'opae_adapter_free()' is not called, can you please confirm if opae adapter free is done. > > Signed-off-by: Wei Huang > Signed-off-by: Tianfei zhang <...>